Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] drop unnecessary dependency to pycrypto #26611

Merged
merged 1 commit into from May 18, 2023
Merged

[python] drop unnecessary dependency to pycrypto #26611

merged 1 commit into from May 18, 2023

Conversation

agners
Copy link
Contributor

@agners agners commented May 16, 2023 •
edited

PR #21567 introduced an unnecessary dependency to pycrypto. From PyPI it seems that pycrypto is largely unmaintained, and I did not found a use in the Python bindings or in the Python tests.

Also drop the comment about cryptography and ecdsa usage as the library is meanwhile used in the core CHIP Python code.

@github-actions
Copy link

github-actions bot commented May 16, 2023 •
edited

PR #26611: Size comparison from 06921da to e49bb0e

Increases (6 builds for cc32xx, nrfconnect, psoc6, telink)
platform target config section 06921da8 e49bb0e change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20270444 20270445 1 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176340 1176356 16 0.0
text 807272 807276 4 0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22941660 22941661 1 0.0
telink light-switch-app tlsr9518adk80d text 590124 590126 2 0.0
lock-app tlsr9518adk80d text 603986 603988 2 0.0
pump-controller-app tlsr9518adk80d text 571792 571794 2 0.0
Decreases (12 builds for bl602, bl702, efr32, psoc6, telink)
platform target config section 06921da8 e49bb0e change % change
bl602 lighting-app bl602+rpc (read/write) 1401390 1401382 -8 -0.0
.text 1067370 1067366 -4 -0.0
bl702 lighting-app bl702 (read only) 970002 970000 -2 -0.0
.debug_info 41769039 41769038 -1 -0.0
.text 966132 966130 -2 -0.0
bl702+rpc .debug_info 46692064 46692063 -1 -0.0
.text 1039520 1039518 -2 -0.0
efr32 lighting-app BRD4187C (read/write) 1000848 1000840 -8 -0.0
.text 838628 838620 -8 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27821692 27821690 -2 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27585961 27585960 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 23110439 23110438 -1 -0.0
telink all-clusters-minimal-app tlsr9518adk80d (read/write) 937852 937844 -8 -0.0
text 642630 642628 -2 -0.0
bridge-app tlsr9518adk80d (read/write) 919112 919104 -8 -0.0
text 635270 635268 -2 -0.0
contact-sensor-app tlsr9518adk80d text 575496 575494 -2 -0.0
thermostat tlsr9518adk80d (read/write) 868364 868356 -8 -0.0
text 591842 591840 -2 -0.0
window-covering tlsr9518adk80d text 587528 587526 -2 -0.0
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 06921da8 e49bb0e change % change
bl602 lighting-app bl602 (read/write) 1355114 1355114 0 0.0
.bss 87886 87886 0 0.0
.data 9648 9648 0 0.0
.text 1036012 1036012 0 0.0
bl602+rpc (read/write) 1401390 1401382 -8 -0.0
.bss 95934 95934 0 0.0
.data 10040 10040 0 0.0
.text 1067370 1067366 -4 -0.0
bl702 lighting-app bl702 (read only) 970002 970000 -2 -0.0
(read/write) 220159 220159 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67585 67585 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1553790 1553790 0 0.0
.debug_aranges 134960 134960 0 0.0
.debug_frame 496296 496296 0 0.0
.debug_info 41769039 41769038 -1 -0.0
.debug_line 5344671 5344671 0 0.0
.debug_loc 3471043 3471043 0 0.0
.debug_ranges 374320 374320 0 0.0
.debug_str 3787536 3787536 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106400 106400 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 581248 581248 0 0.0
.symtab 175456 175456 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
966132 966130 -2 -0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1275603 1275603 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75633 75633 0 0.0
.bss_psram 25056 25056 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1712800 1712800 0 0.0
.debug_aranges 143248 143248 0 0.0
.debug_frame 524308 524308 0 0.0
.debug_info 46692064 46692063 -1 -0.0
.debug_line 5760507 5760507 0 0.0
.debug_loc 3673791 3673791 0 0.0
.debug_ranges 399680 399680 0 0.0
.debug_str 4212915 4212915 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120480 120480 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 642568 642568 0 0.0
.symtab 193952 193952 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1039520 1039518 -2 -0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 604994 604994 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956415 956415 0 0.0
.debug_aranges 103272 103272 0 0.0
.debug_frame 349280 349280 0 0.0
.debug_info 20270444 20270445 1 0.0
.debug_line 2698111 2698111 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1517485 1517485 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 95954 95954 0 0.0
.debug_str 3212643 3212643 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104322 104322 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483161 483161 0 0.0
.symtab 287232 287232 0 0.0
.text 498548 498548 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 524339 524339 0 0.0
.app_xip_area 417133 417133 0 0.0
.bss 62184 62184 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 529019 529019 0 0.0
.app_xip_area 416509 416509 0 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566187 566187 0 0.0
.app_xip_area 459741 459741 0 0.0
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 530939 530939 0 0.0
.app_xip_area 421925 421925 0 0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 964060 964060 0 0.0
.bss 179672 179672 0 0.0
.data 2136 2136 0 0.0
.text 782232 782232 0 0.0
BRD4187C (read/write) 1000848 1000840 -8 -0.0
.bss 159420 159420 0 0.0
.data 2780 2780 0 0.0
.text 838628 838620 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1068652 1068652 0 0.0
.bss 174144 174144 0 0.0
.data 2152 2152 0 0.0
.text 892336 892336 0 0.0
window-app BRD4187C (read/write) 1075808 1075808 0 0.0
.bss 143876 143876 0 0.0
.data 2676 2676 0 0.0
.text 929236 929236 0 0.0
esp32 all-clusters-app c3devkit (read only) 1053032 1053032 0 0.0
(read/write) 1583400 1583400 0 0.0
.dram0.bss 77136 77136 0 0.0
.dram0.data 13968 13968 0 0.0
.flash.rodata 213168 213168 0 0.0
.flash.text 1053032 1053032 0 0.0
.iram0.text 76708 76708 0 0.0
m5stack (read only) 1100931 1100931 0 0.0
(read/write) 492582 492582 0 0.0
.dram0.bss 82152 82152 0 0.0
.dram0.data 34304 34304 0 0.0
.flash.rodata 240976 240976 0 0.0
.flash.text 1095547 1095547 0 0.0
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 583548 583548 0 0.0
(read/write) 82704 82704 0 0.0
.bss 65888 65888 0 0.0
.data 2192 2192 0 0.0
.text 583012 583012 0 0.0
light k32w0+release (read only) 582404 582404 0 0.0
(read/write) 82356 82356 0 0.0
.bss 65552 65552 0 0.0
.data 2180 2180 0 0.0
.text 581868 581868 0 0.0
lock k32w0+release (read only) 555956 555956 0 0.0
(read/write) 80352 80352 0 0.0
.bss 63624 63624 0 0.0
.data 2104 2104 0 0.0
.text 555420 555420 0 0.0
linux all-clusters-app debug (read only) 3138037 3138037 0 0.0
(read/write) 152352 152352 0 0.0
.bss 60064 60064 0 0.0
.data 2160 2160 0 0.0
.data.rel.ro 83640 83640 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 229544 229544 0 0.0
.text 2722853 2722853 0 0.0
all-clusters-minimal-app debug (read only) 2951581 2951581 0 0.0
(read/write) 145568 145568 0 0.0
.bss 59232 59232 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 77816 77816 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 223240 223240 0 0.0
.text 2546117 2546117 0 0.0
bridge-app debug (read only) 2515237 2515237 0 0.0
(read/write) 129360 129360 0 0.0
.bss 49976 49976 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 69552 69552 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 172456 172456 0 0.0
.text 2170533 2170533 0 0.0
chip-tool debug (read only) 13409841 13409841 0 0.0
(read/write) 694056 694056 0 0.0
.bss 26424 26424 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 657800 657800 0 0.0
.dynamic 608 608 0 0.0
.got 5360 5360 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 630797 630797 0 0.0
.text 11166180 11166180 0 0.0
chip-tool-ipv6only arm64 (read only) 12636700 12636700 0 0.0
(read/write) 745640 745640 0 0.0
.bss 34392 34392 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 687064 687064 0 0.0
.dynamic 560 560 0 0.0
.got 15968 15968 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 576720 576720 0 0.0
.text 10290724 10290724 0 0.0
dynamic-bridge-app-ipv6only debug (read only) 2578837 2578837 0 0.0
(read/write) 126552 126552 0 0.0
.bss 47288 47288 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 70136 70136 0 0.0
.dynamic 624 624 0 0.0
.got 4800 4800 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 175176 175176 0 0.0
.text 2226373 2226373 0 0.0
lighting-app debug+rpc+ui (read only) 3241825 3241825 0 0.0
(read/write) 132144 132144 0 0.0
.bss 47968 47968 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 74680 74680 0 0.0
.dynamic 656 656 0 0.0
.got 5240 5240 0 0.0
.init 27 27 0 0.0
.init_array 872 872 0 0.0
.rodata 283860 283860 0 0.0
.text 2766242 2766242 0 0.0
lock-app debug (read only) 2654029 2654029 0 0.0
(read/write) 123496 123496 0 0.0
.bss 45888 45888 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 69592 69592 0 0.0
.dynamic 608 608 0 0.0
.got 4648 4648 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 205480 205480 0 0.0
.text 2275925 2275925 0 0.0
ota-provider-app debug (read only) 2207109 2207109 0 0.0
(read/write) 103640 103640 0 0.0
.bss 44528 44528 0 0.0
.data 2112 2112 0 0.0
.data.rel.ro 51888 51888 0 0.0
.dynamic 608 608 0 0.0
.got 3800 3800 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 153608 153608 0 0.0
.text 1912053 1912053 0 0.0
ota-requestor-app debug (read only) 2374093 2374093 0 0.0
(read/write) 111336 111336 0 0.0
.bss 46896 46896 0 0.0
.data 2512 2512 0 0.0
.data.rel.ro 56744 56744 0 0.0
.dynamic 608 608 0 0.0
.got 3784 3784 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 157672 157672 0 0.0
.text 2066101 2066101 0 0.0
shell debug (read only) 2674889 2674889 0 0.0
(read/write) 140840 140840 0 0.0
.bss 59016 59016 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 74760 74760 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 198034 198034 0 0.0
.text 2315074 2315074 0 0.0
thermostat-no-ble arm64 (read only) 2519684 2519684 0 0.0
(read/write) 142392 142392 0 0.0
.bss 53464 53464 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77672 77672 0 0.0
.dynamic 560 560 0 0.0
.got 5424 5424 0 0.0
.init 24 24 0 0.0
.init_array 384 384 0 0.0
.rodata 129256 129256 0 0.0
.text 2127156 2127156 0 0.0
tv-app debug (read only) 3310009 3310009 0 0.0
(read/write) 261256 261256 0 0.0
.bss 171008 171008 0 0.0
.data 4080 4080 0 0.0
.data.rel.ro 79424 79424 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 221912 221912 0 0.0
.text 2891986 2891986 0 0.0
tv-casting-app debug (read only) 7220689 7220689 0 0.0
(read/write) 192208 192208 0 0.0
.bss 52096 52096 0 0.0
.data 1744 1744 0 0.0
.data.rel.ro 131808 131808 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 1000 1000 0 0.0
.rodata 313036 313036 0 0.0
.text 6546306 6546306 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2495128 2495128 0 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1457812 1457812 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1176340 1176356 16 0.0
bss 155563 155563 0 0.0
rodata 132756 132756 0 0.0
text 807272 807276 4 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1436084 1436084 0 0.0
bss 135303 135303 0 0.0
rodata 228772 228772 0 0.0
text 777936 777936 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1123448 1123448 0 0.0
bss 154757 154757 0 0.0
rodata 109752 109752 0 0.0
text 778212 778212 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840680 840680 0 0.0
(read/write) 1706636 1706636 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190108 190108 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1282123 1282123 0 0.0
.debug_aranges 130336 130336 0 0.0
.debug_frame 433008 433008 0 0.0
.debug_info 27821692 27821690 -2 -0.0
.debug_line 3785965 3785965 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2048101 2048101 0 0.0
.debug_rnglists 129638 129638 0 0.0
.debug_str 3720949 3720949 0 0.0
.heap 840680 840680 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 716243 716243 0 0.0
.symtab 466336 466336 0 0.0
.text 0 0 0 0.0
1505588 1505588 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841440 841440 0 0.0
(read/write) 1648948 1648948 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189348 189348 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1276979 1276979 0 0.0
.debug_aranges 129808 129808 0 0.0
.debug_frame 436076 436076 0 0.0
.debug_info 27585961 27585960 -1 -0.0
.debug_line 3808666 3808666 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2041195 2041195 0 0.0
.debug_rnglists 128802 128802 0 0.0
.debug_str 3712651 3712651 0 0.0
.heap 841440 841440 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 674931 674931 0 0.0
.symtab 451648 451648 0 0.0
.text 1448660 1448660 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849736 849736 0 0.0
(read/write) 1570580 1570580 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181220 181220 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2384 2384 0 0.0
.debug_abbrev 1110199 1110199 0 0.0
.debug_aranges 119960 119960 0 0.0
.debug_frame 399312 399312 0 0.0
.debug_info 22941660 22941661 1 0.0
.debug_line 3371664 3371664 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1872709 1872709 0 0.0
.debug_rnglists 118431 118431 0 0.0
.debug_str 3518630 3518630 0 0.0
.heap 849736 849736 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 590984 590984 0 0.0
.symtab 414096 414096 0 0.0
.text 1378588 1378588 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821952 821952 0 0.0
(read/write) 1627068 1627068 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208996 208996 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1109240 1109240 0 0.0
.debug_aranges 120464 120464 0 0.0
.debug_frame 401404 401404 0 0.0
.debug_info 23110439 23110438 -1 -0.0
.debug_line 3368046 3368046 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1886136 1886136 0 0.0
.debug_rnglists 118887 118887 0 0.0
.debug_str 3533612 3533612 0 0.0
.heap 821952 821952 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 594985 594985 0 0.0
.symtab 416400 416400 0 0.0
.text 1407292 1407292 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1170184 1170184 0 0.0
.bss 99928 99928 0 0.0
.data 856 856 0 0.0
.text 617284 617284 0 0.0
lock-app qpg6105+debug (read/write) 1139548 1139548 0 0.0
.bss 94824 94824 0 0.0
.data 856 856 0 0.0
.text 586648 586648 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1001140 1001140 0 0.0
bss 97912 97912 0 0.0
text 680064 680064 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 937852 937844 -8 -0.0
bss 97004 97004 0 0.0
text 642630 642628 -2 -0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 919112 919104 -8 -0.0
bss 99220 99220 0 0.0
text 635270 635268 -2 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 847672 847672 0 0.0
bss 88904 88904 0 0.0
text 575496 575494 -2 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 863968 863968 0 0.0
bss 89060 89060 0 0.0
text 590124 590126 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934428 934428 0 0.0
bss 97376 97376 0 0.0
text 652306 652306 0 0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 945840 945840 0 0.0
bss 101624 101624 0 0.0
text 659864 659864 0 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1002704 1002704 0 0.0
bss 98940 98940 0 0.0
text 696020 696020 0 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 902512 902512 0 0.0
bss 89556 89556 0 0.0
text 603986 603988 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 870560 870560 0 0.0
bss 90176 90176 0 0.0
text 597596 597596 0 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 853520 853520 0 0.0
bss 89024 89024 0 0.0
text 581520 581520 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 840468 840468 0 0.0
bss 88824 88824 0 0.0
text 571792 571794 2 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 836704 836704 0 0.0
bss 88744 88744 0 0.0
text 567504 567504 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 868364 868356 -8 -0.0
bss 90448 90448 0 0.0
text 591842 591840 -2 -0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 865016 865016 0 0.0
bss 90868 90868 0 0.0
text 587528 587526 -2 -0.0

@agners
[python] drop unnecessary dependency to pycrypto
fe155a4 
PR project-chip#21567 introduced an unnecessary dependency to pycrypto. From PyPI it
seems that pycrypto is largely unmaintained, and I did not found a use
in the Python bindings or in the Python test.

Also drop the comment about cryptography and ecdsa usage as the library
is meanwhile used in the core CHIP Python libraries.
@github-actions
Copy link

github-actions bot commented May 17, 2023 •
edited

PR #26611: Size comparison from f1e0f68 to fe155a4

Increases (7 builds for cyw30739, esp32, psoc6, telink)
platform target config section f1e0f68 fe155a4 change % change
cyw30739 lock cyw930739m2evb_01 (read/write) 529131 529139 8 0.0
.app_xip_area 416621 416629 8 0.0
esp32 all-clusters-app c3devkit (read only) 1053938 1053940 2 0.0
.flash.text 1053938 1053940 2 0.0
m5stack (read/write) 492858 492862 4 0.0
.flash.rodata 241212 241216 4 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27626269 27626270 1 0.0
telink light-switch-app tlsr9518adk80d (read/write) 863960 863968 8 0.0
text 590120 590122 2 0.0
lighting-app-factory-data tlsr9518adk80d text 660014 660016 2 0.0
lock-app tlsr9518adk80d (read/write) 902656 902664 8 0.0
text 604136 604138 2 0.0
Decreases (12 builds for bl602, bl702, psoc6, qpg, telink)
platform target config section f1e0f68 fe155a4 change % change
bl602 lighting-app bl602+rpc (read/write) 1402114 1402106 -8 -0.0
.text 1067370 1067368 -2 -0.0
bl702 lighting-app bl702+rpc .debug_info 46725953 46725951 -2 -0.0
.text 1039776 1039772 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 28000406 28000405 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 22973743 22973742 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 23141939 23141938 -1 -0.0
qpg lock-app qpg6105+debug (read/write) 1139540 1139532 -8 -0.0
.text 586640 586632 -8 -0.0
telink all-clusters-minimal-app tlsr9518adk80d text 642816 642814 -2 -0.0
bridge-app tlsr9518adk80d text 635464 635462 -2 -0.0
lighting-app tlsr9518adk80d (read/write) 934588 934580 -8 -0.0
text 652462 652458 -4 -0.0
pump-controller-app tlsr9518adk80d text 571792 571790 -2 -0.0
temperature-measurement-app tlsr9518adk80d (read/write) 836704 836696 -8 -0.0
text 567502 567500 -2 -0.0
thermostat tlsr9518adk80d text 591840 591836 -4 -0.0
Full report (45 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section f1e0f68 fe155a4 change % change
bl602 lighting-app bl602 (read/write) 1356094 1356094 0 0.0
.bss 87886 87886 0 0.0
.data 9648 9648 0 0.0
.text 1036268 1036268 0 0.0
bl602+rpc (read/write) 1402114 1402106 -8 -0.0
.bss 95934 95934 0 0.0
.data 10040 10040 0 0.0
.text 1067370 1067368 -2 -0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1187791 1187791 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67585 67585 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1553810 1553810 0 0.0
.debug_aranges 135056 135056 0 0.0
.debug_frame 496668 496668 0 0.0
.debug_info 41802624 41802624 0 0.0
.debug_line 5347152 5347152 0 0.0
.debug_loc 3473576 3473576 0 0.0
.debug_ranges 374456 374456 0 0.0
.debug_str 3790166 3790166 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107120 107120 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 581292 581292 0 0.0
.symtab 175472 175472 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
966386 966386 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1276595 1276595 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75633 75633 0 0.0
.bss_psram 25056 25056 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1712820 1712820 0 0.0
.debug_aranges 143344 143344 0 0.0
.debug_frame 524680 524680 0 0.0
.debug_info 46725953 46725951 -2 -0.0
.debug_line 5762988 5762988 0 0.0
.debug_loc 3676294 3676294 0 0.0
.debug_ranges 399816 399816 0 0.0
.debug_str 4215545 4215545 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121216 121216 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 642612 642612 0 0.0
.symtab 193968 193968 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1039776 1039772 -4 -0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 605234 605234 0 0.0
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 956414 956414 0 0.0
.debug_aranges 103376 103376 0 0.0
.debug_frame 349648 349648 0 0.0
.debug_info 20300483 20300483 0 0.0
.debug_line 2699644 2699644 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1518946 1518946 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 96048 96048 0 0.0
.debug_str 3215368 3215368 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104322 104322 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 483205 483205 0 0.0
.symtab 287296 287296 0 0.0
.text 498788 498788 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 524459 524459 0 0.0
.app_xip_area 417253 417253 0 0.0
.bss 62184 62184 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 529131 529139 8 0.0
.app_xip_area 416621 416629 8 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566163 566163 0 0.0
.app_xip_area 459717 459717 0 0.0
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 530931 530931 0 0.0
.app_xip_area 421917 421917 0 0.0
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 963420 963420 0 0.0
.bss 179672 179672 0 0.0
.data 2136 2136 0 0.0
.text 781592 781592 0 0.0
BRD4187C (read/write) 1000736 1000736 0 0.0
.bss 159420 159420 0 0.0
.data 2780 2780 0 0.0
.text 838516 838516 0 0.0
lock-app BRD4161A+wf200 (read/write) 1068476 1068476 0 0.0
.bss 174144 174144 0 0.0
.data 2152 2152 0 0.0
.text 892160 892160 0 0.0
window-app BRD4187C (read/write) 1075640 1075640 0 0.0
.bss 143876 143876 0 0.0
.data 2676 2676 0 0.0
.text 929068 929068 0 0.0
esp32 all-clusters-app c3devkit (read only) 1053938 1053940 2 0.0
(read/write) 1583688 1583688 0 0.0
.dram0.bss 77176 77176 0 0.0
.dram0.data 13968 13968 0 0.0
.flash.rodata 213408 213408 0 0.0
.flash.text 1053938 1053940 2 0.0
.iram0.text 76708 76708 0 0.0
m5stack (read only) 1101871 1101871 0 0.0
(read/write) 492858 492862 4 0.0
.dram0.bss 82192 82192 0 0.0
.dram0.data 34304 34304 0 0.0
.flash.rodata 241212 241216 4 0.0
.flash.text 1096487 1096487 0 0.0
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 583548 583548 0 0.0
(read/write) 82704 82704 0 0.0
.bss 65888 65888 0 0.0
.data 2192 2192 0 0.0
.text 583012 583012 0 0.0
light k32w0+release (read only) 582516 582516 0 0.0
(read/write) 82356 82356 0 0.0
.bss 65552 65552 0 0.0
.data 2180 2180 0 0.0
.text 581980 581980 0 0.0
lock k32w0+release (read only) 555956 555956 0 0.0
(read/write) 80352 80352 0 0.0
.bss 63624 63624 0 0.0
.data 2104 2104 0 0.0
.text 555420 555420 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12651788 12651788 0 0.0
(read/write) 745960 745960 0 0.0
.bss 34392 34392 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 687376 687376 0 0.0
.dynamic 560 560 0 0.0
.got 15976 15976 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 576976 576976 0 0.0
.text 10305028 10305028 0 0.0
thermostat-no-ble arm64 (read only) 2519684 2519684 0 0.0
(read/write) 142392 142392 0 0.0
.bss 53464 53464 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77672 77672 0 0.0
.dynamic 560 560 0 0.0
.got 5424 5424 0 0.0
.init 24 24 0 0.0
.init_array 384 384 0 0.0
.rodata 129256 129256 0 0.0
.text 2127156 2127156 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2495256 2495256 0 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1457940 1457940 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1177452 1177452 0 0.0
bss 155605 155605 0 0.0
rodata 132988 132988 0 0.0
text 808136 808136 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1437244 1437244 0 0.0
bss 135345 135345 0 0.0
rodata 229004 229004 0 0.0
text 778796 778796 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1123592 1123592 0 0.0
bss 154757 154757 0 0.0
rodata 109752 109752 0 0.0
text 778348 778348 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840640 840640 0 0.0
(read/write) 1708124 1708124 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190148 190148 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1287292 1287292 0 0.0
.debug_aranges 130664 130664 0 0.0
.debug_frame 434004 434004 0 0.0
.debug_info 28000406 28000405 -1 -0.0
.debug_line 3797011 3797011 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2051762 2051762 0 0.0
.debug_rnglists 129947 129947 0 0.0
.debug_str 3726673 3726673 0 0.0
.heap 840640 840640 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 718721 718721 0 0.0
.symtab 467296 467296 0 0.0
.text 0 0 0 0.0
1507036 1507036 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841440 841440 0 0.0
(read/write) 1649188 1649188 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189348 189348 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2552 2552 0 0.0
.debug_abbrev 1276979 1276979 0 0.0
.debug_aranges 129912 129912 0 0.0
.debug_frame 436444 436444 0 0.0
.debug_info 27626269 27626270 1 0.0
.debug_line 3810203 3810203 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2042675 2042675 0 0.0
.debug_rnglists 128896 128896 0 0.0
.debug_str 3715376 3715376 0 0.0
.heap 841440 841440 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 674975 674975 0 0.0
.symtab 451712 451712 0 0.0
.text 1448900 1448900 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849736 849736 0 0.0
(read/write) 1570820 1570820 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181220 181220 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2384 2384 0 0.0
.debug_abbrev 1110199 1110199 0 0.0
.debug_aranges 120064 120064 0 0.0
.debug_frame 399680 399680 0 0.0
.debug_info 22973743 22973742 -1 -0.0
.debug_line 3373198 3373198 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1874168 1874168 0 0.0
.debug_rnglists 118525 118525 0 0.0
.debug_str 3521355 3521355 0 0.0
.heap 849736 849736 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 591028 591028 0 0.0
.symtab 414160 414160 0 0.0
.text 1378828 1378828 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821952 821952 0 0.0
(read/write) 1627308 1627308 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208996 208996 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1109240 1109240 0 0.0
.debug_aranges 120568 120568 0 0.0
.debug_frame 401772 401772 0 0.0
.debug_info 23141939 23141938 -1 -0.0
.debug_line 3369580 3369580 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1887595 1887595 0 0.0
.debug_rnglists 118981 118981 0 0.0
.debug_str 3536337 3536337 0 0.0
.heap 821952 821952 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 595029 595029 0 0.0
.symtab 416464 416464 0 0.0
.text 1407532 1407532 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1170296 1170296 0 0.0
.bss 99928 99928 0 0.0
.data 856 856 0 0.0
.text 617396 617396 0 0.0
lock-app qpg6105+debug (read/write) 1139540 1139532 -8 -0.0
.bss 94824 94824 0 0.0
.data 856 856 0 0.0
.text 586640 586632 -8 -0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1002424 1002424 0 0.0
bss 97952 97952 0 0.0
text 681048 681048 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 938036 938036 0 0.0
bss 97004 97004 0 0.0
text 642816 642814 -2 -0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 919432 919432 0 0.0
bss 99348 99348 0 0.0
text 635464 635462 -2 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 847672 847672 0 0.0
bss 88904 88904 0 0.0
text 575494 575494 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 863960 863968 8 0.0
bss 89060 89060 0 0.0
text 590120 590122 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934588 934580 -8 -0.0
bss 97376 97376 0 0.0
text 652462 652458 -4 -0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 945992 945992 0 0.0
bss 101624 101624 0 0.0
text 660014 660016 2 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1002856 1002856 0 0.0
bss 98940 98940 0 0.0
text 696170 696170 0 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 902656 902664 8 0.0
bss 89556 89556 0 0.0
text 604136 604138 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 870552 870552 0 0.0
bss 90176 90176 0 0.0
text 597588 597588 0 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 853672 853672 0 0.0
bss 89024 89024 0 0.0
text 581670 581670 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 840468 840468 0 0.0
bss 88824 88824 0 0.0
text 571792 571790 -2 -0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 836704 836696 -8 -0.0
bss 88744 88744 0 0.0
text 567502 567500 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 868356 868356 0 0.0
bss 90448 90448 0 0.0
text 591840 591836 -4 -0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 865016 865016 0 0.0
bss 90868 90868 0 0.0
text 587528 587528 0 0.0

@andy31415 andy31415 merged commit 675a7ca into project-chip:master May 18, 2023
52 checks passed
@agners agners deleted the fix-python-dependencies branch May 22, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@andy31415 andy31415 Awaiting requested review from andy31415

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees
No one assigned
Labels
controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@agners @andy31415 @bzbarsky-apple