-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify cluster XML update #26738
Identify cluster XML update #26738
Conversation
PR #26738: Size comparison from 1efbaf6 to d4a3cf5 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
PR #26738: Size comparison from 1efbaf6 to 66d7d7a Increases (3 builds for cc32xx, linux)
Decreases (2 builds for cc32xx, linux)
Full report (4 builds for cc32xx, linux, mbed)
|
PR #26738: Size comparison from 1efbaf6 to 5f1fb74 Increases (13 builds for cc32xx, esp32, linux, nrfconnect)
Decreases (5 builds for cc32xx, esp32, nrfconnect)
Full report (20 builds for cc32xx, esp32, linux, mbed, nrfconnect)
|
PR #26738: Size comparison from 1efbaf6 to a1854fc Increases (35 builds for bl602, bl702, cc32xx, efr32, esp32, linux, nrfconnect, qpg, telink)
Decreases (18 builds for bl702, cc32xx, efr32, k32w, nrfconnect, telink)
Full report (48 builds for bl602, bl702, cc32xx, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
|
PR #26738: Size comparison from 1efbaf6 to 4f706ca Increases (53 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for cc32xx, efr32, esp32, psoc6)
Full report (56 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably also run scripts/tools/zap_convert_all.py
to update all the ZAP files with the new attribute type.
@fessehaeve Oh, and you want to remove the old enum names from |
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
PR #26738: Size comparison from 9f43988 to dba78aa Increases (52 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (14 builds for bl702, cc32xx, efr32, esp32, psoc6, telink)
Full report (69 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #26738: Size comparison from 01912a9 to 06b30af Increases (50 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (18 builds for bl602, bl702, cc32xx, efr32, k32w, nrfconnect, psoc6, telink)
Full report (69 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@fessehaeve this needs some spell fixes (or appropriate quoting updates) |
@andy31415 how to fix this? |
@fessehaeve The relevant strings are:
Those need to either be in backticks (or other appropriate formatting) in the README files to indicate they are code or should be added to |
PR #26738: Size comparison from ad5253a to f40a8b7 Increases (51 builds for bl602, bl702, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (16 builds for bl702, cc32xx, efr32, k32w, nrfconnect, psoc6, telink)
Full report (77 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
7bb8578
to
f2da218
Compare
PR #26738: Size comparison from 19ae369 to f2da218 Increases (51 builds for bl602, bl702, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, telink)
Decreases (19 builds for bl602, bl702, cc13x2_26x2, cc32xx, efr32, nrfconnect, psoc6, telink)
Full report (77 builds for bl602, bl702, cc13x2_26x2, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Changes happened in project-chip#26738.
Changes happened in #26738.
Update identify cluster XML changes as described in #26554