Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do proper ACL checks on event reads/subscriptions. #26761

Merged
merged 8 commits into from Jun 14, 2023
Merged

Do proper ACL checks on event reads/subscriptions. #26761

merged 8 commits into from Jun 14, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented May 23, 2023 •
edited

This adds the following functionality:

  1. We now correctly detect subsciptions that don't have any access to anything, even if they have an event path in the subscribe request. For paths with a wildcard event id, this check is only enabled when we have event lists enabled.
  2. When doing reads of an unsupported event, correctly return an UNSUPPORTED_EVENT error instead of an empty event list.
  3. Fix various unit test mocks to provide the information needed for the new checks.
  4. Update expectation in existing YAML test that was checking an "unimplemented event" case.

@bzbarsky-apple bzbarsky-apple changed the title Use EventList data to do proper checks on event reads/subscriptions. Do proper ACL checks on event reads/subscriptions. Jun 7, 2023
@bzbarsky-apple bzbarsky-apple force-pushed the use-event-list-for-checks branch 2 times, most recently from c0b425a to 7bbf873 Compare June 7, 2023 19:47
@github-actions
Copy link

github-actions bot commented Jun 7, 2023 •
edited

PR #26761: Size comparison from dd21e4e to 7bbf873

Increases (27 builds for bl602, bl702, cc32xx, efr32, k32w, linux, qpg)
platform target config section dd21e4e 7bbf873 change % change
bl602 lighting-app bl602 (read/write) 1367922 1368642 720 0.1
.text 1047894 1048614 720 0.1
bl602+rpc (read/write) 1414910 1415886 976 0.1
.text 1079518 1080494 976 0.1
bl702 lighting-app bl702 (read/write) 1199871 1200591 720 0.1
.debug_abbrev 1552228 1552328 100 0.0
.debug_aranges 149424 149472 48 0.0
.debug_frame 550040 550292 252 0.0
.debug_info 44992431 44996955 4524 0.0
.debug_line 5604316 5606603 2287 0.0
.debug_loc 3830718 3832769 2051 0.1
.debug_ranges 398096 398432 336 0.1
.debug_str 4343615 4343986 371 0.0
.strtab 582046 582654 608 0.1
.symtab 175456 175552 96 0.1
.text 978320 979032 712 0.1
bl702+rpc (read/write) 1289395 1290355 960 0.1
.debug_abbrev 1711296 1711396 100 0.0
.debug_aranges 157712 157760 48 0.0
.debug_frame 578052 578304 252 0.0
.debug_info 4994006 49944592 4524 0.0
.debug_line 6020358 6022670 2312 0.0
.debug_loc 4033819 4035899 2080 0.1
.debug_ranges 423576 423912 336 0.1
.debug_str 4769091 4769462 371 0.0
.strtab 643549 644157 608 0.1
.symtab 194016 194112 96 0.0
.text 1051978 1052944 966 0.1
cc32xx lock CC3235SF_LAUNCHXL (read only) 606178 606794 616 0.1
.debug_abbrev 952074 952163 89 0.0
.debug_aranges 118800 118856 56 0.0
.debug_frame 405752 405972 220 0.1
.debug_info 23076175 23080794 4619 0.0
.debug_line 2878685 2880153 1468 0.1
.debug_loclists 1724555 1725817 1262 0.1
.debug_rnglists 107433 107510 77 0.1
.debug_str 3784160 3784539 379 0.0
.strtab 484563 485171 608 0.1
.symtab 287712 287904 192 0.1
.text 499512 500128 616 0.1
efr32 lighting-app BRD4161A+rs9116 (read/write) 986508 987116 608 0.1
.text 804472 805080 608 0.1
BRD4187C (read/write) 1019896 1020448 552 0.1
.text 857484 858036 552 0.1
lock-app BRD4161A+wf200 (read/write) 1069144 1069672 528 0.0
.text 892812 893340 528 0.1
window-app BRD4187C (read/write) 1088800 1089408 608 0.1
.text 943528 944136 608 0.1
k32w contact k32w0+release (read only) 584748 585308 560 0.1
.text 584212 584772 560 0.1
light k32w0+release (read only) 583452 583996 544 0.1
.text 582916 583460 544 0.1
lock k32w0+release (read only) 556044 556604 560 0.1
.text 555508 556068 560 0.1
linux all-clusters-app debug (read only) 3264453 3266725 2272 0.1
.text 2842037 2844309 2272 0.1
all-clusters-minimal-app debug (read only) 3042277 3044533 2256 0.1
.text 2632373 2634629 2256 0.1
bridge-app debug (read only) 2521341 2523613 2272 0.1
.text 2175909 2178181 2272 0.1
chip-tool debug (read only) 15574585 15576969 2384 0.0
.text 13240132 13242516 2384 0.0
chip-tool-ipv6only arm64 (read only) 14890436 14892660 2224 0.0
(read/write) 762712 762728 16 0.0
.data.rel.ro 703320 703344 24 0.0
.text 12462500 12464708 2208 0.0
lighting-app debug+rpc+ui (read only) 3386577 3388833 2256 0.1
.text 2902898 2905154 2256 0.1
lock-app debug (read only) 2613973 2616229 2256 0.1
.text 2249285 2251541 2256 0.1
ota-provider-app debug (read only) 2211085 2213341 2256 0.1
.text 1915333 1917589 2256 0.1
ota-requestor-app debug (read only) 2379605 2381877 2272 0.1
.text 2070885 2073157 2272 0.1
shell debug (read only) 2798145 2800417 2272 0.1
.text 2431618 2433890 2272 0.1
thermostat-no-ble arm64 (read only) 2607084 2609196 2112 0.1
(read/write) 143032 143048 16 0.0
.data.rel.ro 79336 79360 24 0.0
.text 2211700 2213780 2080 0.1
tv-app debug (read only) 3316145 3318417 2272 0.1
.text 2897394 2899666 2272 0.1
tv-casting-app debug (read only) 9116385 9118641 2256 0.0
.text 8357682 8359938 2256 0.0
qpg lighting-app qpg6105+debug (read/write) 1170564 1171108 544 0.0
.text 617660 618204 544 0.1
lock-app qpg6105+debug (read/write) 1139844 1140388 544 0.0
.text 586944 587488 544 0.1
Full report (27 builds for bl602, bl702, cc32xx, efr32, k32w, linux, qpg)
platform target config section dd21e4e 7bbf873 change % change
bl602 lighting-app bl602 (read/write) 1367922 1368642 720 0.1
.bss 87902 87902 0 0.0
.data 9648 9648 0 0.0
.text 1047894 1048614 720 0.1
bl602+rpc (read/write) 1414910 1415886 976 0.1
.bss 95950 95950 0 0.0
.data 10040 10040 0 0.0
.text 1079518 1080494 976 0.1
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1199871 1200591 720 0.1
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67601 67601 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1552228 1552328 100 0.0
.debug_aranges 149424 149472 48 0.0
.debug_frame 550040 550292 252 0.0
.debug_info 44992431 44996955 4524 0.0
.debug_line 5604316 5606603 2287 0.0
.debug_loc 3830718 3832769 2051 0.1
.debug_ranges 398096 398432 336 0.1
.debug_str 4343615 4343986 371 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107264 107264 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 582046 582654 608 0.1
.symtab 175456 175552 96 0.1
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
978320 979032 712 0.1
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1289395 1290355 960 0.1
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75649 75649 0 0.0
.bss_psram 25056 25056 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1711296 1711396 100 0.0
.debug_aranges 157712 157760 48 0.0
.debug_frame 578052 578304 252 0.0
.debug_info 4994006 49944592 4524 0.0
.debug_line 6020358 6022670 2312 0.0
.debug_loc 4033819 4035899 2080 0.1
.debug_ranges 423576 423912 336 0.1
.debug_str 4769091 4769462 371 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121792 121792 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 643549 644157 608 0.1
.symtab 194016 194112 96 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1051978 1052944 966 0.1
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 606178 606794 616 0.1
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 952074 952163 89 0.0
.debug_aranges 118800 118856 56 0.0
.debug_frame 405752 405972 220 0.1
.debug_info 23076175 23080794 4619 0.0
.debug_line 2878685 2880153 1468 0.1
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1724555 1725817 1262 0.1
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 107433 107510 77 0.1
.debug_str 3784160 3784539 379 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104546 104546 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 484563 485171 608 0.1
.symtab 287712 287904 192 0.1
.text 499512 500128 616 0.1
efr32 lighting-app BRD4161A+rs9116 (read/write) 986508 987116 608 0.1
.bss 179872 179872 0 0.0
.data 2144 2144 0 0.0
.text 804472 805080 608 0.1
BRD4187C (read/write) 1019896 1020448 552 0.1
.bss 159604 159604 0 0.0
.data 2788 2788 0 0.0
.text 857484 858036 552 0.1
lock-app BRD4161A+wf200 (read/write) 1069144 1069672 528 0.0
.bss 174160 174160 0 0.0
.data 2152 2152 0 0.0
.text 892812 893340 528 0.1
window-app BRD4187C (read/write) 1088800 1089408 608 0.1
.bss 142572 142572 0 0.0
.data 2680 2680 0 0.0
.text 943528 944136 608 0.1
k32w contact k32w0+release (read only) 584748 585308 560 0.1
(read/write) 90108 90108 0 0.0
.bss 66104 66104 0 0.0
.data 2168 2168 0 0.0
.text 584212 584772 560 0.1
light k32w0+release (read only) 583452 583996 544 0.1
(read/write) 89756 89756 0 0.0
.bss 65768 65768 0 0.0
.data 2156 2156 0 0.0
.text 582916 583460 544 0.1
lock k32w0+release (read only) 556044 556604 560 0.1
(read/write) 87556 87556 0 0.0
.bss 63632 63632 0 0.0
.data 2100 2100 0 0.0
.text 555508 556068 560 0.1
linux all-clusters-app debug (read only) 3264453 3266725 2272 0.1
(read/write) 158168 158168 0 0.0
.bss 59456 59456 0 0.0
.data 2160 2160 0 0.0
.data.rel.ro 90040 90040 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 231496 231496 0 0.0
.text 2842037 2844309 2272 0.1
all-clusters-minimal-app debug (read only) 3042277 3044533 2256 0.1
(read/write) 145896 145896 0 0.0
.bss 57984 57984 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 79400 79400 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 224008 224008 0 0.0
.text 2632373 2634629 2256 0.1
bridge-app debug (read only) 2521341 2523613 2272 0.1
(read/write) 129768 129768 0 0.0
.bss 50232 50232 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 69736 69736 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 172680 172680 0 0.0
.text 2175909 2178181 2272 0.1
chip-tool debug (read only) 15574585 15576969 2384 0.0
(read/write) 709696 709696 0 0.0
.bss 26424 26424 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 673424 673424 0 0.0
.dynamic 608 608 0 0.0
.got 5376 5376 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 687573 687573 0 0.0
.text 13240132 13242516 2384 0.0
chip-tool-ipv6only arm64 (read only) 14890436 14892660 2224 0.0
(read/write) 762712 762728 16 0.0
.bss 34408 34408 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 703320 703344 24 0.0
.dynamic 560 560 0 0.0
.got 16728 16728 0 0.0
.init 24 24 0 0.0
.init_array 224 224 0 0.0
.rodata 623672 623672 0 0.0
.text 12462500 12464708 2208 0.0
lighting-app debug+rpc+ui (read only) 3386577 3388833 2256 0.1
(read/write) 136432 136432 0 0.0
.bss 49792 49792 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 77056 77056 0 0.0
.dynamic 656 656 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 286196 286196 0 0.0
.text 2902898 2905154 2256 0.1
lock-app debug (read only) 2613973 2616229 2256 0.1
(read/write) 117200 117200 0 0.0
.bss 45344 45344 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 63896 63896 0 0.0
.dynamic 608 608 0 0.0
.got 4592 4592 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 200104 200104 0 0.0
.text 2249285 2251541 2256 0.1
ota-provider-app debug (read only) 2211085 2213341 2256 0.1
(read/write) 103792 103792 0 0.0
.bss 44528 44528 0 0.0
.data 2112 2112 0 0.0
.data.rel.ro 52056 52056 0 0.0
.dynamic 608 608 0 0.0
.got 3800 3800 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 153800 153800 0 0.0
.text 1915333 1917589 2256 0.1
ota-requestor-app debug (read only) 2379605 2381877 2272 0.1
(read/write) 111552 111552 0 0.0
.bss 46960 46960 0 0.0
.data 2512 2512 0 0.0
.data.rel.ro 56912 56912 0 0.0
.dynamic 608 608 0 0.0
.got 3784 3784 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 157896 157896 0 0.0
.text 2070885 2073157 2272 0.1
shell debug (read only) 2798145 2800417 2272 0.1
(read/write) 146552 146552 0 0.0
.bss 58376 58376 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 81096 81096 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 199634 199634 0 0.0
.text 2431618 2433890 2272 0.1
thermostat-no-ble arm64 (read only) 2607084 2609196 2112 0.1
(read/write) 143032 143048 16 0.0
.bss 52344 52344 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 79336 79360 24 0.0
.dynamic 560 560 0 0.0
.got 5512 5512 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 129608 129608 0 0.0
.text 2211700 2213780 2080 0.1
tv-app debug (read only) 3316145 3318417 2272 0.1
(read/write) 261632 261632 0 0.0
.bss 171232 171232 0 0.0
.data 4080 4080 0 0.0
.data.rel.ro 79584 79584 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 222136 222136 0 0.0
.text 2897394 2899666 2272 0.1
tv-casting-app debug (read only) 9116385 9118641 2256 0.0
(read/write) 219560 219560 0 0.0
.bss 52064 52064 0 0.0
.data 1744 1744 0 0.0
.data.rel.ro 159200 159200 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 992 992 0 0.0
.rodata 329484 329484 0 0.0
.text 8357682 8359938 2256 0.0
qpg lighting-app qpg6105+debug (read/write) 1170564 1171108 544 0.0
.bss 99944 99944 0 0.0
.data 852 852 0 0.0
.text 617660 618204 544 0.1
lock-app qpg6105+debug (read/write) 1139844 1140388 544 0.0
.bss 94824 94824 0 0.0
.data 856 856 0 0.0
.text 586944 587488 544 0.1

cecille
cecille approved these changes Jun 7, 2023
View reviewed changes
src/app/InteractionModelEngine.cpp Show resolved Hide resolved
src/app/InteractionModelEngine.cpp Outdated Show resolved Hide resolved
src/app/reporting/Engine.cpp Outdated Show resolved Hide resolved
src/app/util/endpoint-config-api.h Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jun 7, 2023 •
edited

PR #26761: Size comparison from edef5a8 to 7a90143

Increases (8 builds for bl602, bl702, cc32xx, mbed, qpg)
platform target config section edef5a8 7a90143 change % change
bl602 lighting-app bl602 (read/write) 1367922 1368642 720 0.1
.text 1047896 1048610 714 0.1
bl602+rpc (read/write) 1414910 1415886 976 0.1
.text 1079520 1080492 972 0.1
bl702 lighting-app bl702 (read/write) 1199871 1200591 720 0.1
.debug_abbrev 1552228 1552328 100 0.0
.debug_aranges 149544 149592 48 0.0
.debug_frame 550504 550756 252 0.0
.debug_info 45032248 45036772 4524 0.0
.debug_line 5606655 5608942 2287 0.0
.debug_loc 3834190 3836270 2080 0.1
.debug_ranges 398264 398600 336 0.1
.debug_str 4346152 4346542 390 0.0
.strtab 582046 582654 608 0.1
.symtab 175456 175552 96 0.1
.text 978318 979030 712 0.1
bl702+rpc (read/write) 1289395 1290371 976 0.1
.debug_abbrev 1711296 1711396 100 0.0
.debug_aranges 157832 157880 48 0.0
.debug_frame 578516 578768 252 0.0
.debug_info 49980254 49984779 4525 0.0
.debug_line 6022697 6025009 2312 0.0
.debug_loc 4037291 4039372 2081 0.1
.debug_ranges 423744 424080 336 0.1
.debug_str 4771628 4772018 390 0.0
.strtab 643549 644157 608 0.1
.symtab 194016 194112 96 0.0
.text 1051978 1052946 968 0.1
cc32xx lock CC3235SF_LAUNCHXL (read only) 606178 606794 616 0.1
.debug_abbrev 952074 952163 89 0.0
.debug_aranges 118920 118976 56 0.0
.debug_frame 406188 406408 220 0.1
.debug_info 23111297 23115913 4616 0.0
.debug_line 2880220 2881687 1467 0.1
.debug_loclists 1726561 1727815 1254 0.1
.debug_rnglists 107524 107601 77 0.1
.debug_str 3786697 3787095 398 0.0
.strtab 484563 485171 608 0.1
.symtab 287712 287904 192 0.1
.text 499512 500128 616 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2497920 2498432 512 0.0
.text 1460604 1461116 512 0.0
qpg lighting-app qpg6105+debug (read/write) 1170572 1171100 528 0.0
.text 617668 618196 528 0.1
lock-app qpg6105+debug (read/write) 1139852 1140380 528 0.0
.text 586952 587480 528 0.1
Full report (8 builds for bl602, bl702, cc32xx, mbed, qpg)
platform target config section edef5a8 7a90143 change % change
bl602 lighting-app bl602 (read/write) 1367922 1368642 720 0.1
.bss 87902 87902 0 0.0
.data 9648 9648 0 0.0
.text 1047896 1048610 714 0.1
bl602+rpc (read/write) 1414910 1415886 976 0.1
.bss 95950 95950 0 0.0
.data 10040 10040 0 0.0
.text 1079520 1080492 972 0.1
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1199871 1200591 720 0.1
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67601 67601 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1552228 1552328 100 0.0
.debug_aranges 149544 149592 48 0.0
.debug_frame 550504 550756 252 0.0
.debug_info 45032248 45036772 4524 0.0
.debug_line 5606655 5608942 2287 0.0
.debug_loc 3834190 3836270 2080 0.1
.debug_ranges 398264 398600 336 0.1
.debug_str 4346152 4346542 390 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107264 107264 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 582046 582654 608 0.1
.symtab 175456 175552 96 0.1
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
978318 979030 712 0.1
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1289395 1290371 976 0.1
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75649 75649 0 0.0
.bss_psram 25056 25056 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1711296 1711396 100 0.0
.debug_aranges 157832 157880 48 0.0
.debug_frame 578516 578768 252 0.0
.debug_info 49980254 49984779 4525 0.0
.debug_line 6022697 6025009 2312 0.0
.debug_loc 4037291 4039372 2081 0.1
.debug_ranges 423744 424080 336 0.1
.debug_str 4771628 4772018 390 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121792 121792 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 643549 644157 608 0.1
.symtab 194016 194112 96 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1051978 1052946 968 0.1
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 606178 606794 616 0.1
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 952074 952163 89 0.0
.debug_aranges 118920 118976 56 0.0
.debug_frame 406188 406408 220 0.1
.debug_info 23111297 23115913 4616 0.0
.debug_line 2880220 2881687 1467 0.1
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1726561 1727815 1254 0.1
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 107524 107601 77 0.1
.debug_str 3786697 3787095 398 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104546 104546 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 484563 485171 608 0.1
.symtab 287712 287904 192 0.1
.text 499512 500128 616 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2497920 2498432 512 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1460604 1461116 512 0.0
qpg lighting-app qpg6105+debug (read/write) 1170572 1171100 528 0.0
.bss 99944 99944 0 0.0
.data 852 852 0 0.0
.text 617668 618196 528 0.1
lock-app qpg6105+debug (read/write) 1139852 1140380 528 0.0
.bss 94824 94824 0 0.0
.data 856 856 0 0.0
.text 586952 587480 528 0.1

@bzbarsky-apple bzbarsky-apple force-pushed the use-event-list-for-checks branch 2 times, most recently from e1fd781 to 7394a73 Compare June 7, 2023 21:23
@github-actions
Copy link

github-actions bot commented Jun 7, 2023 •
edited

PR #26761: Size comparison from fd9721d to 7394a73

Increases (56 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
platform target config section fd9721d 7394a73 change % change
bl602 lighting-app bl602 (read/write) 1367922 1368642 720 0.1
.text 1047892 1048612 720 0.1
bl602+rpc (read/write) 1414910 1415886 976 0.1
.text 1079520 1080494 974 0.1
bl702 lighting-app bl702 (read/write) 1199871 1200591 720 0.1
.debug_abbrev 1552228 1552328 100 0.0
.debug_aranges 149544 149592 48 0.0
.debug_frame 550504 550756 252 0.0
.debug_info 45032248 45036773 4525 0.0
.debug_line 5606655 5608942 2287 0.0
.debug_loc 3834190 3836270 2080 0.1
.debug_ranges 398264 398600 336 0.1
.debug_str 4346152 4346541 389 0.0
.strtab 582046 582644 598 0.1
.symtab 175456 175552 96 0.1
.text 978318 979032 714 0.1
bl702+rpc (read/write) 1289395 1290371 976 0.1
.debug_abbrev 1711468 1711568 100 0.0
.debug_aranges 157848 157896 48 0.0
.debug_frame 578584 578836 252 0.0
.debug_info 49981906 49986432 4526 0.0
.debug_line 6023019 6025331 2312 0.0
.debug_loc 4037301 4039382 2081 0.1
.debug_ranges 423760 424096 336 0.1
.debug_str 4772206 4772595 389 0.0
.strtab 643549 644147 598 0.1
.symtab 194016 194112 96 0.0
.text 1051976 1052946 970 0.1
cc32xx lock CC3235SF_LAUNCHXL (read only) 606178 606794 616 0.1
.debug_abbrev 952074 952163 89 0.0
.debug_aranges 118920 118976 56 0.0
.debug_frame 406188 406408 220 0.1
.debug_info 23111295 23115915 4620 0.0
.debug_line 2880220 2881688 1468 0.1
.debug_loclists 1726561 1727815 1254 0.1
.debug_rnglists 107524 107601 77 0.1
.debug_str 3786697 3787094 397 0.0
.strtab 484563 485161 598 0.1
.symtab 287712 287904 192 0.1
.text 499512 500128 616 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 542371 542907 536 0.1
.app_xip_area 434981 435517 536 0.1
lock cyw930739m2evb_01 (read/write) 529251 529795 544 0.1
.app_xip_area 416741 417285 544 0.1
ota-requestor cyw930739m2evb_01 (read/write) 566651 567203 552 0.1
.app_xip_area 460205 460757 552 0.1
switch cyw930739m2evb_01 (read/write) 531035 531571 536 0.1
.app_xip_area 422021 422557 536 0.1
efr32 lighting-app BRD4161A+rs9116 (read/write) 986508 987116 608 0.1
.text 804472 805080 608 0.1
BRD4187C (read/write) 1019896 1020448 552 0.1
.text 857484 858036 552 0.1
lock-app BRD4161A+wf200 (read/write) 1069144 1069672 528 0.0
.text 892812 893340 528 0.1
window-app BRD4187C (read/write) 1088800 1089408 608 0.1
.text 943528 944136 608 0.1
esp32 all-clusters-app c3devkit (read only) 1076326 1076988 662 0.1
.flash.text 1076326 1076988 662 0.1
m5stack (read only) 1122743 1123355 612 0.1
(read/write) 494246 494250 4 0.0
.flash.rodata 244024 244028 4 0.0
.flash.text 1117359 1117971 612 0.1
k32w contact k32w0+release (read only) 584748 585308 560 0.1
.text 584212 584772 560 0.1
light k32w0+release (read only) 583436 583996 560 0.1
.text 582900 583460 560 0.1
lock k32w0+release (read only) 556044 556588 544 0.1
.text 555508 556052 544 0.1
linux all-clusters-app debug (read only) 3264453 3266725 2272 0.1
.text 2842037 2844309 2272 0.1
all-clusters-minimal-app debug (read only) 3042277 3044533 2256 0.1
.text 2632373 2634629 2256 0.1
bridge-app debug (read only) 2521341 2523613 2272 0.1
.text 2175909 2178181 2272 0.1
chip-tool debug (read only) 15580129 15582513 2384 0.0
.text 13245460 13247844 2384 0.0
chip-tool-ipv6only arm64 (read only) 14966504 14968728 2224 0.0
(read/write) 762680 762712 32 0.0
.data.rel.ro 703288 703312 24 0.0
.text 12538676 12540884 2208 0.0
lighting-app debug+rpc+ui (read only) 3386577 3388833 2256 0.1
.text 2902898 2905154 2256 0.1
lock-app debug (read only) 2613973 2616229 2256 0.1
.text 2249285 2251541 2256 0.1
ota-provider-app debug (read only) 2211085 2213341 2256 0.1
.text 1915333 1917589 2256 0.1
ota-requestor-app debug (read only) 2379605 2381877 2272 0.1
.text 2070885 2073157 2272 0.1
shell debug (read only) 2798145 2800417 2272 0.1
.text 2431618 2433890 2272 0.1
thermostat-no-ble arm64 (read only) 2613844 2615940 2096 0.1
(read/write) 142936 142968 32 0.0
.data.rel.ro 79240 79264 24 0.0
.text 2218708 2220788 2080 0.1
tv-app debug (read only) 3316145 3318417 2272 0.1
.text 2897394 2899666 2272 0.1
tv-casting-app debug (read only) 9121873 9124129 2256 0.0
.text 8362978 8365234 2256 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1209936 1210480 544 0.0
text 838752 839304 552 0.1
nrf7002dk_nrf5340_cpuapp (read/write) 1312804 1313332 528 0.0
text 751200 751736 536 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1148292 1148852 560 0.0
text 804748 805300 552 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1728204 1728812 608 0.0
.debug_abbrev 1297175 1297289 114 0.0
.debug_aranges 148632 148688 56 0.0
.debug_frame 497676 497896 220 0.0
.debug_info 32271656 32276275 4619 0.0
.debug_line 4034015 4035620 1605 0.0
.debug_loclists 2300810 2302052 1242 0.1
.debug_rnglists 144093 144170 77 0.1
.debug_str 4350228 4350617 389 0.0
.strtab 750867 751465 598 0.1
.symtab 478784 478976 192 0.0
.text 1528460 1529068 608 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1660668 1661276 608 0.0
.debug_abbrev 1284933 1285047 114 0.0
.debug_aranges 147384 147440 56 0.0
.debug_frame 498620 498840 220 0.0
.debug_info 31733741 31738359 4618 0.0
.debug_line 4039569 4041174 1605 0.0
.debug_loclists 2285640 2286883 1243 0.1
.debug_rnglists 142539 142616 77 0.1
.debug_str 4333158 4333547 389 0.0
.strtab 699748 700346 598 0.1
.symtab 459904 460096 192 0.0
.text 1462252 1462860 608 0.0
light cy8ckit_062s2_43012 (read/write) 1593404 1594012 608 0.0
.debug_abbrev 1122518 1122632 114 0.0
.debug_aranges 137720 137776 56 0.0
.debug_frame 462528 462748 220 0.0
.debug_info 26522581 26527197 4616 0.0
.debug_line 3610555 3612045 1490 0.0
.debug_loclists 2126508 2127751 1243 0.1
.debug_rnglists 132531 132608 77 0.1
.debug_str 4147232 4147629 397 0.0
.strtab 623332 623930 598 0.1
.symtab 425328 425520 192 0.0
.text 1401220 1401828 608 0.0
lock cy8ckit_062s2_43012 (read/write) 1626308 1626916 608 0.0
.debug_abbrev 1104790 1104880 90 0.0
.debug_aranges 136112 136168 56 0.0
.debug_frame 456880 457100 220 0.0
.debug_info 26074669 26079286 4617 0.0
.debug_line 3549938 3551403 1465 0.0
.debug_loclists 2100267 2101510 1243 0.1
.debug_rnglists 130376 130453 77 0.1
.debug_str 4107731 4108128 397 0.0
.strtab 596464 597062 598 0.1
.symtab 416928 417120 192 0.0
.text 1406540 1407148 608 0.0
qpg lighting-app qpg6105+debug (read/write) 1170572 1171108 536 0.0
.text 617668 618204 536 0.1
lock-app qpg6105+debug (read/write) 1139852 1140380 528 0.0
.text 586952 587480 528 0.1
telink all-clusters-app tlsr9518adk80d (read/write) 1033900 1034524 624 0.1
text 707578 708202 624 0.1
all-clusters-minimal-app tlsr9518adk80d (read/write) 961048 961664 616 0.1
text 664834 665456 622 0.1
bridge-app tlsr9518adk80d (read/write) 928768 929392 624 0.1
text 641872 642492 620 0.1
contact-sensor-app tlsr9518adk80d (read/write) 860436 861060 624 0.1
text 585004 585626 622 0.1
light-switch-app tlsr9518adk80d (read/write) 876760 877376 616 0.1
text 599630 600252 622 0.1
lighting-app tlsr9518adk80d (read/write) 965148 965772 624 0.1
text 678694 679314 620 0.1
lighting-app-factory-data tlsr9518adk80d (read/write) 976520 977144 624 0.1
text 686210 686836 626 0.1
lighting-app-rpc tlsr9518adk80d (read/write) 1034248 1034864 616 0.1
text 723378 723998 620 0.1
lighting-app-shell tlsr9518adk80d (read/write) 1065996 1066620 624 0.1
text 743730 744350 620 0.1
lock-app tlsr9518adk80d (read/write) 915508 916132 624 0.1
text 613630 614254 624 0.1
ota-requestor-app tlsr9518adk80d (read/write) 883036 883652 616 0.1
text 606846 607468 622 0.1
pump-app tlsr9518adk80d (read/write) 865996 866620 624 0.1
text 590724 591346 622 0.1
pump-controller-app tlsr9518adk80d (read/write) 853056 853680 624 0.1
text 581110 581730 620 0.1
temperature-measurement-app tlsr9518adk80d (read/write) 849212 849828 616 0.1
text 576738 577360 622 0.1
thermostat tlsr9518adk80d (read/write) 894956 895572 616 0.1
text 615986 616608 622 0.1
window-covering tlsr9518adk80d (read/write) 890336 890952 616 0.1
text 610910 611530 620 0.1
Full report (56 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
platform target config section fd9721d 7394a73 change % change
bl602 lighting-app bl602 (read/write) 1367922 1368642 720 0.1
.bss 87902 87902 0 0.0
.data 9648 9648 0 0.0
.text 1047892 1048612 720 0.1
bl602+rpc (read/write) 1414910 1415886 976 0.1
.bss 95950 95950 0 0.0
.data 10040 10040 0 0.0
.text 1079520 1080494 974 0.1
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1199871 1200591 720 0.1
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67601 67601 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1552228 1552328 100 0.0
.debug_aranges 149544 149592 48 0.0
.debug_frame 550504 550756 252 0.0
.debug_info 45032248 45036773 4525 0.0
.debug_line 5606655 5608942 2287 0.0
.debug_loc 3834190 3836270 2080 0.1
.debug_ranges 398264 398600 336 0.1
.debug_str 4346152 4346541 389 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107264 107264 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 582046 582644 598 0.1
.symtab 175456 175552 96 0.1
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
978318 979032 714 0.1
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1289395 1290371 976 0.1
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75649 75649 0 0.0
.bss_psram 25056 25056 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1711468 1711568 100 0.0
.debug_aranges 157848 157896 48 0.0
.debug_frame 578584 578836 252 0.0
.debug_info 49981906 49986432 4526 0.0
.debug_line 6023019 6025331 2312 0.0
.debug_loc 4037301 4039382 2081 0.1
.debug_ranges 423760 424096 336 0.1
.debug_str 4772206 4772595 389 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121792 121792 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 643549 644147 598 0.1
.symtab 194016 194112 96 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1051976 1052946 970 0.1
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 606178 606794 616 0.1
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 952074 952163 89 0.0
.debug_aranges 118920 118976 56 0.0
.debug_frame 406188 406408 220 0.1
.debug_info 23111295 23115915 4620 0.0
.debug_line 2880220 2881688 1468 0.1
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1726561 1727815 1254 0.1
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 107524 107601 77 0.1
.debug_str 3786697 3787094 397 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104546 104546 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 484563 485161 598 0.1
.symtab 287712 287904 192 0.1
.text 499512 500128 616 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 542371 542907 536 0.1
.app_xip_area 434981 435517 536 0.1
.bss 62368 62368 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 529251 529795 544 0.1
.app_xip_area 416741 417285 544 0.1
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566651 567203 552 0.1
.app_xip_area 460205 460757 552 0.1
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 531035 531571 536 0.1
.app_xip_area 422021 422557 536 0.1
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 986508 987116 608 0.1
.bss 179872 179872 0 0.0
.data 2144 2144 0 0.0
.text 804472 805080 608 0.1
BRD4187C (read/write) 1019896 1020448 552 0.1
.bss 159604 159604 0 0.0
.data 2788 2788 0 0.0
.text 857484 858036 552 0.1
lock-app BRD4161A+wf200 (read/write) 1069144 1069672 528 0.0
.bss 174160 174160 0 0.0
.data 2152 2152 0 0.0
.text 892812 893340 528 0.1
window-app BRD4187C (read/write) 1088800 1089408 608 0.1
.bss 142572 142572 0 0.0
.data 2680 2680 0 0.0
.text 943528 944136 608 0.1
esp32 all-clusters-app c3devkit (read only) 1076326 1076988 662 0.1
(read/write) 1584984 1584984 0 0.0
.dram0.bss 75760 75760 0 0.0
.dram0.data 13964 13964 0 0.0
.flash.rodata 216128 216128 0 0.0
.flash.text 1076326 1076988 662 0.1
.iram0.text 76740 76740 0 0.0
m5stack (read only) 1122743 1123355 612 0.1
(read/write) 494246 494250 4 0.0
.dram0.bss 80768 80768 0 0.0
.dram0.data 34304 34304 0 0.0
.flash.rodata 244024 244028 4 0.0
.flash.text 1117359 1117971 612 0.1
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 584748 585308 560 0.1
(read/write) 90108 90108 0 0.0
.bss 66104 66104 0 0.0
.data 2168 2168 0 0.0
.text 584212 584772 560 0.1
light k32w0+release (read only) 583436 583996 560 0.1
(read/write) 89756 89756 0 0.0
.bss 65768 65768 0 0.0
.data 2156 2156 0 0.0
.text 582900 583460 560 0.1
lock k32w0+release (read only) 556044 556588 544 0.1
(read/write) 87556 87556 0 0.0
.bss 63632 63632 0 0.0
.data 2100 2100 0 0.0
.text 555508 556052 544 0.1
linux all-clusters-app debug (read only) 3264453 3266725 2272 0.1
(read/write) 158168 158168 0 0.0
.bss 59456 59456 0 0.0
.data 2160 2160 0 0.0
.data.rel.ro 90040 90040 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 231496 231496 0 0.0
.text 2842037 2844309 2272 0.1
all-clusters-minimal-app debug (read only) 3042277 3044533 2256 0.1
(read/write) 145896 145896 0 0.0
.bss 57984 57984 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 79400 79400 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 224008 224008 0 0.0
.text 2632373 2634629 2256 0.1
bridge-app debug (read only) 2521341 2523613 2272 0.1
(read/write) 129768 129768 0 0.0
.bss 50232 50232 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 69736 69736 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 172680 172680 0 0.0
.text 2175909 2178181 2272 0.1
chip-tool debug (read only) 15580129 15582513 2384 0.0
(read/write) 709760 709760 0 0.0
.bss 26424 26424 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 673488 673488 0 0.0
.dynamic 608 608 0 0.0
.got 5376 5376 0 0.0
.init 27 27 0 0.0
.init_array 768 768 0 0.0
.rodata 687765 687765 0 0.0
.text 13245460 13247844 2384 0.0
chip-tool-ipv6only arm64 (read only) 14966504 14968728 2224 0.0
(read/write) 762680 762712 32 0.0
.bss 34408 34408 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 703288 703312 24 0.0
.dynamic 560 560 0 0.0
.got 16728 16728 0 0.0
.init 24 24 0 0.0
.init_array 224 224 0 0.0
.rodata 623944 623944 0 0.0
.text 12538676 12540884 2208 0.0
lighting-app debug+rpc+ui (read only) 3386577 3388833 2256 0.1
(read/write) 136432 136432 0 0.0
.bss 49792 49792 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 77056 77056 0 0.0
.dynamic 656 656 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 286196 286196 0 0.0
.text 2902898 2905154 2256 0.1
lock-app debug (read only) 2613973 2616229 2256 0.1
(read/write) 117200 117200 0 0.0
.bss 45344 45344 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 63896 63896 0 0.0
.dynamic 608 608 0 0.0
.got 4592 4592 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 200104 200104 0 0.0
.text 2249285 2251541 2256 0.1
ota-provider-app debug (read only) 2211085 2213341 2256 0.1
(read/write) 103792 103792 0 0.0
.bss 44528 44528 0 0.0
.data 2112 2112 0 0.0
.data.rel.ro 52056 52056 0 0.0
.dynamic 608 608 0 0.0
.got 3800 3800 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 153800 153800 0 0.0
.text 1915333 1917589 2256 0.1
ota-requestor-app debug (read only) 2379605 2381877 2272 0.1
(read/write) 111552 111552 0 0.0
.bss 46960 46960 0 0.0
.data 2512 2512 0 0.0
.data.rel.ro 56912 56912 0 0.0
.dynamic 608 608 0 0.0
.got 3784 3784 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 157896 157896 0 0.0
.text 2070885 2073157 2272 0.1
shell debug (read only) 2798145 2800417 2272 0.1
(read/write) 146552 146552 0 0.0
.bss 58376 58376 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 81096 81096 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 199634 199634 0 0.0
.text 2431618 2433890 2272 0.1
thermostat-no-ble arm64 (read only) 2613844 2615940 2096 0.1
(read/write) 142936 142968 32 0.0
.bss 52344 52344 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 79240 79264 24 0.0
.dynamic 560 560 0 0.0
.got 5512 5512 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 129712 129712 0 0.0
.text 2218708 2220788 2080 0.1
tv-app debug (read only) 3316145 3318417 2272 0.1
(read/write) 261632 261632 0 0.0
.bss 171232 171232 0 0.0
.data 4080 4080 0 0.0
.data.rel.ro 79584 79584 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 222136 222136 0 0.0
.text 2897394 2899666 2272 0.1
tv-casting-app debug (read only) 9121873 9124129 2256 0.0
(read/write) 219560 219560 0 0.0
.bss 52064 52064 0 0.0
.data 1744 1744 0 0.0
.data.rel.ro 159200 159200 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 992 992 0 0.0
.rodata 329676 329676 0 0.0
.text 8362978 8365234 2256 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1209936 1210480 544 0.0
bss 154745 154745 0 0.0
rodata 137380 137380 0 0.0
text 838752 839304 552 0.1
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1312804 1313332 528 0.0
bss 138075 138075 0 0.0
rodata 132816 132816 0 0.0
text 751200 751736 536 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1148292 1148852 560 0.0
bss 153377 153377 0 0.0
rodata 111096 111096 0 0.0
text 804748 805300 552 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841984 841984 0 0.0
(read/write) 1728204 1728812 608 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188796 188796 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1297175 1297289 114 0.0
.debug_aranges 148632 148688 56 0.0
.debug_frame 497676 497896 220 0.0
.debug_info 32271656 32276275 4619 0.0
.debug_line 4034015 4035620 1605 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2300810 2302052 1242 0.1
.debug_rnglists 144093 144170 77 0.1
.debug_str 4350228 4350617 389 0.0
.heap 841984 841984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 750867 751465 598 0.1
.symtab 478784 478976 192 0.0
.text 0 0 0 0.0
1528460 1529068 608 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 843312 843312 0 0.0
(read/write) 1660668 1661276 608 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187468 187468 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1284933 1285047 114 0.0
.debug_aranges 147384 147440 56 0.0
.debug_frame 498620 498840 220 0.0
.debug_info 31733741 31738359 4618 0.0
.debug_line 4039569 4041174 1605 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2285640 2286883 1243 0.1
.debug_rnglists 142539 142616 77 0.1
.debug_str 4333158 4333547 389 0.0
.heap 843312 843312 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 699748 700346 598 0.1
.symtab 459904 460096 192 0.0
.text 1462252 1462860 608 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849544 849544 0 0.0
(read/write) 1593404 1594012 608 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181404 181404 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1122518 1122632 114 0.0
.debug_aranges 137720 137776 56 0.0
.debug_frame 462528 462748 220 0.0
.debug_info 26522581 26527197 4616 0.0
.debug_line 3610555 3612045 1490 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 2126508 2127751 1243 0.1
.debug_rnglists 132531 132608 77 0.1
.debug_str 4147232 4147629 397 0.0
.heap 849544 849544 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 623332 623930 598 0.1
.symtab 425328 425520 192 0.0
.text 1401220 1401828 608 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821960 821960 0 0.0
(read/write) 1626308 1626916 608 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208988 208988 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1104790 1104880 90 0.0
.debug_aranges 136112 136168 56 0.0
.debug_frame 456880 457100 220 0.0
.debug_info 26074669 26079286 4617 0.0
.debug_line 3549938 3551403 1465 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 2100267 2101510 1243 0.1
.debug_rnglists 130376 130453 77 0.1
.debug_str 4107731 4108128 397 0.0
.heap 821960 821960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 596464 597062 598 0.1
.symtab 416928 417120 192 0.0
.text 1406540 1407148 608 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1170572 1171108 536 0.0
.bss 99944 99944 0 0.0
.data 852 852 0 0.0
.text 617668 618204 536 0.1
lock-app qpg6105+debug (read/write) 1139852 1140380 528 0.0
.bss 94824 94824 0 0.0
.data 856 856 0 0.0
.text 586952 587480 528 0.1
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1033900 1034524 624 0.1
bss 97660 97660 0 0.0
text 707578 708202 624 0.1
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 961048 961664 616 0.1
bss 96176 96176 0 0.0
text 664834 665456 622 0.1
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 928768 929392 624 0.1
bss 100308 100308 0 0.0
text 641872 642492 620 0.1
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 860436 861060 624 0.1
bss 89968 89968 0 0.0
text 585004 585626 622 0.1
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876760 877376 616 0.1
bss 90136 90136 0 0.0
text 599630 600252 622 0.1
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 965148 965772 624 0.1
bss 98512 98512 0 0.0
text 678694 679314 620 0.1
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 976520 977144 624 0.1
bss 102760 102760 0 0.0
text 686210 686836 626 0.1
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1034248 1034864 616 0.1
bss 100076 100076 0 0.0
text 723378 723998 620 0.1
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1065996 1066620 624 0.1
bss 111152 111152 0 0.0
text 743730 744350 620 0.1
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 915508 916132 624 0.1
bss 90632 90632 0 0.0
text 613630 614254 624 0.1
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883036 883652 616 0.1
bss 91244 91244 0 0.0
text 606846 607468 622 0.1
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 865996 866620 624 0.1
bss 90100 90100 0 0.0
text 590724 591346 622 0.1
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 853056 853680 624 0.1
bss 89900 89900 0 0.0
text 581110 581730 620 0.1
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 849212 849828 616 0.1
bss 89808 89808 0 0.0
text 576738 577360 622 0.1
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 894956 895572 616 0.1
bss 90344 90344 0 0.0
text 615986 616608 622 0.1
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 890336 890952 616 0.1
bss 90636 90636 0 0.0
text 610910 611530 620 0.1

@cecille cecille mentioned this pull request Jun 8, 2023
Merged
@bzbarsky-apple
Do proper ACL checks on event reads/subscriptions.
bc0fa69 
This adds the following functionality:

1. We now correctly detect subsciptions that don't have any access to anything,
   even if they have an event path in the subscribe request.  For paths with a
   wildcard event id, this check assumes read privileges are needed when event
   lists are disabled, and uses the actual event-specific privileges when event
   lists are enabled.
2. When doing reads of an unsupported event, correctly return an
   errors instead of an empty event list.
3. Fix various unit test mocks to provide the information needed for the new
   checks.
4. Update expectation in existing YAML test that was checking an "unimplemented
   event" case.
@bzbarsky-apple
Address review comments.
cbbb245
@bzbarsky-apple
Fix darwin build.
63819ad
@bzbarsky-apple
Fix Darwin tests, now that we get errors for unsupported events.
7713dfb
@bzbarsky-apple
Move function declarations to a non-codegen-dependent header.
12d3717
@bzbarsky-apple
Handle ACL checks for event wildcards even if we have no EventList.
4aea8df
@github-actions
Copy link

github-actions bot commented Jun 8, 2023 •
edited

PR #26761: Size comparison from 3d481f3 to 9299fd7

Increases (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 3d481f3 9299fd7 change % change
bl602 lighting-app bl602 (read/write) 1367922 1368642 720 0.1
.text 1047896 1048614 718 0.1
bl602+rpc (read/write) 1414918 1415886 968 0.1
.text 1079522 1080494 972 0.1
bl702 lighting-app bl702 (read/write) 1199903 1200623 720 0.1
.debug_abbrev 1552295 1552395 100 0.0
.debug_aranges 149552 149600 48 0.0
.debug_frame 550552 550804 252 0.0
.debug_info 45052593 45057117 4524 0.0
.debug_line 5607613 5609900 2287 0.0
.debug_loc 3834332 3836412 2080 0.1
.debug_ranges 398272 398608 336 0.1
.debug_str 4346348 4346737 389 0.0
.strtab 582173 582771 598 0.1
.symtab 175472 175568 96 0.1
.text 978352 979064 712 0.1
bl702+rpc (read/write) 1289427 1290403 976 0.1
.debug_abbrev 1711535 1711635 100 0.0
.debug_aranges 157856 157904 48 0.0
.debug_frame 578632 578884 252 0.0
.debug_info 50003989 50008514 4525 0.0
.debug_line 6023977 6026289 2312 0.0
.debug_loc 4037499 4039581 2082 0.1
.debug_ranges 423768 424104 336 0.1
.debug_str 4772402 4772791 389 0.0
.strtab 643676 644274 598 0.1
.symtab 194032 194128 96 0.0
.text 1052010 1052978 968 0.1
cc32xx lock CC3235SF_LAUNCHXL (read only) 606178 606794 616 0.1
.debug_abbrev 952074 952163 89 0.0
.debug_aranges 118920 118976 56 0.0
.debug_frame 406188 406408 220 0.1
.debug_info 23111365 23115982 4617 0.0
.debug_line 2880223 2881691 1468 0.1
.debug_loclists 1726586 1727835 1249 0.1
.debug_rnglists 107524 107601 77 0.1
.debug_str 3786762 3787159 397 0.0
.strtab 484580 485178 598 0.1
.symtab 287712 287904 192 0.1
.text 499512 500128 616 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 542259 542795 536 0.1
.app_xip_area 434877 435413 536 0.1
lock cyw930739m2evb_01 (read/write) 529267 529803 536 0.1
.app_xip_area 416757 417293 536 0.1
ota-requestor cyw930739m2evb_01 (read/write) 566659 567211 552 0.1
.app_xip_area 460213 460765 552 0.1
switch cyw930739m2evb_01 (read/write) 531051 531587 536 0.1
.app_xip_area 422037 422573 536 0.1
efr32 lighting-app BRD4161A+rs9116 (read/write) 986508 987116 608 0.1
.text 804472 805080 608 0.1
BRD4187C (read/write) 1019784 1020336 552 0.1
.text 857380 857932 552 0.1
lock-app BRD4161A+wf200 (read/write) 1069144 1069672 528 0.0
.text 892812 893340 528 0.1
window-app BRD4187C (read/write) 1088824 1089440 616 0.1
.text 943552 944168 616 0.1
esp32 all-clusters-app c3devkit (read only) 1074720 1075378 658 0.1
.flash.text 1074720 1075378 658 0.1
m5stack (read only) 1122763 1123375 612 0.1
.flash.text 1117379 1117991 612 0.1
k32w contact k32w0+release (read only) 584796 585340 544 0.1
.text 584260 584804 544 0.1
light k32w0+release (read only) 583484 584028 544 0.1
.text 582948 583492 544 0.1
lock k32w0+release (read only) 556092 556636 544 0.1
.text 555556 556100 544 0.1
linux all-clusters-app debug (read only) 3264501 3266757 2256 0.1
.text 2842085 2844341 2256 0.1
all-clusters-minimal-app debug (read only) 3042309 3044581 2272 0.1
.text 2632405 2634677 2272 0.1
bridge-app debug (read only) 2521389 2523645 2256 0.1
.text 2175957 2178213 2256 0.1
chip-tool debug (read only) 15574529 15576913 2384 0.0
.text 13240404 13242788 2384 0.0
chip-tool-ipv6only arm64 (read only) 14960176 14962416 2240 0.0
(read/write) 762872 762888 16 0.0
.data.rel.ro 703576 703600 24 0.0
.text 1253178 12533988 2208 0.0
lighting-app debug+rpc+ui (read only) 3386449 3388721 2272 0.1
.text 2902930 2905202 2272 0.1
lock-app debug (read only) 2614005 2616277 2272 0.1
.text 2249317 2251589 2272 0.1
ota-provider-app debug (read only) 2211117 2213389 2272 0.1
.text 1915365 1917637 2272 0.1
ota-requestor-app debug (read only) 2379653 2381909 2256 0.1
.text 2070933 2073189 2256 0.1
shell debug (read only) 2798193 2800449 2256 0.1
.text 2431666 2433922 2256 0.1
thermostat-no-ble arm64 (read only) 2613892 2615988 2096 0.1
(read/write) 142936 142968 32 0.0
.data.rel.ro 79240 79264 24 0.0
.text 2218756 2220836 2080 0.1
tv-app debug (read only) 3316225 3318481 2256 0.1
.text 2897474 2899730 2256 0.1
tv-casting-app debug (read only) 9121905 9124177 2272 0.0
.text 8363010 8365282 2272 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2497920 2498432 512 0.0
.text 1460604 1461116 512 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1209952 1210496 544 0.0
text 838768 839320 552 0.1
nrf7002dk_nrf5340_cpuapp (read/write) 1312804 1313332 528 0.0
text 751200 751732 532 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1148308 1148868 560 0.0
text 804760 805316 556 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1728204 1728812 608 0.0
.debug_abbrev 1297175 1297289 114 0.0
.debug_aranges 148632 148688 56 0.0
.debug_frame 497676 497896 220 0.0
.debug_info 32271724 32276343 4619 0.0
.debug_line 4034018 4035623 1605 0.0
.debug_loclists 2300833 2302076 1243 0.1
.debug_rnglists 144093 144170 77 0.1
.debug_str 4350293 4350682 389 0.0
.strtab 750884 751482 598 0.1
.symtab 478784 478976 192 0.0
.text 1528460 1529068 608 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1660668 1661276 608 0.0
.debug_abbrev 1284933 1285047 114 0.0
.debug_aranges 147384 147440 56 0.0
.debug_frame 498620 498840 220 0.0
.debug_info 31733809 31738429 4620 0.0
.debug_line 4039572 4041177 1605 0.0
.debug_loclists 2285664 2286907 1243 0.1
.debug_rnglists 142539 142616 77 0.1
.debug_str 4333223 4333612 389 0.0
.strtab 699765 700363 598 0.1
.symtab 459904 460096 192 0.0
.text 1462252 1462860 608 0.0
light cy8ckit_062s2_43012 (read/write) 1593268 1593876 608 0.0
.debug_abbrev 1122518 1122632 114 0.0
.debug_aranges 137720 137776 56 0.0
.debug_frame 462528 462748 220 0.0
.debug_info 26522601 26527219 4618 0.0
.debug_line 3610558 3612048 1490 0.0
.debug_loclists 2126532 2127775 1243 0.1
.debug_rnglists 132531 132608 77 0.1
.debug_str 4147297 4147694 397 0.0
.strtab 623349 623947 598 0.1
.symtab 425328 425520 192 0.0
.text 1401100 1401708 608 0.0
lock cy8ckit_062s2_43012 (read/write) 1626308 1626916 608 0.0
.debug_abbrev 1104790 1104880 90 0.0
.debug_aranges 136112 136168 56 0.0
.debug_frame 456880 457100 220 0.0
.debug_info 26074737 26079353 4616 0.0
.debug_line 3549941 3551406 1465 0.0
.debug_loclists 2100291 2101534 1243 0.1
.debug_rnglists 130376 130453 77 0.1
.debug_str 4107796 4108193 397 0.0
.strtab 596481 597079 598 0.1
.symtab 416928 417120 192 0.0
.text 1406540 1407148 608 0.0
qpg lighting-app qpg6105+debug (read/write) 1171016 1171552 536 0.0
.text 617856 618392 536 0.1
lock-app qpg6105+debug (read/write) 1140368 1140904 536 0.0
.text 587212 587748 536 0.1
telink all-clusters-app tlsr9518adk80d (read/write) 1033916 1034540 624 0.1
text 707596 708218 622 0.1
all-clusters-minimal-app tlsr9518adk80d (read/write) 961064 961688 624 0.1
text 664852 665474 622 0.1
bridge-app tlsr9518adk80d (read/write) 928784 929408 624 0.1
text 641888 642512 624 0.1
contact-sensor-app tlsr9518adk80d (read/write) 860452 861076 624 0.1
text 585020 585646 626 0.1
light-switch-app tlsr9518adk80d (read/write) 876776 877392 616 0.1
text 599648 600268 620 0.1
lighting-app tlsr9518adk80d (read/write) 965032 965656 624 0.1
text 678708 679332 624 0.1
lighting-app-factory-data tlsr9518adk80d (read/write) 976412 977028 616 0.1
text 686230 686850 620 0.1
lighting-app-rpc tlsr9518adk80d (read/write) 1034132 1034748 616 0.1
text 723394 724016 622 0.1
lighting-app-shell tlsr9518adk80d (read/write) 1065888 1066504 616 0.1
text 743750 744370 620 0.1
lock-app tlsr9518adk80d (read/write) 915524 916148 624 0.1
text 613650 614270 620 0.1
ota-requestor-app tlsr9518adk80d (read/write) 883052 883676 624 0.1
text 606866 607488 622 0.1
pump-app tlsr9518adk80d (read/write) 866012 866636 624 0.1
text 590740 591364 624 0.1
pump-controller-app tlsr9518adk80d (read/write) 853072 853696 624 0.1
text 581126 581750 624 0.1
temperature-measurement-app tlsr9518adk80d (read/write) 849228 849852 624 0.1
text 576754 577378 624 0.1
thermostat tlsr9518adk80d (read/write) 894972 895596 624 0.1
text 616004 616626 622 0.1
window-covering tlsr9518adk80d (read/write) 890352 890968 616 0.1
text 610926 611548 622 0.1
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 3d481f3 9299fd7 change % change
bl602 lighting-app bl602 (read/write) 1367922 1368642 720 0.1
.bss 87902 87902 0 0.0
.data 9648 9648 0 0.0
.text 1047896 1048614 718 0.1
bl602+rpc (read/write) 1414918 1415886 968 0.1
.bss 95950 95950 0 0.0
.data 10040 10040 0 0.0
.text 1079522 1080494 972 0.1
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1199903 1200623 720 0.1
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 67601 67601 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3952 3952 0 0.0
.debug_abbrev 1552295 1552395 100 0.0
.debug_aranges 149552 149600 48 0.0
.debug_frame 550552 550804 252 0.0
.debug_info 45052593 45057117 4524 0.0
.debug_line 5607613 5609900 2287 0.0
.debug_loc 3834332 3836412 2080 0.1
.debug_ranges 398272 398608 336 0.1
.debug_str 4346348 4346737 389 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107264 107264 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 582173 582771 598 0.1
.symtab 175472 175568 96 0.1
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
978352 979064 712 0.1
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1289427 1290403 976 0.1
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 75649 75649 0 0.0
.bss_psram 25056 25056 0 0.0
.comment 48 48 0 0.0
.data 4504 4504 0 0.0
.debug_abbrev 1711535 1711635 100 0.0
.debug_aranges 157856 157904 48 0.0
.debug_frame 578632 578884 252 0.0
.debug_info 50003989 50008514 4525 0.0
.debug_line 6023977 6026289 2312 0.0
.debug_loc 4037499 4039581 2082 0.1
.debug_ranges 423768 424104 336 0.1
.debug_str 4772402 4772791 389 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121792 121792 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 643676 644274 598 0.1
.symtab 194032 194128 96 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1052010 1052978 968 0.1
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 606178 606794 616 0.1
(read/write) 204164 204164 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197576 197576 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 952074 952163 89 0.0
.debug_aranges 118920 118976 56 0.0
.debug_frame 406188 406408 220 0.1
.debug_info 23111365 23115982 4617 0.0
.debug_line 2880223 2881691 1468 0.1
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1726586 1727835 1249 0.1
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 107524 107601 77 0.1
.debug_str 3786762 3787159 397 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104546 104546 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 484580 485178 598 0.1
.symtab 287712 287904 192 0.1
.text 499512 500128 616 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 542259 542795 536 0.1
.app_xip_area 434877 435413 536 0.1
.bss 62360 62360 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 529267 529803 536 0.1
.app_xip_area 416757 417293 536 0.1
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 566659 567211 552 0.1
.app_xip_area 460213 460765 552 0.1
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 531051 531587 536 0.1
.app_xip_area 422037 422573 536 0.1
.bss 63960 63960 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 986508 987116 608 0.1
.bss 179872 179872 0 0.0
.data 2144 2144 0 0.0
.text 804472 805080 608 0.1
BRD4187C (read/write) 1019784 1020336 552 0.1
.bss 159596 159596 0 0.0
.data 2788 2788 0 0.0
.text 857380 857932 552 0.1
lock-app BRD4161A+wf200 (read/write) 1069144 1069672 528 0.0
.bss 174160 174160 0 0.0
.data 2152 2152 0 0.0
.text 892812 893340 528 0.1
window-app BRD4187C (read/write) 1088824 1089440 616 0.1
.bss 142572 142572 0 0.0
.data 2680 2680 0 0.0
.text 943552 944168 616 0.1
esp32 all-clusters-app c3devkit (read only) 1074720 1075378 658 0.1
(read/write) 1583792 1583792 0 0.0
.dram0.bss 75280 75280 0 0.0
.dram0.data 13940 13940 0 0.0
.flash.rodata 215432 215432 0 0.0
.flash.text 1074720 1075378 658 0.1
.iram0.text 76740 76740 0 0.0
m5stack (read only) 1122763 1123375 612 0.1
(read/write) 494246 494246 0 0.0
.dram0.bss 80768 80768 0 0.0
.dram0.data 34304 34304 0 0.0
.flash.rodata 244024 244024 0 0.0
.flash.text 1117379 1117991 612 0.1
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 584796 585340 544 0.1
(read/write) 90108 90108 0 0.0
.bss 66104 66104 0 0.0
.data 2168 2168 0 0.0
.text 584260 584804 544 0.1
light k32w0+release (read only) 583484 584028 544 0.1
(read/write) 89756 89756 0 0.0
.bss 65768 65768 0 0.0
.data 2156 2156 0 0.0
.text 582948 583492 544 0.1
lock k32w0+release (read only) 556092 556636 544 0.1
(read/write) 87556 87556 0 0.0
.bss 63632 63632 0 0.0
.data 2100 2100 0 0.0
.text 555556 556100 544 0.1
linux all-clusters-app debug (read only) 3264501 3266757 2256 0.1
(read/write) 158168 158168 0 0.0
.bss 59456 59456 0 0.0
.data 2160 2160 0 0.0
.data.rel.ro 90040 90040 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 231496 231496 0 0.0
.text 2842085 2844341 2256 0.1
all-clusters-minimal-app debug (read only) 3042309 3044581 2272 0.1
(read/write) 145896 145896 0 0.0
.bss 57984 57984 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 79400 79400 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 224008 224008 0 0.0
.text 2632405 2634677 2272 0.1
bridge-app debug (read only) 2521389 2523645 2256 0.1
(read/write) 129768 129768 0 0.0
.bss 50232 50232 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 69736 69736 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 172680 172680 0 0.0
.text 2175957 2178213 2256 0.1
chip-tool debug (read only) 15574529 15576913 2384 0.0
(read/write) 709944 709944 0 0.0
.bss 26296 26296 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 673808 673808 0 0.0
.dynamic 608 608 0 0.0
.got 5376 5376 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 686453 686453 0 0.0
.text 13240404 13242788 2384 0.0
chip-tool-ipv6only arm64 (read only) 14960176 14962416 2240 0.0
(read/write) 762872 762888 16 0.0
.bss 34312 34312 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 703576 703600 24 0.0
.dynamic 560 560 0 0.0
.got 16720 16720 0 0.0
.init 24 24 0 0.0
.init_array 224 224 0 0.0
.rodata 623776 623776 0 0.0
.text 1253178 12533988 2208 0.0
lighting-app debug+rpc+ui (read only) 3386449 3388721 2272 0.1
(read/write) 136304 136304 0 0.0
.bss 49760 49760 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 76960 76960 0 0.0
.dynamic 656 656 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 286132 286132 0 0.0
.text 2902930 2905202 2272 0.1
lock-app debug (read only) 2614005 2616277 2272 0.1
(read/write) 117200 117200 0 0.0
.bss 45344 45344 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 63896 63896 0 0.0
.dynamic 608 608 0 0.0
.got 4592 4592 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 200104 200104 0 0.0
.text 2249317 2251589 2272 0.1
ota-provider-app debug (read only) 2211117 2213389 2272 0.1
(read/write) 103792 103792 0 0.0
.bss 44528 44528 0 0.0
.data 2112 2112 0 0.0
.data.rel.ro 52056 52056 0 0.0
.dynamic 608 608 0 0.0
.got 3800 3800 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 153800 153800 0 0.0
.text 1915365 1917637 2272 0.1
ota-requestor-app debug (read only) 2379653 2381909 2256 0.1
(read/write) 111552 111552 0 0.0
.bss 46960 46960 0 0.0
.data 2512 2512 0 0.0
.data.rel.ro 56912 56912 0 0.0
.dynamic 608 608 0 0.0
.got 3784 3784 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 157896 157896 0 0.0
.text 2070933 2073189 2256 0.1
shell debug (read only) 2798193 2800449 2256 0.1
(read/write) 146552 146552 0 0.0
.bss 58376 58376 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 81096 81096 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 199634 199634 0 0.0
.text 2431666 2433922 2256 0.1
thermostat-no-ble arm64 (read only) 2613892 2615988 2096 0.1
(read/write) 142936 142968 32 0.0
.bss 52344 52344 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 79240 79264 24 0.0
.dynamic 560 560 0 0.0
.got 5512 5512 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 129712 129712 0 0.0
.text 2218756 2220836 2080 0.1
tv-app debug (read only) 3316225 3318481 2256 0.1
(read/write) 261632 261632 0 0.0
.bss 171232 171232 0 0.0
.data 4080 4080 0 0.0
.data.rel.ro 79584 79584 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 222136 222136 0 0.0
.text 2897474 2899730 2256 0.1
tv-casting-app debug (read only) 9121905 9124177 2272 0.0
(read/write) 219560 219560 0 0.0
.bss 52064 52064 0 0.0
.data 1744 1744 0 0.0
.data.rel.ro 159200 159200 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 992 992 0 0.0
.rodata 329676 329676 0 0.0
.text 8363010 8365282 2272 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2497920 2498432 512 0.0
.bss 216304 216304 0 0.0
.data 5144 5144 0 0.0
.text 1460604 1461116 512 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1209952 1210496 544 0.0
bss 154745 154745 0 0.0
rodata 137380 137380 0 0.0
text 838768 839320 552 0.1
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1312804 1313332 528 0.0
bss 138075 138075 0 0.0
rodata 132816 132816 0 0.0
text 751200 751732 532 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1148308 1148868 560 0.0
bss 153377 153377 0 0.0
rodata 111096 111096 0 0.0
text 804760 805316 556 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841984 841984 0 0.0
(read/write) 1728204 1728812 608 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188796 188796 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1297175 1297289 114 0.0
.debug_aranges 148632 148688 56 0.0
.debug_frame 497676 497896 220 0.0
.debug_info 32271724 32276343 4619 0.0
.debug_line 4034018 4035623 1605 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2300833 2302076 1243 0.1
.debug_rnglists 144093 144170 77 0.1
.debug_str 4350293 4350682 389 0.0
.heap 841984 841984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 750884 751482 598 0.1
.symtab 478784 478976 192 0.0
.text 0 0 0 0.0
1528460 1529068 608 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 843312 843312 0 0.0
(read/write) 1660668 1661276 608 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187468 187468 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1284933 1285047 114 0.0
.debug_aranges 147384 147440 56 0.0
.debug_frame 498620 498840 220 0.0
.debug_info 31733809 31738429 4620 0.0
.debug_line 4039572 4041177 1605 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2285664 2286907 1243 0.1
.debug_rnglists 142539 142616 77 0.1
.debug_str 4333223 4333612 389 0.0
.heap 843312 843312 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 699765 700363 598 0.1
.symtab 459904 460096 192 0.0
.text 1462252 1462860 608 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849560 849560 0 0.0
(read/write) 1593268 1593876 608 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181388 181388 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1122518 1122632 114 0.0
.debug_aranges 137720 137776 56 0.0
.debug_frame 462528 462748 220 0.0
.debug_info 26522601 26527219 4618 0.0
.debug_line 3610558 3612048 1490 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 2126532 2127775 1243 0.1
.debug_rnglists 132531 132608 77 0.1
.debug_str 4147297 4147694 397 0.0
.heap 849560 849560 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 623349 623947 598 0.1
.symtab 425328 425520 192 0.0
.text 1401100 1401708 608 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821960 821960 0 0.0
(read/write) 1626308 1626916 608 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208988 208988 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1104790 1104880 90 0.0
.debug_aranges 136112 136168 56 0.0
.debug_frame 456880 457100 220 0.0
.debug_info 26074737 26079353 4616 0.0
.debug_line 3549941 3551406 1465 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 2100291 2101534 1243 0.1
.debug_rnglists 130376 130453 77 0.1
.debug_str 4107796 4108193 397 0.0
.heap 821960 821960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 596481 597079 598 0.1
.symtab 416928 417120 192 0.0
.text 1406540 1407148 608 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1171016 1171552 536 0.0
.bss 99952 99952 0 0.0
.data 788 788 0 0.0
.text 617856 618392 536 0.1
lock-app qpg6105+debug (read/write) 1140368 1140904 536 0.0
.bss 94832 94832 0 0.0
.data 792 792 0 0.0
.text 587212 587748 536 0.1
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1033916 1034540 624 0.1
bss 97660 97660 0 0.0
text 707596 708218 622 0.1
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 961064 961688 624 0.1
bss 96176 96176 0 0.0
text 664852 665474 622 0.1
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 928784 929408 624 0.1
bss 100308 100308 0 0.0
text 641888 642512 624 0.1
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 860452 861076 624 0.1
bss 89968 89968 0 0.0
text 585020 585646 626 0.1
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 876776 877392 616 0.1
bss 90136 90136 0 0.0
text 599648 600268 620 0.1
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 965032 965656 624 0.1
bss 98500 98500 0 0.0
text 678708 679332 624 0.1
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 976412 977028 616 0.1
bss 102748 102748 0 0.0
text 686230 686850 620 0.1
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1034132 1034748 616 0.1
bss 100064 100064 0 0.0
text 723394 724016 622 0.1
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1065888 1066504 616 0.1
bss 111140 111140 0 0.0
text 743750 744370 620 0.1
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 915524 916148 624 0.1
bss 90632 90632 0 0.0
text 613650 614270 620 0.1
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883052 883676 624 0.1
bss 91244 91244 0 0.0
text 606866 607488 622 0.1
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 866012 866636 624 0.1
bss 90100 90100 0 0.0
text 590740 591364 624 0.1
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 853072 853696 624 0.1
bss 89900 89900 0 0.0
text 581126 581750 624 0.1
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 849228 849852 624 0.1
bss 89808 89808 0 0.0
text 576754 577378 624 0.1
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 894972 895596 624 0.1
bss 90344 90344 0 0.0
text 616004 616626 622 0.1
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 890352 890968 616 0.1
bss 90636 90636 0 0.0
text 610926 611548 622 0.1

@bzbarsky-apple bzbarsky-apple merged commit 8d2516a into project-chip:master Jun 14, 2023
52 checks passed
@bzbarsky-apple bzbarsky-apple deleted the use-event-list-for-checks branch June 14, 2023 16:15
@bzbarsky-apple bzbarsky-apple mentioned this pull request Jun 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 left review comments

@cecille cecille cecille approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

Assignees
No one assigned
Labels
app controller darwin review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of extern data model function declarations in InteractionModelEngine.cpp
4 participants
@bzbarsky-apple @andy31415 @cecille @jmartinez-silabs