MinMds - remove duplicate broadcasts at startup time (remove IP address looping) #27268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinMDNS advertises once for every IP address, but this makes no sense as a multicast is per interface not per external IP. Ensure we only broadcast once per interface.
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock and
kkasperczyk-no
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #27268: Size comparison from 5efdd31 to ea51150 Increases (21 builds for cc32xx, cyw30739, esp32, linux, nrfconnect, telink)
Decreases (34 builds for bl602, bl702, cc32xx, efr32, esp32, linux, mbed, nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
changed the title
bzbarsky-apple
approved these changes
Jun 15, 2023
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
…ot require string parsing
tcarmelveilleux
approved these changes
Jun 16, 2023
|
can we cherry pick this PR on v1.1-branch ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MinMDNS advertises once for every IP address, but this makes no sense as a multicast is per interface not per external IP.
Ensure we only broadcast once per interface.
This pulls the "only advertise once per IP address" from #27219 as that is an obvious useful improvement (that PR is a larger change and requires more testing ... however advertisement reduction seems to be generally applicable immediately).