Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix decoding of TLV payload data #27839

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Fix decoding of TLV payload data #27839

merged 2 commits into from
Jul 11, 2023

Conversation

hare-siterwell
Copy link
Contributor

Fixes #27832
Fixes #27833

@hare-siterwell
Fix decoding of TLV payload data
7b99e5f 
Ignore empty field events.
@github-actions
Copy link

github-actions bot commented Jul 10, 2023 •
edited

PR #27839: Size comparison from 08af5fa to dda77a6

Increases (12 builds for bl602, cc32xx, cyw30739, psoc6, qpg, telink)
platform target config section 08af5fa dda77a6 change % change
bl602 lighting-app bl602+rpc .text 1083678 1083680 2 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20024771 20024773 2 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 530567 530575 8 0.0
.app_xip_area 418049 418057 8 0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22910053 22910055 2 0.0
qpg lighting-app qpg6105+debug (read/write) 1172496 1172504 8 0.0
.text 619336 619344 8 0.0
telink all-clusters-app tlsr9518adk80d text 721634 721636 2 0.0
light-switch-app tlsr9518adk80d text 611866 611870 4 0.0
lock-app tlsr9518adk80d text 615072 615074 2 0.0
pump-app tlsr9518adk80d text 592164 592166 2 0.0
temperature-measurement-app tlsr9518adk80d text 578138 578140 2 0.0
thermostat tlsr9518adk80d (read/write) 896940 896948 8 0.0
text 617552 617554 2 0.0
window-covering tlsr9518adk80d text 612474 612476 2 0.0
Decreases (13 builds for bl702, cyw30739, efr32, linux, psoc6, telink)
platform target config section 08af5fa dda77a6 change % change
bl702 lighting-app bl702 .debug_info 41915113 4191511 -1 -0.0
.text 945848 945846 -2 -0.0
bl702+rpc (read/write) 1277355 1277351 -4 -0.0
.debug_info 47104186 47104184 -2 -0.0
.text 1020238 1020234 -4 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 545519 545511 -8 -0.0
.app_xip_area 437977 437969 -8 -0.0
efr32 lighting-app BRD4187C (read/write) 1030016 1030008 -8 -0.0
.text 864828 864820 -8 -0.0
linux chip-tool debug (read only) 18400537 18398393 -2144 -0.0
(read/write) 1052912 1051280 -1632 -0.2
.data.rel.ro 946864 945232 -1632 -0.2
.rodata 810049 809537 -512 -0.1
chip-tool-ipv6only arm64 (read only) 17698432 17696800 -1632 -0.0
(read/write) 1120472 1118840 -1632 -0.1
.data.rel.ro 984080 982448 -1632 -0.2
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 29725828 29725827 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 28442664 28442663 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 23212182 23212180 -2 -0.0
telink bridge-app tlsr9518adk80d (read/write) 930560 930552 -8 -0.0
text 643234 643232 -2 -0.0
contact-sensor-app tlsr9518adk80d text 586406 586402 -4 -0.0
lighting-app tlsr9518adk80d text 682148 682146 -2 -0.0
pump-controller-app tlsr9518adk80d text 582510 582508 -2 -0.0
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 08af5fa dda77a6 change % change
bl602 lighting-app bl602 (read/write) 1367730 1367730 0 0.0
.bss 83942 83942 0 0.0
.data 9624 9624 0 0.0
.text 1051798 1051798 0 0.0
bl602+rpc (read/write) 1415158 1415158 0 0.0
.bss 91990 91990 0 0.0
.data 10024 10024 0 0.0
.text 1083678 1083680 2 0.0
bl702 lighting-app bl702 (read/write) 1178719 1178719 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 77773 77773 0 0.0
.bss_psram 24656 24656 0 0.0
.comment 48 48 0 0.0
.data 3592 3592 0 0.0
.debug_abbrev 1552038 1552038 0 0.0
.debug_aranges 151272 151272 0 0.0
.debug_frame 556396 556396 0 0.0
.debug_info 41915113 4191511 -1 -0.0
.debug_line 5612011 5612011 0 0.0
.debug_loc 3821430 3821430 0 0.0
.debug_ranges 397320 397320 0 0.0
.debug_str 4381484 4381484 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 140 140 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 105704 105704 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 582236 582236 0 0.0
.symtab 174176 174176 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3394 3394 0 0.0
.text 0 0 0 0.0
945848 945846 -2 -0.0
bl702+rpc (read/write) 1277355 1277351 -4 -0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 85821 85821 0 0.0
.bss_psram 25072 25072 0 0.0
.comment 48 48 0 0.0
.data 4144 4144 0 0.0
.debug_abbrev 1717649 1717649 0 0.0
.debug_aranges 159760 159760 0 0.0
.debug_frame 585080 585080 0 0.0
.debug_info 47104186 47104184 -2 -0.0
.debug_line 6038681 6038681 0 0.0
.debug_loc 4026977 4026977 0 0.0
.debug_ranges 423008 423008 0 0.0
.debug_str 4809842 4809842 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 120356 120356 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 645177 645177 0 0.0
.symtab 193088 193088 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3394 3394 0 0.0
.text 0 0 0 0.0
1020238 1020234 -4 -0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1159100 1159100 0 0.0
.boot2 292 292 0 0.0
.bss 40776 40776 0 0.0
.bss_psram 69168 69168 0 0.0
.comment 48 48 0 0.0
.data 4560 4560 0 0.0
.debug_abbrev 1552941 1552941 0 0.0
.debug_aranges 145416 145416 0 0.0
.debug_frame 535028 535028 0 0.0
.debug_info 41908462 41908462 0 0.0
.debug_line 5517909 5517909 0 0.0
.debug_loc 3754098 3754098 0 0.0
.debug_ranges 402216 402216 0 0.0
.debug_str 4392178 4392178 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 140 140 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 99652 99652 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 582143 582143 0 0.0
.symtab 173504 173504 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
934406 934406 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 608298 608298 0 0.0
(read/write) 204172 204172 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197584 197584 0 0.0
.comment 206 206 0 0.0
.data 1468 1468 0 0.0
.debug_abbrev 948504 948504 0 0.0
.debug_aranges 119824 119824 0 0.0
.debug_frame 409320 409320 0 0.0
.debug_info 20024771 20024773 2 0.0
.debug_line 2885658 2885658 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1740724 1740724 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 108217 108217 0 0.0
.debug_str 3824719 3824719 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104914 104914 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 485459 485459 0 0.0
.symtab 288368 288368 0 0.0
.text 501260 501260 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 545519 545511 -8 -0.0
.app_xip_area 437977 437969 -8 -0.0
.bss 62512 62512 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 530567 530575 8 0.0
.app_xip_area 418049 418057 8 0.0
.bss 67480 67480 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 568615 568615 0 0.0
.app_xip_area 462161 462161 0 0.0
.bss 61472 61472 0 0.0
.data 668 668 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 541767 541767 0 0.0
.app_xip_area 432361 432361 0 0.0
.bss 64344 64344 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1004956 1004956 0 0.0
.bss 182252 182252 0 0.0
.data 2700 2700 0 0.0
.text 819984 819984 0 0.0
BRD4187C (read/write) 1030016 1030008 -8 -0.0
.bss 161860 161860 0 0.0
.data 3308 3308 0 0.0
.text 864828 864820 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1080712 1080712 0 0.0
.bss 176252 176252 0 0.0
.data 2696 2696 0 0.0
.text 901744 901744 0 0.0
window-app BRD4187C (read/write) 1100456 1100456 0 0.0
.bss 144868 144868 0 0.0
.data 3204 3204 0 0.0
.text 952364 952364 0 0.0
esp32 all-clusters-app c3devkit (read only) 1089212 1089212 0 0.0
(read/write) 1586768 1586768 0 0.0
.dram0.bss 75944 75944 0 0.0
.dram0.data 13940 13940 0 0.0
.flash.rodata 217736 217736 0 0.0
.flash.text 1089212 1089212 0 0.0
.iram0.text 76740 76740 0 0.0
m5stack (read only) 1135823 1135823 0 0.0
(read/write) 497174 497174 0 0.0
.dram0.bss 81424 81424 0 0.0
.dram0.data 34304 34304 0 0.0
.flash.rodata 246296 246296 0 0.0
.flash.text 1130439 1130439 0 0.0
.iram0.text 126055 126055 0 0.0
k32w contact k32w0+release (read only) 586652 586652 0 0.0
(read/write) 90112 90112 0 0.0
.bss 66108 66108 0 0.0
.data 2168 2168 0 0.0
.text 586116 586116 0 0.0
light k32w0+release (read only) 585356 585356 0 0.0
(read/write) 89760 89760 0 0.0
.bss 65772 65772 0 0.0
.data 2156 2156 0 0.0
.text 584820 584820 0 0.0
lock k32w0+release (read only) 557948 557948 0 0.0
(read/write) 87560 87560 0 0.0
.bss 63636 63636 0 0.0
.data 2100 2100 0 0.0
.text 557412 557412 0 0.0
linux all-clusters-app debug (read only) 3345333 3345333 0 0.0
(read/write) 160936 160936 0 0.0
.bss 60320 60320 0 0.0
.data 2160 2160 0 0.0
.data.rel.ro 91944 91944 0 0.0
.dynamic 608 608 0 0.0
.got 4728 4728 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 233448 233448 0 0.0
.text 2919045 2919045 0 0.0
all-clusters-minimal-app debug (read only) 3058685 3058685 0 0.0
(read/write) 146696 146696 0 0.0
.bss 58208 58208 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 79960 79960 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 1088 1088 0 0.0
.rodata 224552 224552 0 0.0
.text 2647253 2647253 0 0.0
bridge-app debug (read only) 2527213 2527213 0 0.0
(read/write) 129992 129992 0 0.0
.bss 50328 50328 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 69864 69864 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 173064 173064 0 0.0
.text 2181013 2181013 0 0.0
chip-tool debug (read only) 18400537 18398393 -2144 -0.0
(read/write) 1052912 1051280 -1632 -0.2
.bss 93560 93560 0 0.0
.data 5154 5154 0 0.0
.data.rel.ro 946864 945232 -1632 -0.2
.dynamic 624 624 0 0.0
.got 5888 5888 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 810049 809537 -512 -0.1
.text 15615843 15615843 0 0.0
chip-tool-ipv6only arm64 (read only) 17698432 17696800 -1632 -0.0
(read/write) 1120472 1118840 -1632 -0.1
.bss 102952 102952 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 984080 982448 -1632 -0.2
.dynamic 560 560 0 0.0
.got 23488 23488 0 0.0
.init 24 24 0 0.0
.init_array 240 240 0 0.0
.rodata 718592 718592 0 0.0
.text 14820612 14820612 0 0.0
lighting-app debug+rpc+ui (read only) 5211641 5211641 0 0.0
(read/write) 220728 220728 0 0.0
.bss 117264 117264 0 0.0
.data 4880 4880 0 0.0
.data.rel.ro 91048 91048 0 0.0
.dynamic 672 672 0 0.0
.got 5912 5912 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 329332 329332 0 0.0
.text 4642531 4642531 0 0.0
lock-app debug (read only) 2619909 2619909 0 0.0
(read/write) 117376 117376 0 0.0
.bss 45392 45392 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 64024 64024 0 0.0
.dynamic 608 608 0 0.0
.got 4592 4592 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 200552 200552 0 0.0
.text 2254389 2254389 0 0.0
ota-provider-app debug (read only) 2216237 2216237 0 0.0
(read/write) 103952 103952 0 0.0
.bss 44560 44560 0 0.0
.data 2112 2112 0 0.0
.data.rel.ro 52184 52184 0 0.0
.dynamic 608 608 0 0.0
.got 3800 3800 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 154184 154184 0 0.0
.text 1919717 1919717 0 0.0
ota-requestor-app debug (read only) 2385189 2385189 0 0.0
(read/write) 111744 111744 0 0.0
.bss 47024 47024 0 0.0
.data 2512 2512 0 0.0
.data.rel.ro 57040 57040 0 0.0
.dynamic 608 608 0 0.0
.got 3784 3784 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 158248 158248 0 0.0
.text 2075733 2075733 0 0.0
shell debug (read only) 2881441 2881441 0 0.0
(read/write) 149352 149352 0 0.0
.bss 59272 59272 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 83000 83000 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 201586 201586 0 0.0
.text 2511042 2511042 0 0.0
thermostat-no-ble arm64 (read only) 2611708 2611708 0 0.0
(read/write) 143160 143160 0 0.0
.bss 52392 52392 0 0.0
.data 1736 1736 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 560 560 0 0.0
.got 5512 5512 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 129952 129952 0 0.0
.text 2215748 2215748 0 0.0
tv-app debug (read only) 3322209 3322209 0 0.0
(read/write) 261856 261856 0 0.0
.bss 171264 171264 0 0.0
.data 4080 4080 0 0.0
.data.rel.ro 79776 79776 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 222872 222872 0 0.0
.text 2902338 2902338 0 0.0
tv-casting-app debug (read only) 9322121 9322121 0 0.0
(read/write) 221776 221776 0 0.0
.bss 52128 52128 0 0.0
.data 1744 1744 0 0.0
.data.rel.ro 161296 161296 0 0.0
.dynamic 608 608 0 0.0
.got 4968 4968 0 0.0
.init 27 27 0 0.0
.init_array 1000 1000 0 0.0
.rodata 331308 331308 0 0.0
.text 8555810 8555810 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2515936 2515936 0 0.0
.bss 216312 216312 0 0.0
.data 5152 5152 0 0.0
.text 1478620 1478620 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1224940 1224940 0 0.0
bss 155370 155370 0 0.0
rodata 139440 139440 0 0.0
text 851052 851052 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1326068 1326068 0 0.0
bss 138696 138696 0 0.0
rodata 134056 134056 0 0.0
text 762612 762612 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1151904 1151904 0 0.0
bss 153489 153489 0 0.0
rodata 111732 111732 0 0.0
text 807596 807596 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841360 841360 0 0.0
(read/write) 1746604 1746604 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189412 189412 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2568 2568 0 0.0
.debug_abbrev 1314555 1314555 0 0.0
.debug_aranges 151328 151328 0 0.0
.debug_frame 506988 506988 0 0.0
.debug_info 29725828 29725827 -1 -0.0
.debug_line 4093516 4093516 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2346216 2346216 0 0.0
.debug_rnglists 146735 146735 0 0.0
.debug_str 4434632 4434632 0 0.0
.heap 841360 841360 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 775993 775993 0 0.0
.symtab 488208 488208 0 0.0
.text 0 0 0 0.0
1546236 1546236 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 843208 843208 0 0.0
(read/write) 1664972 1664972 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187572 187572 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2560 2560 0 0.0
.debug_abbrev 1282285 1282285 0 0.0
.debug_aranges 148560 148560 0 0.0
.debug_frame 502784 502784 0 0.0
.debug_info 28442664 28442663 -1 -0.0
.debug_line 4046639 4046639 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2304459 2304459 0 0.0
.debug_rnglists 143485 143485 0 0.0
.debug_str 4376803 4376803 0 0.0
.heap 843208 843208 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 703634 703634 0 0.0
.symtab 461856 461856 0 0.0
.text 1466452 1466452 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849416 849416 0 0.0
(read/write) 1597644 1597644 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 181532 181532 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1119163 1119163 0 0.0
.debug_aranges 138920 138920 0 0.0
.debug_frame 466752 466752 0 0.0
.debug_info 23212182 23212180 -2 -0.0
.debug_line 3618476 3618476 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 2145560 2145560 0 0.0
.debug_rnglists 133519 133519 0 0.0
.debug_str 4190554 4190554 0 0.0
.heap 849416 849416 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 627131 627131 0 0.0
.symtab 427392 427392 0 0.0
.text 1405332 1405332 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 821960 821960 0 0.0
(read/write) 1628540 1628540 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 208988 208988 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2392 2392 0 0.0
.debug_abbrev 1101369 1101369 0 0.0
.debug_aranges 137016 137016 0 0.0
.debug_frame 460012 460012 0 0.0
.debug_info 22910053 22910055 2 0.0
.debug_line 3553761 3553761 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 2114140 2114140 0 0.0
.debug_rnglists 131043 131043 0 0.0
.debug_str 4145738 4145738 0 0.0
.heap 821960 821960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 597360 597360 0 0.0
.symtab 417680 417680 0 0.0
.text 1408772 1408772 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1172496 1172504 8 0.0
.bss 99960 99960 0 0.0
.data 788 788 0 0.0
.text 619336 619344 8 0.0
lock-app qpg6105+debug (read/write) 1130624 1130624 0 0.0
.bss 94816 94816 0 0.0
.data 792 792 0 0.0
.text 577468 577468 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1050780 1050780 0 0.0
bss 98292 98292 0 0.0
text 721634 721636 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 965152 965152 0 0.0
bss 96288 96288 0 0.0
text 668178 668178 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 930560 930552 -8 -0.0
bss 100312 100312 0 0.0
text 643234 643232 -2 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 862260 862260 0 0.0
bss 89972 89972 0 0.0
text 586406 586402 -4 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 890872 890872 0 0.0
bss 90516 90516 0 0.0
text 611866 611870 4 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 969108 969108 0 0.0
bss 98652 98652 0 0.0
text 682148 682146 -2 -0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 980480 980480 0 0.0
bss 102900 102900 0 0.0
text 689664 689664 0 0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1038592 1038592 0 0.0
bss 100208 100208 0 0.0
text 727034 727034 0 0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1069956 1069956 0 0.0
bss 111292 111292 0 0.0
text 747182 747182 0 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 917372 917372 0 0.0
bss 90636 90636 0 0.0
text 615072 615074 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 884860 884860 0 0.0
bss 91248 91248 0 0.0
text 608248 608248 0 0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 867860 867860 0 0.0
bss 90104 90104 0 0.0
text 592164 592166 2 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 854880 854880 0 0.0
bss 89904 89904 0 0.0
text 582510 582508 -2 -0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 851036 851036 0 0.0
bss 89812 89812 0 0.0
text 578138 578140 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 896940 896948 8 0.0
bss 90348 90348 0 0.0
text 617552 617554 2 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 892320 892320 0 0.0
bss 90640 90640 0 0.0
text 612474 612476 2 0.0

@woody-apple woody-apple merged commit 5f0f5c3 into project-chip:master Jul 11, 2023
51 of 52 checks passed
@Survensa Survensa mentioned this pull request Jul 12, 2023
Closed
@hare-siterwell hare-siterwell deleted the fix-TLVMeta branch July 12, 2023 09:53
@andy31415
Copy link
Contributor

I am not sure if this was the right fix ... maybe ignoring the error is more correct. #27908 specifically still shows up and this compile error did not occur with any of the CI compilers.

@andy31415
Copy link
Contributor

Supposedly ISO 9899:2011 6.7.6.2 says If the expression is a constant expression, it shall have a value greater than zero. ... so we do indeed need to remove these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Build] Error occurs while compiling CHIP-TOOL [BUG] chip-tool compilation failed after one commit
4 participants
@hare-siterwell @andy31415 @bzbarsky-apple @woody-apple