Remove Unused Aliased Resource Monitoring Clusters #27893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed-resource-monitoring-clusters-from-the-sdk
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
…sed-resource-monitoring-clusters-from-the-sdk
This manual work should be avoided by using wildcard imports rather than manually listing every cluster here.
…usly-provisionally-aliased-resource-monitoring-clusters-from-the-sdk
|
@p0fi This unfortunately has a merge conflict. Can you please resolve? |
…sed-resource-monitoring-clusters-from-the-sdk # Conflicts: # .github/workflows/tests.yaml
…sionally-aliased-resource-monitoring-clusters-from-the-sdk
Done! |
…sed-resource-monitoring-clusters-from-the-sdk
The test would not run correctly but the changes of this PR are not touching things related to this test.
…sed-resource-monitoring-clusters-from-the-sdk # Conflicts: # src/app/tests/suites/certification/Test_TC_CFREMON_1_1.yaml # src/app/tests/suites/certification/Test_TC_CFREMON_2_1.yaml # src/app/tests/suites/certification/Test_TC_ESFREMON_1_1.yaml # src/app/tests/suites/certification/Test_TC_ESFREMON_2_1.yaml # src/app/tests/suites/certification/Test_TC_FTREMON_1_1.yaml # src/app/tests/suites/certification/Test_TC_FTREMON_2_1.yaml # src/app/tests/suites/certification/Test_TC_INKCREMON_1_1.yaml # src/app/tests/suites/certification/Test_TC_INKCREMON_2_1.yaml # src/app/tests/suites/certification/Test_TC_IONFREMON_1_1.yaml # src/app/tests/suites/certification/Test_TC_IONFREMON_2_1.yaml # src/app/tests/suites/certification/Test_TC_OZFREMON_1_1.yaml # src/app/tests/suites/certification/Test_TC_OZFREMON_2_1.yaml # src/app/tests/suites/certification/Test_TC_TCREMON_1_1.yaml # src/app/tests/suites/certification/Test_TC_TCREMON_2_1.yaml # src/app/tests/suites/certification/Test_TC_UVFREMON_1_1.yaml # src/app/tests/suites/certification/Test_TC_UVFREMON_2_1.yaml # src/app/tests/suites/certification/Test_TC_WTREMON_1_1.yaml # src/app/tests/suites/certification/Test_TC_WTREMON_2_1.yaml # src/app/tests/suites/certification/Test_TC_ZEOFREMON_1_1.yaml # src/app/tests/suites/certification/Test_TC_ZEOFREMON_2_1.yaml # zzz_generated/chip-tool/zap-generated/test/Commands.h
…ovisionally-aliased-resource-monitoring-clusters-from-the-sdk"" This reverts commit 7348159. # Conflicts: # .github/workflows/tests.yaml
…sed-resource-monitoring-clusters-from-the-sdk
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Jul 21, 2023
* Remove Unused Clusters * Update Code Gen * Delete Unnecessary Test Plans * Remove PICS * Remove Expected Generated Files * Remove Deleted Test Cases * Update Code Gen * Update PICS Values in CI Tests * Remove Clusters From ZAP Tool * Delete Unused Serverinitcallbacks * Remove Deleted Clusters From All Clusters App * Update ZAP File * Revert "Merge branch 'master' into 27663-remove-previously-provisionally-aliased-resource-monitoring-clusters-from-the-sdk" This reverts commit 02d094f, reversing changes made to a7618cf. * Fix Import Statements This manual work should be avoided by using wildcard imports rather than manually listing every cluster here. * Fix Style * Remove Failing Test The test would not run correctly but the changes of this PR are not touching things related to this test. * Update Code Gen * Disable Test * Revert "Revert "Merge branch 'master' into 27663-remove-previously-provisionally-aliased-resource-monitoring-clusters-from-the-sdk"" This reverts commit 7348159. # Conflicts: # .github/workflows/tests.yaml --------- Co-authored-by: Tobias Graf <4622393+tobiasgraf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR updates the cluster definition of the resource monitoring cluster to remove all the aliases which are not used anymore.
It also removes:
🔗 Links/References
closes #27663