Descriptor Cluster Adding TagList attribute #27905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
woody-apple
force-pushed
the
quickfix/DescriptorClusterTags
branch
from
f80439f
to
4672e50
Compare
|
@woody-apple to follow up. |
…beck-whirlpool/connectedhomeip into quickfix/DescriptorClusterTags
cliffamzn
reviewed
Jul 20, 2023
src/app/zap-templates/zcl/data-model/chip/descriptor-cluster.xml
Outdated
Show resolved
Hide resolved
woody-apple
approved these changes
Jul 20, 2023
Co-authored-by: Cliff Chung <116232729+cliffamzn@users.noreply.github.com>
cliffamzn
approved these changes
Jul 20, 2023
pullapprove
bot
requested review from
andy31415,
aronrosenberg,
emargolis and
mlepage-google
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Jul 21, 2023
* Updating to add attribute for TagList on descriptor cluster * Fixing XML with SemanticTagStruct type and regen * Update src/app/zap-templates/zcl/data-model/chip/descriptor-cluster.xml Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Reverting odd change in settings.json * Updating to NamespaceID instead of namespace * Updating to add attribute for TagList on descriptor cluster * Fixing XML with SemanticTagStruct type and regen * Update src/app/zap-templates/zcl/data-model/chip/descriptor-cluster.xml Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Reverting odd change in settings.json * Updating to NamespaceID instead of namespace * Updating namespace with. regen * Regen after rebase from Master * Updates from regen * Updating regen * Update src/app/zap-templates/zcl/data-model/chip/descriptor-cluster.xml Co-authored-by: Cliff Chung <116232729+cliffamzn@users.noreply.github.com> * Regen after new merge --------- Co-authored-by: abeck-riis <98488327+abeck-riis@users.noreply.github.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Justin Wood <woody@apple.com> Co-authored-by: Cliff Chung <116232729+cliffamzn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Tag List attribute to Descriptor Cluster to match spec
Regen all files