[zephyr] Run shell commands in Matter thread #28623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #28623: Size comparison from 570eb83 to f3ff348 Increases above 0.2%:
Increases (16 builds for bl602, cc32xx, linux, nrfconnect, psoc6, telink)
Decreases (11 builds for bl702, bl702l, linux, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
force-pushed
the
shell-errors
branch
from
f3ff348
to
5c436f8
Compare
|
PR #28623: Size comparison from c57aec6 to 5c436f8 Increases above 0.2%:
Increases (15 builds for bl602, bl702, cc32xx, linux, psoc6, telink)
Decreases (12 builds for bl702l, efr32, esp32, linux, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
1. Run Matter shell commands in Matter thread instead of Zephyr's shell thread. Make the shell thread wait for the condition variable signalled when the command ends in the Matter thread. This is done to avoid data races when accessing Matter's data structures, and avoid stack overflow when executing Matter functions in the shell thread that uses a relatively small stack. 2. Print either: - "Done" or - "Error: <error_string_or_code>" after each shell command. This is to align with other platforms and be able to remove unnecessary logging from existing shell command implementations. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
Damian-Nordic
force-pushed
the
shell-errors
branch
from
5c436f8
to
35728c2
Compare
Damian-Nordic
changed the title
|
PR #28623: Size comparison from b0b0d58 to 35728c2 Increases (8 builds for esp32, nrfconnect, psoc6, telink)
Decreases (14 builds for bl602, bl702, cc32xx, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
kkasperczyk-no
approved these changes
Aug 14, 2023
yufengwangca
approved these changes
Aug 16, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
1. Run Matter shell commands in Matter thread instead of Zephyr's shell thread. Make the shell thread wait for the condition variable signalled when the command ends in the Matter thread. This is done to avoid data races when accessing Matter's data structures, and avoid stack overflow when executing Matter functions in the shell thread that uses a relatively small stack. 2. Print either: - "Done" or - "Error: <error_string_or_code>" after each shell command. This is to align with other platforms and be able to remove unnecessary logging from existing shell command implementations. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run Matter shell commands in Matter thread instead of Zephyr's shell thread. Make the shell thread wait for the condition variable signalled when the command ends in the Matter thread.
This is done to avoid data races when accessing Matter's data structures, and avoid stack overflow when executing Matter functions in the shell thread that uses a relatively small stack.
Print either:
after each shell command. This is to align with other platforms and be able to remove unnecessary logging from existing shell command implementations.