[Android]add json support for invoke and write #28759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #28759: Size comparison from a167c71 to 642f8c3 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
yunhanw-google
force-pushed
the
feature/json_invoke_write
branch
from
642f8c3
to
84e0c61
Compare
yunhanw-google
force-pushed
the
feature/json_invoke_write
branch
from
84e0c61
to
90b06a2
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple and
younghak-hwang
|
PR #28759: Size comparison from a167c71 to 90b06a2 Increases (4 builds for cc32xx, psoc6)
Decreases (3 builds for bl702, efr32, esp32)
Full report (31 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
yufengwangca
approved these changes
Aug 18, 2023
yunhanw-google
force-pushed
the
feature/json_invoke_write
branch
from
90b06a2
to
08973ac
Compare
|
PR #28759: Size comparison from f4ec7c5 to 08973ac Increases (8 builds for bl702, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (15 builds for bl702, cc32xx, efr32, k32w, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Aug 24, 2023
| VerifyOrExit(tlvBytesObj != nullptr, err = CHIP_ERROR_INVALID_ARGUMENT); | ||
| if (tlvBytesObj != nullptr) | ||
| { | ||
| jbyte * tlvBytesObjBytes = env->GetByteArrayElements(tlvBytesObj, nullptr); |
There was a problem hiding this comment.
This misses ReleaseByteArrayElements
andy31415
reviewed
Aug 24, 2023
| if (jsonJniString != nullptr) | ||
| { | ||
| JniUtfString jsonUtfJniString(env, jsonJniString); | ||
| uint8_t buf[chip::app::kMaxSecureSduLengthBytes] = { 0 }; |
There was a problem hiding this comment.
This buffer is valid within the scope of {}. tlvBytes makes it escape that, so you would be using invalid data.
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- [Android]add json support for invoke and write using latest json/tlv conversion
-- Add corresponding invoke and write test.