[Telink] Fix restart BLE adv after basic commissioning fail #28808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #28808: Size comparison from 2b805b2 to bbd2a8d Increases (3 builds for bl602, bl702, bl702l)
Full report (9 builds for bl602, bl702, bl702l, cc32xx, mbed, qpg)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
pullapprove
bot
requested review from
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #28808: Size comparison from e289bd1 to 21178f1 Increases (20 builds for bl702, psoc6, telink)
Decreases (5 builds for bl602, cyw30739, efr32, nrfconnect, psoc6)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Aug 22, 2023
serhiiSalamakha
force-pushed
the
telink_restart_ble_adv_after_basic_commissioning_fail
branch
from
21178f1
to
6e19a4f
Compare
|
PR #28808: Size comparison from 5313f74 to 6e19a4f Increases (18 builds for telink)
Decreases (1 build for efr32)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
@bzbarsky-apple Could you perform PR review? |
@s07641069 Boris is in vacation until Aug 27. Could get another reviewer (ask on slack) or if nobody else availabe I can fast track this as platform-specific fix |
No problem let's merge. |
Comment on lines
+160
to
+161
| bool isBasicCommissioningMode = chip::Server::GetInstance().GetCommissioningWindowManager().GetCommissioningMode() == | ||
| Dnssd::CommissioningMode::kEnabledBasic; |
There was a problem hiding this comment.
Why does basic vs enhanced matter here?
If commissioner A opens a basic commissioning window, commissioner B is trying to commission, and commissioner A removes itself during that time... why would we want to reset mid-commissioning?
There was a problem hiding this comment.
@bzbarsky-apple
Changes are no longer relevant.
Please see:
#28947
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
…chip#28808) * [Telink] Fix restart BLE adv after basic commissioning fail * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
serhiiSalamakha
deleted the
telink_restart_ble_adv_after_basic_commissioning_fail
branch
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…chip#28808) * [Telink] Fix restart BLE adv after basic commissioning fail * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To restart the BLE advertising after the basic commissioning failed to need to restore the default values to the setting partition after erasing.
For this need to reboot the system only after a problem during the basic commissioning mode.
The setting partition will be set during the system initialization.