Remove mInfo field from Cancelable by default. #29262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's big, and totally unused. The opt-in to enable it is for backwards compat. If we care about preserving compat while also ensuring that some internal Cancelable uses never have this field, that is also possible, but more complicated.
tcarmelveilleux
approved these changes
Sep 14, 2023
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
pullapprove
bot
requested review from
LuDuda,
mhazley,
mkardous-silabs,
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tima-q,
tobiasgraf,
vivien-apple,
woody-apple and
younghak-hwang
Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>
|
👏🎉 that one snuck in there didn't it 😅 |
|
PR #29262: Size comparison from 3400d1d to 0fa434f Increases (24 builds for bl602, bl702, bl702l, cc32xx, psoc6, telink)
Decreases (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
Do we need the backward compat? I think it could have been removed in #14581 |
I suspect even if somebody spotted this storage they would not have risked stashing anything there. Keeping an option seems safe, but I would suggest we aim to remove it later since it likely does not impact anyone. |
mspang
approved these changes
Sep 14, 2023
Damian-Nordic
approved these changes
Sep 15, 2023
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Remove mInfo field from Cancelable by default. It's big, and totally unused. The opt-in to enable it is for backwards compat. If we care about preserving compat while also ensuring that some internal Cancelable uses never have this field, that is also possible, but more complicated. * Apply suggestion from code review. Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> --------- Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's big, and totally unused.
The opt-in to enable it is for backwards compat. If we care about preserving compat while also ensuring that some internal Cancelable uses never have this field, that is also possible, but more complicated.