Add intelligence to the ExchangeContext to determine if a peer is active #29549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #29549: Size comparison from 19771ed to 1677310 Increases (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg)
Decreases (5 builds for cc32xx, psoc6)
Full report (51 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg)
|
|
PR #29549: Size comparison from 19771ed to bcb60db Increases (41 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Decreases (5 builds for cc32xx, psoc6)
Full report (41 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
|
PR #29549: Size comparison from 19771ed to cb15dc0 Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for cc32xx, psoc6)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Oct 3, 2023
mkardous-silabs
force-pushed
the
feature/mrp_opt
branch
from
cb15dc0
to
5b2ad6c
Compare
|
PR #29549: Size comparison from f03e9ef to 5b2ad6c Increases (4 builds for cc32xx, mbed, qpg)
Full report (4 builds for cc32xx, mbed, qpg)
|
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha and
gjc13
tcarmelveilleux
approved these changes
Oct 10, 2023
|
PR #29549: Size comparison from 7a50966 to 8f6ad0f Increases (30 builds for bl702, bl702l, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, nrfconnect, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
doru91
approved these changes
Oct 11, 2023
bzbarsky-apple
approved these changes
Oct 11, 2023
|
PR #29549: Size comparison from 7a50966 to 75e1889 Increases (27 builds for bl702, bl702l, cc32xx, linux, nrfconnect, psoc6)
Decreases (41 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Full report (47 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
mkardous-silabs
force-pushed
the
feature/mrp_opt
branch
from
75e1889
to
1dd0ada
Compare
|
PR #29549: Size comparison from a9b8be8 to 1dd0ada Increases (25 builds for bl702, bl702l, cc32xx, linux, psoc6)
Decreases (58 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…ive (project-chip#29549) * Add intelligence to the exchange context * Restyled by whitespace * Restyled by clang-format * fix name * Apply suggestions from code review Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * address review comments * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * address review comments * fix rebase * Refactor changes to simplify and remove req on exchange context consummer * fix comment * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
…ive (project-chip#29549) * Add intelligence to the exchange context * Restyled by whitespace * Restyled by clang-format * fix name * Apply suggestions from code review Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> * address review comments * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * address review comments * fix rebase * Refactor changes to simplify and remove req on exchange context consummer * fix comment * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the introduction of ICDs, it is possible for the Session Active Threshold to be 0 which means that the session would always think the peer is inactive.
The goal of the PR is to used knowledge based on messages received to determine if the sender can assumer the peer (receiver) is active.
If we receive an application-level message, we assume that during the lifetime of the current exchange, the peer (receiver) is active.
Spec PR to allow these changes
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7587
Tests
Use the Case session to validate steps.