[Silabs] Adds updated WiseConnect SDK and docker pre-installed WiFi SDKs #29646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #29646: Size comparison from f34b13c to b72a049 Full report (27 builds for cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
|
PR #29646: Size comparison from f34b13c to 3a035e9 Decreases (2 builds for telink)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
brosahay
force-pushed
the
feature/add-docker-updates
branch
from
8ae356a
to
3cfe5ca
Compare
|
PR #29646: Size comparison from 9555e32 to 3cfe5ca Increases (1 build for bl702)
Full report (43 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
|
PR #29646: Size comparison from 9555e32 to f3ed61a Full report (4 builds for cc32xx, mbed, qpg)
|
brosahay
force-pushed
the
feature/add-docker-updates
branch
from
f3ed61a
to
b5e84d3
Compare
|
PR #29646: Size comparison from ffd1571 to b5e84d3 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jepenven-silabs
approved these changes
Oct 12, 2023
jmartinez-silabs
approved these changes
Oct 12, 2023
andy31415
reviewed
Oct 12, 2023
| @@ -0,0 +1,10 @@ | |||
| # The below dependencies are being installed by apt inside docker | |||
There was a problem hiding this comment.
why in scripts/setup instead inside of chip-build-efr32 ?
Maybe consider having this file and then copy inside docker and pip install -r on it, so it is always up to date.
There was a problem hiding this comment.
I see silabs_docker is indeed a platform in .gitmodules (am surprised since we already have efr32) ... do you happen to know the history behind that?
There was a problem hiding this comment.
Not that I know completely but the use of it seems to indicate the repos we want to clone inside docker, while the rest can be used for a "persistent" build environment.
There was a problem hiding this comment.
@andy31415 We added silabs_docker to avoid cloning the gecko_sdk everytime the ci sets up an environnement.
efr32 clones the gecko_sdk submodule while silabs_docker does not and uses the pre-installed one.
There was a problem hiding this comment.
I think checking in a file with all comments does not look as useful.
It is likely easy to get out of sync with the dockerfile anyway. I would prefer to completely remove this file.
brosahay
force-pushed
the
feature/add-docker-updates
branch
from
b5e84d3
to
b196e93
Compare
|
PR #29646: Size comparison from c08b8f8 to b196e93 Full report (1 build for cc32xx)
|
andy31415
approved these changes
Oct 12, 2023
|
PR #29646: Size comparison from c08b8f8 to 35a7ba9 Decreases (1 build for bl602)
Full report (43 builds for bl602, bl702, bl702l, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…DKs (project-chip#29646) * Adds chages to docker image and build scripts * Adds fix for alignment * Adds bugfix for change directory * Removes changes from other PR * Adds book keeping version checks * Reverts changes to be added after docker update * Adds updated SDK as per release * Updates wiseconnect-wifi-bt-sdk to 2.8.1 * Adds updated docker images * Adds update of WiSeConnect 2 SDK 2.8.2 * Adds requirements file for pip freeze --------- Co-authored-by: Rohan Sahay <rohan.sahay@silabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested manually by creating docker and running the following scripts: