Split apart text-only logging and binary logging. #29661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #29661: Size comparison from 762d3ab to 0c6082f Increases (13 builds for bl702, bl702l, cc32xx, cyw30739, psoc6)
Decreases (14 builds for bl702, bl702l, cc13x4_26x4, cc32xx, k32w, psoc6)
Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
bzbarsky-apple
force-pushed
the
split-span-logging-from-core-logging
branch
from
0c6082f
to
17af39e
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs and
jmartinez-silabs
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
pullapprove
bot
added
review - pending
examples
platform
and removed
examples
platform
labels
|
PR #29661: Size comparison from 3dfffe7 to 17af39e Increases (13 builds for bl702, bl702l, cc32xx, cyw30739, psoc6)
Decreases (14 builds for bl702, bl702l, cc13x4_26x4, cc32xx, k32w, psoc6)
Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
Text-only logging does not depend on Span, but binary logging (LogByteSpan) does. And Span.h depends on text-only logging. We were manually breaking the cycle caused by having both logging types in CHIPLogging.h by not including Span.h from CHIPLogging.h and forward-declaring Span instead. This fixes things so that we have a TextOnlyLogging.h (which is used by Span.h, via CodeUtils.h, and does not use Span at all), and a BinaryLogging.h which uses Span and includes Span.h.
bzbarsky-apple
force-pushed
the
split-span-logging-from-core-logging
branch
from
17af39e
to
9f56e1b
Compare
|
PR #29661: Size comparison from 3dfffe7 to 9f56e1b Increases (16 builds for bl702, bl702l, cc32xx, cyw30739, linux, psoc6)
Decreases (18 builds for bl702, bl702l, cc13x4_26x4, cc32xx, k32w, linux, psoc6)
Full report (50 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
|
It might be less churn to move |
arkq
approved these changes
Oct 10, 2023
jmartinez-silabs
approved these changes
Oct 10, 2023
In our tree... I was aiming to not break any existing consumers, who are including CHIPLogging.h and then using ChipLogByteSpan. |
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
Text-only logging does not depend on Span, but binary logging (LogByteSpan) does. And Span.h depends on text-only logging. We were manually breaking the cycle caused by having both logging types in CHIPLogging.h by not including Span.h from CHIPLogging.h and forward-declaring Span instead. This fixes things so that we have a TextOnlyLogging.h (which is used by Span.h, via CodeUtils.h, and does not use Span at all), and a BinaryLogging.h which uses Span and includes Span.h.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text-only logging does not depend on Span, but binary logging (LogByteSpan) does. And Span.h depends on text-only logging.
We were manually breaking the cycle caused by having both logging types in CHIPLogging.h by not including Span.h from CHIPLogging.h and forward-declaring Span instead. This fixes things so that we have a TextOnlyLogging.h (which is used by Span.h, via CodeUtils.h, and does not use Span at all), and a BinaryLogging.h which uses Span and includes Span.h.
Review note: git's default copy detection is failing here; a diff with
-Bor--break-rewritesas part of the diff args is likely more readable.