Fix memory leak in UnauthenticatedSessionTable. #30025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
|
PR #30025: Size comparison from f0b5c68 to e82e7ee Increases (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (20 builds for cc32xx, linux, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
kpschoedel
approved these changes
Oct 26, 2023
UnauthenticatedSessionTable essentially assumed that non-heap pools were used and was: 1) Never releasing its entries back to the pool. 2) Assuming that the pool would fill up and then its "reuse already allocated entry with zero refcount" code would kick in. Since heap pools never fill up, this meant that every single UnauthenticatedSession allocated was leaked. And we had a helpful "release them all on destruction" to cover up the leak at shutdown and prevent leak tools from finding it. This fix: * Preserves existing behavior for non-heap pools. * Switches to releasing UnauthenticatedSessions back to the pool in the heap case.
bzbarsky-apple
force-pushed
the
fix-handshake-leak
branch
from
e82e7ee
to
17bb363
Compare
|
PR #30025: Size comparison from 28de696 to 17bb363 Increases (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (20 builds for cc32xx, linux, psoc6)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Oct 27, 2023
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
UnauthenticatedSessionTable essentially assumed that non-heap pools were used and was: 1) Never releasing its entries back to the pool. 2) Assuming that the pool would fill up and then its "reuse already allocated entry with zero refcount" code would kick in. Since heap pools never fill up, this meant that every single UnauthenticatedSession allocated was leaked. And we had a helpful "release them all on destruction" to cover up the leak at shutdown and prevent leak tools from finding it. This fix: * Preserves existing behavior for non-heap pools. * Switches to releasing UnauthenticatedSessions back to the pool in the heap case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnauthenticatedSessionTable essentially assumed that non-heap pools were used and was:
entry with zero refcount" code would kick in.
Since heap pools never fill up, this meant that every single UnauthenticatedSession allocated was leaked. And we had a helpful "release them all on destruction" to cover up the leak at shutdown and prevent leak tools from finding it.
This fix: