Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CommandHandler to support batch commands #30614

Merged
merged 22 commits into from Nov 30, 2023
Merged

Update CommandHandler to support batch commands #30614

merged 22 commits into from Nov 30, 2023

Conversation

tehampson
Copy link
Contributor

@tehampson tehampson commented Nov 22, 2023 •
edited

This is a Matter 1.3 feature. Currently this allows for sync and async commands responses to be processed. This does rely on ideal cases for the time being. Everything must be able to fit and be sent back in a single InvokeResponseMessage.

For the time being this fails in similar ways when MAX_PATHS_PER_INVOKE is set to 1, although the range might be just a little bigger now. See #30643 where we do not fallback to appropriate size

This PR is completed up to the point it is so that we have this feature in for FC date. But we will continue to work on follow up as more bug fixes to this feature that way we make it in time for 1.3 release

Work still remaining that will be complete in a follow up PR:

  • Allow for sending multiple individual InvokeResponse
  • When we run out of space, send out all currently complete command responses

Test:

  • CI passes
  • With local changes confirmed that we are able to handle and reply to multiple incoming commands

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2023 •
edited

PR #30614: Size comparison from 28ddbeb to 4fe0bdc

Increases above 0.2%:

platform target config section 28ddbeb 4fe0bdc change % change
linux chip-tool-ipv6only arm64 (read/write) 530664 531776 1112 0.2
thermostat-no-ble arm64 (read/write) 245176 245728 552 0.2
Increases (17 builds for cc13x4_26x4, cc32xx, k32w, linux, mbed, qpg)
platform target config section 28ddbeb 4fe0bdc change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 740555 741171 616 0.1
(read/write) 167088 167144 56 0.0
.bss 89500 89556 56 0.1
.text 655256 655872 616 0.1
lock-ftd LP_EM_CC1354P10_6 (read only) 757883 758499 616 0.1
(read/write) 177268 177324 56 0.0
.bss 99636 99692 56 0.1
.text 677540 678156 616 0.1
lock-mtd LP_EM_CC1354P10_6 (read only) 744859 745467 608 0.1
(read/write) 171716 171772 56 0.0
.bss 94084 94140 56 0.1
.text 638720 639328 608 0.1
pump-app LP_EM_CC1354P10_6 (read only) 698907 699491 584 0.1
(read/write) 166124 166156 32 0.0
.bss 88304 88336 32 0.0
.text 617840 618424 584 0.1
pump-controller-app LP_EM_CC1354P10_6 (read only) 684563 685179 616 0.1
(read/write) 166264 166320 56 0.0
.bss 88456 88512 56 0.1
.text 607656 608272 616 0.1
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 564690 565458 768 0.1
(read/write) 207520 207632 112 0.1
.bss 200980 201092 112 0.1
.text 478768 479536 768 0.2
lock CC3235SF_LAUNCHXL (read only) 617546 618314 768 0.1
(read/write) 207860 207972 112 0.1
.bss 201296 201408 112 0.1
.text 509752 510520 768 0.2
k32w contact k32w0+release (read only) 592940 593548 608 0.1
(read/write) 88104 88160 56 0.1
.bss 71344 71400 56 0.1
.text 592404 593012 608 0.1
k32w1+release (read/write) 688472 689136 664 0.1
.bss 67544 67600 56 0.1
.text 574728 575336 608 0.1
light k32w0+release (read only) 592660 593268 608 0.1
(read/write) 87780 87836 56 0.1
.bss 71032 71088 56 0.1
.text 592124 592732 608 0.1
k32w1+release (read/write) 780620 781284 664 0.1
.bss 77220 77276 56 0.1
.text 658008 658616 608 0.1
lock k32w0+release (read only) 564500 565060 560 0.1
(read/write) 85608 85640 32 0.0
.bss 68920 68952 32 0.0
.text 563964 564524 560 0.1
linux chip-tool-ipv6only arm64 (read only) 10599880 10602856 2976 0.0
(read/write) 530664 531776 1112 0.2
.data.rel.ro 397000 397024 24 0.0
.rodata 325248 325280 32 0.0
.text 9470856 9473768 2912 0.0
thermostat-no-ble arm64 (read only) 4388976 4392512 3536 0.1
(read/write) 245176 245728 552 0.2
.data.rel.ro 102048 102072 24 0.0
.rodata 161932 161964 32 0.0
.text 3887464 3890952 3488 0.1
mbed lock-app-release cy8cproto_062_4343w (read/write) 2523296 2523880 584 0.0
.bss 220032 220144 112 0.1
.text 1485980 1486564 584 0.0
qpg lighting-app qpg6105+debug (read/write) 1114752 1115352 600 0.1
.bss 101168 101224 56 0.1
.text 627128 627728 600 0.1
lock-app qpg6105+debug (read/write) 1076060 1076668 608 0.1
.bss 95936 95992 56 0.1
.text 588436 589044 608 0.1
Full report (17 builds for cc13x4_26x4, cc32xx, k32w, linux, mbed, qpg)
platform target config section 28ddbeb 4fe0bdc change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 740555 741171 616 0.1
(read/write) 167088 167144 56 0.0
.bss 89500 89556 56 0.1
.data 3424 3424 0 0.0
.rodata 84911 84911 0 0.0
.text 655256 655872 616 0.1
lock-ftd LP_EM_CC1354P10_6 (read only) 757883 758499 616 0.1
(read/write) 177268 177324 56 0.0
.bss 99636 99692 56 0.1
.data 3444 3444 0 0.0
.rodata 79951 79951 0 0.0
.text 677540 678156 616 0.1
lock-mtd LP_EM_CC1354P10_6 (read only) 744859 745467 608 0.1
(read/write) 171716 171772 56 0.0
.bss 94084 94140 56 0.1
.data 3444 3444 0 0.0
.rodata 105751 105751 0 0.0
.text 638720 639328 608 0.1
pump-app LP_EM_CC1354P10_6 (read only) 698907 699491 584 0.1
(read/write) 166124 166156 32 0.0
.bss 88304 88336 32 0.0
.data 3412 3412 0 0.0
.rodata 80679 80679 0 0.0
.text 617840 618424 584 0.1
pump-controller-app LP_EM_CC1354P10_6 (read only) 684563 685179 616 0.1
(read/write) 166264 166320 56 0.0
.bss 88456 88512 56 0.1
.data 3408 3408 0 0.0
.rodata 76519 76519 0 0.0
.text 607656 608272 616 0.1
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 564690 565458 768 0.1
(read/write) 207520 207632 112 0.1
.bss 200980 201092 112 0.1
.data 1416 1416 0 0.0
.rodata 83802 83802 0 0.0
.text 478768 479536 768 0.2
lock CC3235SF_LAUNCHXL (read only) 617546 618314 768 0.1
(read/write) 207860 207972 112 0.1
.bss 201296 201408 112 0.1
.data 1444 1444 0 0.0
.rodata 105674 105674 0 0.0
.text 509752 510520 768 0.2
k32w contact k32w0+release (read only) 592940 593548 608 0.1
(read/write) 88104 88160 56 0.1
.bss 71344 71400 56 0.1
.data 2136 2136 0 0.0
.text 592404 593012 608 0.1
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 688472 689136 664 0.1
.bss 67544 67600 56 0.1
.data 2720 2720 0 0.0
.text 574728 575336 608 0.1
light k32w0+release (read only) 592660 593268 608 0.1
(read/write) 87780 87836 56 0.1
.bss 71032 71088 56 0.1
.data 2124 2124 0 0.0
.text 592124 592732 608 0.1
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 780620 781284 664 0.1
.bss 77220 77276 56 0.1
.data 1932 1932 0 0.0
.text 658008 658616 608 0.1
lock k32w0+release (read only) 564500 565060 560 0.1
(read/write) 85608 85640 32 0.0
.bss 68920 68952 32 0.0
.data 2064 2064 0 0.0
.text 563964 564524 560 0.1
linux chip-tool-ipv6only arm64 (read only) 10599880 10602856 2976 0.0
(read/write) 530664 531776 1112 0.2
.bss 103352 103352 0 0.0
.data 4296 4296 0 0.0
.data.rel.ro 397000 397024 24 0.0
.dynamic 512 512 0 0.0
.got 18960 18960 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 325248 325280 32 0.0
.text 9470856 9473768 2912 0.0
thermostat-no-ble arm64 (read only) 4388976 4392512 3536 0.1
(read/write) 245176 245728 552 0.2
.bss 122248 122248 0 0.0
.data 2800 2800 0 0.0
.data.rel.ro 102048 102072 24 0.0
.dynamic 512 512 0 0.0
.got 11944 11944 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 161932 161964 32 0.0
.text 3887464 3890952 3488 0.1
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523296 2523880 584 0.0
.bss 220032 220144 112 0.1
.data 5136 5136 0 0.0
.text 1485980 1486564 584 0.0
qpg lighting-app qpg6105+debug (read/write) 1114752 1115352 600 0.1
.bss 101168 101224 56 0.1
.data 748 748 0 0.0
.text 627128 627728 600 0.1
lock-app qpg6105+debug (read/write) 1076060 1076668 608 0.1
.bss 95936 95992 56 0.1
.data 780 780 0 0.0
.text 588436 589044 608 0.1

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2023 •
edited

PR #30614: Size comparison from 25e922d to 8def682

Increases above 0.2%:

platform target config section 25e922d 8def682 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL .text 478920 480192 1272 0.3
lock CC3235SF_LAUNCHXL .text 509904 511232 1328 0.3
linux air-purifier-app debug (read only) 2507117 2513941 6824 0.3
.data.rel.ro 72408 72600 192 0.3
.text 2155013 2161301 6288 0.3
bridge-app debug .data.rel.ro 85008 85200 192 0.2
lighting-app debug+rpc+ui .data.rel.ro 93264 93456 192 0.2
lock-app debug .data.rel.ro 79256 79432 176 0.2
ota-provider-app debug .data.rel.ro 69040 69216 176 0.3
ota-requestor-app debug .data.rel.ro 72000 72176 176 0.2
shell debug (read only) 2767105 2774873 7768 0.3
.data.rel.ro 82272 82456 184 0.2
.text 2416082 2423314 7232 0.3
thermostat-no-ble arm64 (read/write) 245864 247720 1856 0.8
tv-app debug .data.rel.ro 90312 90504 192 0.2
Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 25e922d 8def682 change % change
bl602 lighting-app bl602 (read/write) 1411422 1413146 1724 0.1
.bss 85048 85160 112 0.1
.rodata 156840 156932 92 0.1
.text 1079498 1081018 1520 0.1
bl602+mfd (read/write) 1425862 1427594 1732 0.1
.bss 85216 85328 112 0.1
.rodata 155800 155892 92 0.1
.text 1094850 1096382 1532 0.1
bl602+rpc (read/write) 1458942 1460666 1724 0.1
.bss 93080 93192 112 0.1
.rodata 164456 164548 92 0.1
.text 1110986 1112506 1520 0.1
bl702 lighting-app bl702 (read/write) 1175843 1177567 1724 0.1
.rodata 106212 106304 92 0.1
.text 948638 950158 1520 0.2
bl702+mfd (read/write) 1186967 1188691 1724 0.1
.rodata 105152 105244 92 0.1
.text 960702 962222 1520 0.2
bl702+rpc (read/write) 1275911 1277635 1724 0.1
.rodata 121628 121720 92 0.1
.text 1023700 1025220 1520 0.1
bl706-eth (read/write) 995809 997277 1468 0.1
.rodata 99552 99644 92 0.1
.text 741874 743138 1264 0.2
bl706-wifi (read/write) 1231962 1233862 1900 0.2
.rodata 120524 120616 92 0.1
.text 967178 968876 1698 0.2
bl702l lighting-app bl702l (read/write) 1145560 1147284 1724 0.2
.rodata 100216 100308 92 0.1
.text 941736 943256 1520 0.2
bl702l+mfd (read/write) 1157532 1158744 1212 0.1
.rodata 99156 99248 92 0.1
.text 954112 955632 1520 0.2
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 740091 741139 1048 0.1
(read/write) 167064 167120 56 0.0
.bss 89476 89532 56 0.1
.rodata 84591 84647 56 0.1
.text 655112 656104 992 0.2
lock-ftd LP_EM_CC1354P10_6 (read only) 757491 758491 1000 0.1
(read/write) 177244 177300 56 0.0
.bss 99612 99668 56 0.1
.rodata 79671 79727 56 0.1
.text 677428 678372 944 0.1
lock-mtd LP_EM_CC1354P10_6 (read only) 744403 745419 1016 0.1
(read/write) 171692 171748 56 0.0
.bss 94060 94116 56 0.1
.rodata 105431 105487 56 0.1
.text 638584 639544 960 0.2
pump-app LP_EM_CC1354P10_6 (read only) 698443 699411 968 0.1
(read/write) 166100 166132 32 0.0
.bss 88280 88312 32 0.0
.rodata 80359 80415 56 0.1
.text 617696 618608 912 0.1
pump-controller-app LP_EM_CC1354P10_6 (read only) 684099 685091 992 0.1
(read/write) 166240 166296 56 0.0
.bss 88432 88488 56 0.1
.rodata 76191 76247 56 0.1
.text 607520 608456 936 0.2
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 564882 566242 1360 0.2
(read/write) 207520 207632 112 0.1
.bss 200980 201092 112 0.1
.rodata 83842 83930 88 0.1
.text 478920 480192 1272 0.3
lock CC3235SF_LAUNCHXL (read only) 617738 619154 1416 0.2
(read/write) 207860 207972 112 0.1
.bss 201296 201408 112 0.1
.rodata 105714 105802 88 0.1
.text 509904 511232 1328 0.3
cyw30739 light cyw930739m2evb_01 (read/write) 558463 559575 1112 0.2
.app_xip_area 448857 449857 1000 0.2
.bss 64520 64632 112 0.2
lock cyw930739m2evb_01 (read/write) 540647 541727 1080 0.2
.app_xip_area 426361 427329 968 0.2
.bss 69168 69280 112 0.2
ota-requestor cyw930739m2evb_01 (read/write) 559807 560879 1072 0.2
.app_xip_area 451657 452617 960 0.2
.bss 63136 63248 112 0.2
switch cyw930739m2evb_01 (read/write) 554927 556007 1080 0.2
.app_xip_area 443601 444569 968 0.2
.bss 66208 66320 112 0.2
efr32 lighting-app BRD4161A+rs9116 (read/write) 1013284 1014852 1568 0.2
.bss 172464 172576 112 0.1
.text 838104 839560 1456 0.2
BRD4187C (read/write) 1098180 1099308 1128 0.1
.bss 196068 196180 112 0.1
.text 898788 899804 1016 0.1
lock-app BRD4161A+wf200 (read/write) 1105032 1106112 1080 0.1
.bss 187064 187176 112 0.1
.text 915236 916204 968 0.1
window-app BRD4187C (read/write) 1132984 1134464 1480 0.1
.bss 168420 168532 112 0.1
.text 961368 962736 1368 0.1
esp32 all-clusters-app c3devkit (read only) 1133882 1135212 1330 0.1
(read/write) 1671004 1671180 176 0.0
.dram0.bss 72432 72544 112 0.2
.flash.rodata 241704 241768 64 0.0
.flash.text 1133882 1135212 1330 0.1
m5stack (read only) 1178307 1179687 1380 0.1
(read/write) 520616 520784 168 0.0
.dram0.bss 79064 79176 112 0.1
.flash.rodata 273168 273224 56 0.0
.flash.text 1172923 1174303 1380 0.1
k32w contact k32w0+release (read only) 592700 593732 1032 0.2
(read/write) 88088 88144 56 0.1
.bss 71328 71384 56 0.1
.text 592164 593196 1032 0.2
k32w1+release (read/write) 688264 689328 1064 0.2
.bss 67528 67584 56 0.1
.text 574536 575544 1008 0.2
light k32w0+release (read only) 592420 593436 1016 0.2
(read/write) 87764 87820 56 0.1
.bss 71016 71072 56 0.1
.text 591884 592900 1016 0.2
k32w1+release (read/write) 780148 781236 1088 0.1
.bss 77196 77252 56 0.1
.text 657560 658592 1032 0.2
lock k32w0+release (read only) 564260 565228 968 0.2
(read/write) 85584 85616 32 0.0
.bss 68896 68928 32 0.0
.text 563724 564692 968 0.2
linux air-purifier-app debug (read only) 2507117 2513941 6824 0.3
(read/write) 126832 127024 192 0.2
.data.rel.ro 72408 72600 192 0.3
.rodata 177512 177640 128 0.1
.text 2155013 2161301 6288 0.3
all-clusters-app debug (read only) 5330593 5338633 8040 0.2
(read/write) 429920 430080 160 0.0
.data.rel.ro 288784 288960 176 0.1
.rodata 302652 302780 128 0.0
.text 4639411 4646915 7504 0.2
all-clusters-minimal-app debug (read only) 4932985 4940881 7896 0.2
(read/write) 234440 234600 160 0.1
.data.rel.ro 95648 95824 176 0.2
.rodata 270861 270989 128 0.0
.text 4430227 4437587 7360 0.2
bridge-app debug (read only) 4405857 4412649 6792 0.2
(read/write) 215680 215872 192 0.1
.data.rel.ro 85008 85200 192 0.2
.rodata 218517 218613 96 0.0
.text 3969219 3975507 6288 0.2
chip-tool debug (read only) 10747953 10753601 5648 0.1
(read/write) 465200 465392 192 0.0
.data.rel.ro 358904 359080 176 0.0
.rodata 400905 401001 96 0.0
.text 9718243 9723363 5120 0.1
chip-tool-ipv6only arm64 (read only) 10598856 10603832 4976 0.0
.data.rel.ro 396824 397040 216 0.1
.got 18936 18952 16 0.1
.rodata 325040 325072 32 0.0
.text 9470536 9474936 4400 0.0
lighting-app debug+rpc+ui (read only) 5277009 5284505 7496 0.1
(read/write) 224432 224624 192 0.1
.data.rel.ro 93264 93456 192 0.2
.rodata 338196 338292 96 0.0
.text 4694787 4701779 6992 0.1
lock-app debug (read only) 4490377 4497521 7144 0.2
(read/write) 203264 203456 192 0.1
.data.rel.ro 79256 79432 176 0.2
.rodata 246517 246645 128 0.1
.text 4034323 4040931 6608 0.2
ota-provider-app debug (read only) 4155017 4161937 6920 0.2
(read/write) 192512 192704 192 0.1
.data.rel.ro 69040 69216 176 0.3
.rodata 200789 200917 128 0.1
.text 3762803 3769187 6384 0.2
ota-requestor-app debug (read only) 4241273 4248273 7000 0.2
(read/write) 196760 196920 160 0.1
.data.rel.ro 72000 72176 176 0.2
.rodata 204565 204693 128 0.1
.text 3840979 3847443 6464 0.2
shell debug (read only) 2767105 2774873 7768 0.3
(read/write) 149480 149672 192 0.1
.data.rel.ro 82272 82456 184 0.2
.rodata 180768 180896 128 0.1
.text 2416082 2423314 7232 0.3
thermostat-no-ble arm64 (read only) 4392336 4398720 6384 0.1
(read/write) 245864 247720 1856 0.8
.data.rel.ro 102080 102288 208 0.2
.got 11944 11960 16 0.1
.rodata 161980 162012 32 0.0
.text 3890680 3896504 5824 0.1
tv-app debug (read only) 5276057 5283137 7080 0.1
(read/write) 345208 345400 192 0.1
.data.rel.ro 90312 90504 192 0.2
.rodata 267285 267413 128 0.0
.text 4774131 4780675 6544 0.1
tv-casting-app debug (read only) 8688153 8695113 6960 0.1
(read/write) 322176 322368 192 0.1
.data.rel.ro 156672 156864 192 0.1
.rodata 346568 346696 128 0.0
.text 7918099 7924499 6400 0.1
mbed lock-app-release cy8cproto_062_4343w (read/write) 2523728 2524696 968 0.0
.bss 220032 220144 112 0.1
.text 1486412 1487380 968 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1057764 1058828 1064 0.1
bss 128911 129023 112 0.1
rodata 104036 104092 56 0.1
text 777156 778168 1012 0.1
nrf7002dk_nrf5340_cpuapp (read/write) 1184928 1186088 1160 0.1
bss 121133 121245 112 0.1
rodata 138296 138352 56 0.0
text 775172 776168 996 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1042984 1044176 1192 0.1
bss 129204 129316 112 0.1
rodata 99296 99352 56 0.1
text 766836 767840 1004 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1737852 1739516 1664 0.1
.bss 194532 194644 112 0.1
.text 1532452 1534004 1552 0.1
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1701668 1703340 1672 0.1
.bss 192812 192924 112 0.1
.text 1497988 1499548 1560 0.1
light cy8ckit_062s2_43012 (read/write) 1627748 1629364 1616 0.1
.bss 186236 186348 112 0.1
.text 1430756 1432260 1504 0.1
lock cy8ckit_062s2_43012 (read/write) 1654756 1656308 1552 0.1
.bss 213292 213404 112 0.1
.text 1430692 1432132 1440 0.1
qpg lighting-app qpg6105+debug (read/write) 1114288 1115336 1048 0.1
.bss 101152 101208 56 0.1
.text 626664 627712 1048 0.2
lock-app qpg6105+debug (read/write) 1075596 1076676 1080 0.1
.bss 95920 95976 56 0.1
.text 587972 589052 1080 0.2
telink air-quality-sensor-app tlsr9528a_retention (read/write) 817306 818458 1152 0.1
bss 53688 53720 32 0.1
text 610964 612028 1064 0.2
all-clusters-app tlsr9518adk80d (read/write) 1075208 1076664 1456 0.1
bss 99956 100068 112 0.1
text 758174 759468 1294 0.2
all-clusters-minimal-app tlsr9528a (read/write) 1080012 1081468 1456 0.1
bss 109652 109764 112 0.1
text 749760 751046 1286 0.2
bridge-app tlsr9518adk80d (read/write) 932288 933568 1280 0.1
bss 94160 94272 112 0.1
text 644702 645814 1112 0.2
contact-sensor-app tlsr9528a_retention (read/write) 817426 818570 1144 0.1
bss 53740 53772 32 0.1
text 611180 612232 1052 0.2
light-switch-app-ota-shell-factory-data tlsr9528a (read/write) 971520 972724 1204 0.1
bss 77548 77580 32 0.0
text 689154 690264 1110 0.2
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read/write) 1089900 1091284 1384 0.1
bss 99724 99836 112 0.1
text 766890 768112 1222 0.2
lock-app-dfu tlsr9528a (read/write) 958216 959416 1200 0.1
bss 95812 95844 32 0.0
text 643158 644270 1112 0.2
ota-requestor-app tlsr9518adk80d (read/write) 945496 946808 1312 0.1
bss 92268 92380 112 0.1
text 660370 661516 1146 0.2
pump-app tlsr9528a (read/write) 873788 874940 1152 0.1
bss 67576 67608 32 0.0
text 617582 618646 1064 0.2
pump-controller-app tlsr9518adk80d (read/write) 814472 815624 1152 0.1
bss 55812 55844 32 0.1
text 584536 585600 1064 0.2
shell tlsr9518adk80d (read/write) 705268 705404 136 0.0
text 461802 461922 120 0.0
smoke_co_alarm-app tlsr9528a_retention (read/write) 819150 820302 1152 0.1
bss 53824 53856 32 0.1
text 613904 614964 1060 0.2
temperature-measurement-app-mars-ota tlsr9518adk80d (read/write) 871177 872377 1200 0.1
bss 59288 59320 32 0.1
text 625888 626998 1110 0.2
thermostat tlsr9518adk80d (read/write) 838524 839660 1136 0.1
bss 56108 56140 32 0.1
text 602702 603754 1052 0.2
window-covering tlsr9518adk80d (read/write) 833024 834160 1136 0.1
bss 56460 56492 32 0.1
text 596930 597982 1052 0.2
Decreases (5 builds for linux, psoc6)
platform target config section 25e922d 8def682 change % change
linux chip-tool-ipv6only arm64 (read/write) 531680 530808 -872 -0.2
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 836328 836216 -112 -0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 838048 837936 -112 -0.0
light cy8ckit_062s2_43012 (read only) 844736 844624 -112 -0.0
lock cy8ckit_062s2_43012 (read only) 817664 817552 -112 -0.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 25e922d 8def682 change % change
bl602 lighting-app bl602 (read/write) 1411422 1413146 1724 0.1
.bss 85048 85160 112 0.1
.data 9376 9376 0 0.0
.rodata 156840 156932 92 0.1
.text 1079498 1081018 1520 0.1
bl602+mfd (read/write) 1425862 1427594 1732 0.1
.bss 85216 85328 112 0.1
.data 9344 9344 0 0.0
.rodata 155800 155892 92 0.1
.text 1094850 1096382 1532 0.1
bl602+rpc (read/write) 1458942 1460666 1724 0.1
.bss 93080 93192 112 0.1
.data 9744 9744 0 0.0
.rodata 164456 164548 92 0.1
.text 1110986 1112506 1520 0.1
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1175843 1177567 1724 0.1
.bss 11197 11197 0 0.0
.data 3560 3560 0 0.0
.rodata 106212 106304 92 0.1
.text 948638 950158 1520 0.2
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1186967 1188691 1724 0.1
.bss 11373 11373 0 0.0
.data 3536 3536 0 0.0
.rodata 105152 105244 92 0.1
.text 960702 962222 1520 0.2
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1275911 1277635 1724 0.1
.bss 19677 19677 0 0.0
.data 4112 4112 0 0.0
.rodata 121628 121720 92 0.1
.text 1023700 1025220 1520 0.1
bl706-eth (read/write) 995809 997277 1468 0.1
.bss 23772 23772 0 0.0
.data 3128 3128 0 0.0
.rodata 99552 99644 92 0.1
.text 741874 743138 1264 0.2
bl706-wifi (read/write) 1231962 1233862 1900 0.2
.bss 10657 10657 0 0.0
.data 3568 3568 0 0.0
.rodata 120524 120616 92 0.1
.text 967178 968876 1698 0.2
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1145560 1147284 1724 0.2
.bss 16408 16408 0 0.0
.data 4920 4920 0 0.0
.rodata 100216 100308 92 0.1
.text 941736 943256 1520 0.2
bl702l+mfd (read/write) 1157532 1158744 1212 0.1
.bss 16584 16584 0 0.0
.data 4904 4904 0 0.0
.rodata 99156 99248 92 0.1
.text 954112 955632 1520 0.2
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 740091 741139 1048 0.1
(read/write) 167064 167120 56 0.0
.bss 89476 89532 56 0.1
.data 3424 3424 0 0.0
.rodata 84591 84647 56 0.1
.text 655112 656104 992 0.2
lock-ftd LP_EM_CC1354P10_6 (read only) 757491 758491 1000 0.1
(read/write) 177244 177300 56 0.0
.bss 99612 99668 56 0.1
.data 3444 3444 0 0.0
.rodata 79671 79727 56 0.1
.text 677428 678372 944 0.1
lock-mtd LP_EM_CC1354P10_6 (read only) 744403 745419 1016 0.1
(read/write) 171692 171748 56 0.0
.bss 94060 94116 56 0.1
.data 3444 3444 0 0.0
.rodata 105431 105487 56 0.1
.text 638584 639544 960 0.2
pump-app LP_EM_CC1354P10_6 (read only) 698443 699411 968 0.1
(read/write) 166100 166132 32 0.0
.bss 88280 88312 32 0.0
.data 3412 3412 0 0.0
.rodata 80359 80415 56 0.1
.text 617696 618608 912 0.1
pump-controller-app LP_EM_CC1354P10_6 (read only) 684099 685091 992 0.1
(read/write) 166240 166296 56 0.0
.bss 88432 88488 56 0.1
.data 3408 3408 0 0.0
.rodata 76191 76247 56 0.1
.text 607520 608456 936 0.2
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 564882 566242 1360 0.2
(read/write) 207520 207632 112 0.1
.bss 200980 201092 112 0.1
.data 1416 1416 0 0.0
.rodata 83842 83930 88 0.1
.text 478920 480192 1272 0.3
lock CC3235SF_LAUNCHXL (read only) 617738 619154 1416 0.2
(read/write) 207860 207972 112 0.1
.bss 201296 201408 112 0.1
.data 1444 1444 0 0.0
.rodata 105714 105802 88 0.1
.text 509904 511232 1328 0.3
cyw30739 light cyw930739m2evb_01 (read/write) 558463 559575 1112 0.2
.app_xip_area 448857 449857 1000 0.2
.bss 64520 64632 112 0.2
.data 664 664 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 540647 541727 1080 0.2
.app_xip_area 426361 427329 968 0.2
.bss 69168 69280 112 0.2
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 559807 560879 1072 0.2
.app_xip_area 451657 452617 960 0.2
.bss 63136 63248 112 0.2
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 554927 556007 1080 0.2
.app_xip_area 443601 444569 968 0.2
.bss 66208 66320 112 0.2
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1013284 1014852 1568 0.2
.bss 172464 172576 112 0.1
.data 2696 2696 0 0.0
.text 838104 839560 1456 0.2
BRD4187C (read/write) 1098180 1099308 1128 0.1
.bss 196068 196180 112 0.1
.data 3304 3304 0 0.0
.text 898788 899804 1016 0.1
lock-app BRD4161A+wf200 (read/write) 1105032 1106112 1080 0.1
.bss 187064 187176 112 0.1
.data 2708 2708 0 0.0
.text 915236 916204 968 0.1
window-app BRD4187C (read/write) 1132984 1134464 1480 0.1
.bss 168420 168532 112 0.1
.data 3176 3176 0 0.0
.text 961368 962736 1368 0.1
esp32 all-clusters-app c3devkit (read only) 1133882 1135212 1330 0.1
(read/write) 1671004 1671180 176 0.0
.dram0.bss 72432 72544 112 0.2
.dram0.data 12996 12996 0 0.0
.flash.rodata 241704 241768 64 0.0
.flash.text 1133882 1135212 1330 0.1
.iram0.text 75694 75694 0 0.0
m5stack (read only) 1178307 1179687 1380 0.1
(read/write) 520616 520784 168 0.0
.dram0.bss 79064 79176 112 0.1
.dram0.data 34020 34020 0 0.0
.flash.rodata 273168 273224 56 0.0
.flash.text 1172923 1174303 1380 0.1
.iram0.text 123907 123907 0 0.0
k32w contact k32w0+release (read only) 592700 593732 1032 0.2
(read/write) 88088 88144 56 0.1
.bss 71328 71384 56 0.1
.data 2136 2136 0 0.0
.text 592164 593196 1032 0.2
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 688264 689328 1064 0.2
.bss 67528 67584 56 0.1
.data 2720 2720 0 0.0
.text 574536 575544 1008 0.2
light k32w0+release (read only) 592420 593436 1016 0.2
(read/write) 87764 87820 56 0.1
.bss 71016 71072 56 0.1
.data 2124 2124 0 0.0
.text 591884 592900 1016 0.2
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 780148 781236 1088 0.1
.bss 77196 77252 56 0.1
.data 1932 1932 0 0.0
.text 657560 658592 1032 0.2
lock k32w0+release (read only) 564260 565228 968 0.2
(read/write) 85584 85616 32 0.0
.bss 68896 68928 32 0.0
.data 2064 2064 0 0.0
.text 563724 564692 968 0.2
linux air-purifier-app debug (read only) 2507117 2513941 6824 0.3
(read/write) 126832 127024 192 0.2
.bss 46944 46944 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 72408 72600 192 0.3
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 177512 177640 128 0.1
.text 2155013 2161301 6288 0.3
all-clusters-app debug (read only) 5330593 5338633 8040 0.2
(read/write) 429920 430080 160 0.0
.bss 130032 130032 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 288784 288960 176 0.1
.dynamic 624 624 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 1224 1224 0 0.0
.rodata 302652 302780 128 0.0
.text 4639411 4646915 7504 0.2
all-clusters-minimal-app debug (read only) 4932985 4940881 7896 0.2
(read/write) 234440 234600 160 0.1
.bss 127856 127856 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 95648 95824 176 0.2
.dynamic 624 624 0 0.0
.got 5312 5312 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 270861 270989 128 0.0
.text 4430227 4437587 7360 0.2
bridge-app debug (read only) 4405857 4412649 6792 0.2
(read/write) 215680 215872 192 0.1
.bss 119224 119224 0 0.0
.data 4704 4704 0 0.0
.data.rel.ro 85008 85200 192 0.2
.dynamic 624 624 0 0.0
.got 5280 5280 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 218517 218613 96 0.0
.text 3969219 3975507 6288 0.2
chip-tool debug (read only) 10747953 10753601 5648 0.1
(read/write) 465200 465392 192 0.0
.bss 94072 94072 0 0.0
.data 4994 4994 0 0.0
.data.rel.ro 358904 359080 176 0.0
.dynamic 624 624 0 0.0
.got 5784 5784 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 400905 401001 96 0.0
.text 9718243 9723363 5120 0.1
chip-tool-ipv6only arm64 (read only) 10598856 10603832 4976 0.0
(read/write) 531680 530808 -872 -0.2
.bss 103352 103352 0 0.0
.data 4296 4296 0 0.0
.data.rel.ro 396824 397040 216 0.1
.dynamic 512 512 0 0.0
.got 18936 18952 16 0.1
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 325040 325072 32 0.0
.text 9470536 9474936 4400 0.0
lighting-app debug+rpc+ui (read only) 5277009 5284505 7496 0.1
(read/write) 224432 224624 192 0.1
.bss 119168 119168 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 93264 93456 192 0.2
.dynamic 672 672 0 0.0
.got 5896 5896 0 0.0
.init 27 27 0 0.0
.init_array 968 968 0 0.0
.rodata 338196 338292 96 0.0
.text 4694787 4701779 6992 0.1
lock-app debug (read only) 4490377 4497521 7144 0.2
(read/write) 203264 203456 192 0.1
.bss 113632 113632 0 0.0
.data 3648 3648 0 0.0
.data.rel.ro 79256 79432 176 0.2
.dynamic 624 624 0 0.0
.got 5232 5232 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 246517 246645 128 0.1
.text 4034323 4040931 6608 0.2
ota-provider-app debug (read only) 4155017 4161937 6920 0.2
(read/write) 192512 192704 192 0.1
.bss 113632 113632 0 0.0
.data 3920 3920 0 0.0
.data.rel.ro 69040 69216 176 0.3
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 200789 200917 128 0.1
.text 3762803 3769187 6384 0.2
ota-requestor-app debug (read only) 4241273 4248273 7000 0.2
(read/write) 196760 196920 160 0.1
.bss 114656 114656 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 72000 72176 176 0.2
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 204565 204693 128 0.1
.text 3840979 3847443 6464 0.2
shell debug (read only) 2767105 2774873 7768 0.3
(read/write) 149480 149672 192 0.1
.bss 60616 60616 0 0.0
.data 784 784 0 0.0
.data.rel.ro 82272 82456 184 0.2
.dynamic 592 592 0 0.0
.got 4104 4104 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 180768 180896 128 0.1
.text 2416082 2423314 7232 0.3
thermostat-no-ble arm64 (read only) 4392336 4398720 6384 0.1
(read/write) 245864 247720 1856 0.8
.bss 122248 122248 0 0.0
.data 2800 2800 0 0.0
.data.rel.ro 102080 102288 208 0.2
.dynamic 512 512 0 0.0
.got 11944 11960 16 0.1
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 161980 162012 32 0.0
.text 3890680 3896504 5824 0.1
tv-app debug (read only) 5276057 5283137 7080 0.1
(read/write) 345208 345400 192 0.1
.bss 242592 242592 0 0.0
.data 4992 4992 0 0.0
.data.rel.ro 90312 90504 192 0.2
.dynamic 624 624 0 0.0
.got 5520 5520 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 267285 267413 128 0.0
.text 4774131 4780675 6544 0.1
tv-casting-app debug (read only) 8688153 8695113 6960 0.1
(read/write) 322176 322368 192 0.1
.bss 156192 156192 0 0.0
.data 2464 2464 0 0.0
.data.rel.ro 156672 156864 192 0.1
.dynamic 624 624 0 0.0
.got 5064 5064 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 346568 346696 128 0.0
.text 7918099 7924499 6400 0.1
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523728 2524696 968 0.0
.bss 220032 220144 112 0.1
.data 5136 5136 0 0.0
.text 1486412 1487380 968 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1057764 1058828 1064 0.1
bss 128911 129023 112 0.1
rodata 104036 104092 56 0.1
text 777156 778168 1012 0.1
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1184928 1186088 1160 0.1
bss 121133 121245 112 0.1
rodata 138296 138352 56 0.0
text 775172 776168 996 0.1
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1042984 1044176 1192 0.1
bss 129204 129316 112 0.1
rodata 99296 99352 56 0.1
text 766836 767840 1004 0.1
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 836328 836216 -112 -0.0
(read/write) 1737852 1739516 1664 0.1
.bss 194532 194644 112 0.1
.data 2480 2480 0 0.0
.text 1532452 1534004 1552 0.1
all-clusters-minimal cy8ckit_062s2_43012 (read only) 838048 837936 -112 -0.0
(read/write) 1701668 1703340 1672 0.1
.bss 192812 192924 112 0.1
.data 2480 2480 0 0.0
.text 1497988 1499548 1560 0.1
light cy8ckit_062s2_43012 (read only) 844736 844624 -112 -0.0
(read/write) 1627748 1629364 1616 0.1
.bss 186236 186348 112 0.1
.data 2368 2368 0 0.0
.text 1430756 1432260 1504 0.1
lock cy8ckit_062s2_43012 (read only) 817664 817552 -112 -0.0
(read/write) 1654756 1656308 1552 0.1
.bss 213292 213404 112 0.1
.data 2384 2384 0 0.0
.text 1430692 1432132 1440 0.1
qpg lighting-app qpg6105+debug (read/write) 1114288 1115336 1048 0.1
.bss 101152 101208 56 0.1
.data 748 748 0 0.0
.text 626664 627712 1048 0.2
lock-app qpg6105+debug (read/write) 1075596 1076676 1080 0.1
.bss 95920 95976 56 0.1
.data 780 780 0 0.0
.text 587972 589052 1080 0.2
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 817306 818458 1152 0.1
bss 53688 53720 32 0.1
text 610964 612028 1064 0.2
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1075208 1076664 1456 0.1
bss 99956 100068 112 0.1
text 758174 759468 1294 0.2
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1080012 1081468 1456 0.1
bss 109652 109764 112 0.1
text 749760 751046 1286 0.2
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 932288 933568 1280 0.1
bss 94160 94272 112 0.1
text 644702 645814 1112 0.2
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 817426 818570 1144 0.1
bss 53740 53772 32 0.1
text 611180 612232 1052 0.2
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 971520 972724 1204 0.1
bss 77548 77580 32 0.0
text 689154 690264 1110 0.2
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1089900 1091284 1384 0.1
bss 99724 99836 112 0.1
text 766890 768112 1222 0.2
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 958216 959416 1200 0.1
bss 95812 95844 32 0.0
text 643158 644270 1112 0.2
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 945496 946808 1312 0.1
bss 92268 92380 112 0.1
text 660370 661516 1146 0.2
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 873788 874940 1152 0.1
bss 67576 67608 32 0.0
text 617582 618646 1064 0.2
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 814472 815624 1152 0.1
bss 55812 55844 32 0.1
text 584536 585600 1064 0.2
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 705268 705404 136 0.0
bss 73588 73588 0 0.0
text 461802 461922 120 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 819150 820302 1152 0.1
bss 53824 53856 32 0.1
text 613904 614964 1060 0.2
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 871177 872377 1200 0.1
bss 59288 59320 32 0.1
text 625888 626998 1110 0.2
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 838524 839660 1136 0.1
bss 56108 56140 32 0.1
text 602702 603754 1052 0.2
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 833024 834160 1136 0.1
bss 56460 56492 32 0.1
text 596930 597982 1052 0.2

@woody-apple woody-apple added this to the 1.3 Feature Complete milestone Nov 27, 2023
@tehampson tehampson mentioned this pull request Nov 27, 2023
Merged
bzbarsky-apple
bzbarsky-apple reviewed Nov 27, 2023
View reviewed changes
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
src/app/CommandHandler.cpp Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/CommandPathRegistry.h Show resolved Hide resolved
src/app/CommandPathRegistry.h Outdated Show resolved Hide resolved
src/app/CommandHandler.h Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple reviewed Nov 29, 2023
View reviewed changes
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/CommandHandler.h Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/CommandHandler.h Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple approved these changes Nov 29, 2023
View reviewed changes
src/app/CommandHandler.h Outdated Show resolved Hide resolved
src/app/CommandHandler.h Outdated Show resolved Hide resolved
@tehampson @bzbarsky-apple
Apply suggestions from code review
4a11ebd 
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@tehampson tehampson enabled auto-merge (squash) November 29, 2023 23:22
@tehampson tehampson merged commit ce4befc into project-chip:master Nov 30, 2023
57 checks passed
@tehampson tehampson mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@robszewczyk robszewczyk robszewczyk approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved tests
Projects
[1.3] SDK Feature Complete
Status: Done
Milestone
1.3 Feature Complete
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tehampson @tcarmelveilleux @robszewczyk @bzbarsky-apple @woody-apple