[Python] Eliminate ZCLReadAttribute/ZCLSend #33428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agners
force-pushed
the
eliminate-zclreadattribute
branch
from
5d94829
to
b8fc7e3
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
kpschoedel
|
PR #33428: Size comparison from 0180ee6 to b8fc7e3 Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33428: Size comparison from 0180ee6 to e8336e5 Increases above 0.2%:
Increases (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
Decreases (4 builds for psoc6)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
Afaict, the Darwin Tests failure are unrelated to this change (also happen on master from time to time). |
tehampson
approved these changes
May 14, 2024
Remove ZCLReadAttribute and ZCLSend API use from the level control test TestLevelControlCluster and convert to asyncio.
Remove ZCLReadAttribute API use from basic information cluster test and convert to use asyncio.
Avoid using ZCLSend API instead use SendCommand directly in the send_zcl_command helper function.
Remove ZCLSend API usage and call SendCommand directly. Also convert the test to a test using asyncio.
Remove ZCLSend API usage and call SendCommand directly. Also convert the test to a test using asyncio.
The class is no longer required. Test results are tested directly.
agners
force-pushed
the
eliminate-zclreadattribute
branch
from
e8336e5
to
e434f78
Compare
agners
force-pushed
the
eliminate-zclreadattribute
branch
from
e434f78
to
138a686
Compare
|
PR #33428: Size comparison from 878fbb7 to 138a686 Decreases (2 builds for efr32)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
It seems TestWriteBasicAttributes did not correctly write the attributes. The broad exception handling seems to have hidden this issue even. Make sure the attributes with the correct value get written, and check for unexpected and expected IM errors in the per-attribute results specifically.
|
PR #33428: Size comparison from 878fbb7 to fd30b24 Increases (3 builds for linux)
Decreases (3 builds for efr32, linux)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33428: Size comparison from 878fbb7 to 90c50e4 Increases (16 builds for bl602, bl702, bl702l, linux, nrfconnect, nxp)
Decreases (19 builds for bl702l, efr32, esp32, linux)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
|
PR #33428: Size comparison from 878fbb7 to 33cedd7 Increases (16 builds for bl602, bl702, bl702l, linux, nrfconnect, nxp)
Decreases (19 builds for bl702l, efr32, esp32, linux)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
cecille
reviewed
May 15, 2024
cecille
approved these changes
May 15, 2024
Yes, along with |
fessehaeve
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates use of ZCLReadAttribute and ZCLSend and improves some tests using asyncio.