dac revocation: Default implementation to check if DAC chain is revoked #33651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
kpschoedel
|
PR #33651: Size comparison from 8306353 to f9fad81 Increases above 0.2%:
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 24, 2024
|
@tcarmelveilleux @andy31415 Can you please review and approve this if it looks okay? We are hoping that this gets merged before the 1.4.TE2 deadline |
src/credentials/attestation_verifier/DefaultDeviceAttestationVerifier.h
Outdated
Show resolved
Hide resolved
src/credentials/attestation_verifier/TestDACRevocationDelegateImpl.cpp
Outdated
Show resolved
Hide resolved
src/credentials/attestation_verifier/TestDACRevocationDelegateImpl.cpp
Outdated
Show resolved
Hide resolved
src/credentials/attestation_verifier/TestDACRevocationDelegateImpl.cpp
Outdated
Show resolved
Hide resolved
src/credentials/attestation_verifier/TestDACRevocationDelegateImpl.cpp
Outdated
Show resolved
Hide resolved
tcarmelveilleux
approved these changes
Jul 29, 2024
This was referenced Jul 29, 2024
|
Broke python tests on HEAD |
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…ed (project-chip#33651) * dac revocation: default implementation of CheckForRevokedDACChain * option to configure the revocation set file in chip-tool * Added few comments * restyle * add fstream to allow list of DefaultDeviceAttestationVerifier * Address comments Added an interface for device attestation revocation and the test implementation for the same. * error code if dac and pai both are revoked * unit tests * Update examples/chip-tool/commands/common/CredentialIssuerCommands.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Move setting of revocation delegate to default verifier * factor out getting of revocation delegate * Restyled by clang-format * address reviews * API to clear revocation set path, and minor cleanup and added a comment to explain the usage of --dac-revocation-set-path argument * Restyled by clang-format * add some details about json schema * Restyled by whitespace * Add the help text in the argument * Address review comments and added some TODOs --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Restyled.io <commits@restyled.io>
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
…ed (project-chip#33651) * dac revocation: default implementation of CheckForRevokedDACChain * option to configure the revocation set file in chip-tool * Added few comments * restyle * add fstream to allow list of DefaultDeviceAttestationVerifier * Address comments Added an interface for device attestation revocation and the test implementation for the same. * error code if dac and pai both are revoked * unit tests * Update examples/chip-tool/commands/common/CredentialIssuerCommands.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Move setting of revocation delegate to default verifier * factor out getting of revocation delegate * Restyled by clang-format * address reviews * API to clear revocation set path, and minor cleanup and added a comment to explain the usage of --dac-revocation-set-path argument * Restyled by clang-format * add some details about json schema * Restyled by whitespace * Add the help text in the argument * Address review comments and added some TODOs --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33124
Fixes #33652
Change overview
credentials/generate-revocation-set.pyusing jsoncpp.Testing
--dac-revocation-set-pathoption.--dac-revocation-set-path, verified with revoked as well as not revoked test dataset.