Add Thread Border Router Management cluster server implementation and Generic Thread BR delegate #33872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
kpschoedel
…oningWindowManager
…ctedhomeip into thread-br-mgmt/server
|
PR #33872: Size comparison from e73be38 to 3bcd93e Full report (42 builds for bl602, bl702, bl702l, cc32xx, cyw30739, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #33872: Size comparison from e62582e to 93b7744 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33872: Size comparison from 3bc5667 to fc02deb Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Jul 29, 2024
This was referenced Jul 29, 2024
|
PR #33872: Size comparison from 37fc757 to 605b1ae Full report (4 builds for cc32xx, mbed, stm32)
|
Update the code as `chip::app::InteractionModelEngine::RegisterCommandHandler` is now replaced by `chip::app::CommandHandlerInterfaceRegistry::RegisterCommandHandler`
|
PR #33872: Size comparison from 37fc757 to e13880a Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
… Generic Thread BR delegate (project-chip#33872) * Add Thread Border Router Management cluster server implementation and ESP32 delegate * Restyled by clang-format * Fix compile error for external platform and mark thread-br-management cluster provisional * remove the topology request and response command and fix the id of activedatasettimestamp * review changes * move the border router delegate to generic directory * Restyled by clang-format * remove the duplicate thread br management cluster in controller zap * Ensure that the Get dataset response failure status matches the spec * add the document for ActivateDatasetCallback * Update GenericThreadBorderRouterDelegate and add the function description for thread-br-delegate * Restyled by clang-format * Add unit test * Restyled by clang-format * Restyled by gn * Update src/app/clusters/thread-border-router-management-server/thread-br-delegate.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/clusters/thread-border-router-management-server/thread-br-delegate.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/clusters/thread-border-router-management-server/thread-br-delegate.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/clusters/thread-border-router-management-server/thread-br-delegate.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * add logic of no callbacks for an activate-before-revert happening after the revert * fix clang tidy error * rename the delegate implementation class * Restyled by clang-format * Try to fix CI tests * some review changes * Restyled by clang-format * rename the source files * review changes * some review changes * Restyled by clang-format * review changes from marius * review changes * add commissioning complete action * Restyled by clang-format * Only build TestThreadBorderRouterManagementCluster for no-fake platform * fix committing active dataset configured * add attribute change report logic * Restyled by clang-format * Don't build TestThreadBorderRouterManagementCluster with TestCommissioningWindowManager * review changes * Restyled by clang-format * regenerate zap * Fix the compilation error Update the code as `chip::app::InteractionModelEngine::RegisterCommandHandler` is now replaced by `chip::app::CommandHandlerInterfaceRegistry::RegisterCommandHandler` * Update thread-border-router-management-server.cpp * Update thread-border-router-management-server.cpp * Change the sequence of the header file inclusion --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Hrishikesh Dhayagude <dhrishi@users.noreply.github.com>
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Jul 31, 2024
… Generic Thread BR delegate (project-chip#33872) * Add Thread Border Router Management cluster server implementation and ESP32 delegate * Restyled by clang-format * Fix compile error for external platform and mark thread-br-management cluster provisional * remove the topology request and response command and fix the id of activedatasettimestamp * review changes * move the border router delegate to generic directory * Restyled by clang-format * remove the duplicate thread br management cluster in controller zap * Ensure that the Get dataset response failure status matches the spec * add the document for ActivateDatasetCallback * Update GenericThreadBorderRouterDelegate and add the function description for thread-br-delegate * Restyled by clang-format * Add unit test * Restyled by clang-format * Restyled by gn * Update src/app/clusters/thread-border-router-management-server/thread-br-delegate.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/clusters/thread-border-router-management-server/thread-br-delegate.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/clusters/thread-border-router-management-server/thread-br-delegate.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/clusters/thread-border-router-management-server/thread-br-delegate.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * add logic of no callbacks for an activate-before-revert happening after the revert * fix clang tidy error * rename the delegate implementation class * Restyled by clang-format * Try to fix CI tests * some review changes * Restyled by clang-format * rename the source files * review changes * some review changes * Restyled by clang-format * review changes from marius * review changes * add commissioning complete action * Restyled by clang-format * Only build TestThreadBorderRouterManagementCluster for no-fake platform * fix committing active dataset configured * add attribute change report logic * Restyled by clang-format * Don't build TestThreadBorderRouterManagementCluster with TestCommissioningWindowManager * review changes * Restyled by clang-format * regenerate zap * Fix the compilation error Update the code as `chip::app::InteractionModelEngine::RegisterCommandHandler` is now replaced by `chip::app::CommandHandlerInterfaceRegistry::RegisterCommandHandler` * Update thread-border-router-management-server.cpp * Update thread-border-router-management-server.cpp * Change the sequence of the header file inclusion --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Hrishikesh Dhayagude <dhrishi@users.noreply.github.com>
GabrielCouturier
pushed a commit
to NXP/matter
that referenced
this pull request
Aug 2, 2024
…elagate implementation This commit is created from Matter upstream PR project-chip#33872.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 2 of #33609