[Python] Drop unnecessary null termination #33915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ctypes data type `c_char_p` takes care of null-terminating the byte array provided to it. The additional null termination doesn't hurt in practice, but it's unnecessary.
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel and
ksperling-apple
pullapprove
bot
requested review from
nivi-apple,
p0fi,
plauric,
rcasallas-silabs,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
This StackOverflow comment mentions that the implicitly called z_set function calls PyBytes_AsString which takes care of null termination, from the
I've verified this to be the case by checking what is present at memory address Additionally, we do have places where "manual" null-termination hasn't been applied, and it seemd to have worked too. |
|
PR #33915: Size comparison from a3bb9c3 to b2f627a Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Jun 14, 2024
Damian-Nordic
approved these changes
Jun 14, 2024
tcarmelveilleux
approved these changes
Jun 14, 2024
agners
added a commit
to home-assistant-libs/chip-wheels
that referenced
this pull request
Jun 17, 2024
This adds more cleanups from the master branch to keep our 1.3 based branch close to upstream. Most noteworthy here are a patch which stops mDNS discovery when using the on-network commissioning API, fixes when commissioning using WiFi/Thread setup through BLE directly (the Python Matter Server isn't using this APIs currently), dropping unnecessary code and and general messaging cleanup. Specifically, this integrates changes from the following PRs - project-chip/connectedhomeip#33882 - project-chip/connectedhomeip#33896 - project-chip/connectedhomeip#33891 - project-chip/connectedhomeip#33880 - project-chip/connectedhomeip#33914 - project-chip/connectedhomeip#33915 - project-chip/connectedhomeip#33933
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ctypes data type
c_char_ptakes care of null-terminating the byte array provided to it. The additional null termination doesn't hurt in practice, but it's unnecessary.