Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add home location to basic information xml #34208

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add home location to basic information xml #34208

wants to merge 7 commits into from

Conversation

hicklin
Copy link
Contributor

@hicklin hicklin commented Jul 5, 2024 •
edited
Loading

Fixes part of #33568.

Adds the DeviceLocation attribute to the Basic Information cluster. This PR also adds the AreaTypeTag and HomeLocationStruct to the basic information cluster as these are needed by the DeviceLocation attribute.

This PR generates files following the changes in XML files described above.

@hicklin
Added the AreaTypeTag and HomeLocationStruct to the BasicInformation …
f6c3635 
…namespace. Added the DeviceLocation attribute to the basic infromation cluster.
@hicklin
Regenerated zap files
024714e
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

PR #34208: Size comparison from 6e31453 to f9f8d2d

Increases above 0.2%:

platform target config section 6e31453 f9f8d2d change % change
linux all-clusters-app debug RAM 490864 494064 3200 0.7
chip-tool debug RAM 543610 547226 3616 0.7
chip-tool-ipv6only arm64 RAM 592416 596032 3616 0.6
fabric-admin debug RAM 540450 544066 3616 0.7
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 6e31453 f9f8d2d change % change
bl602 lighting-app bl602 FLASH 1271026 1271026 0 0.0
RAM 95328 95328 0 0.0
bl602+mfd FLASH 1285284 1285284 0 0.0
RAM 95472 95472 0 0.0
bl602+rpc FLASH 1309986 1309986 0 0.0
RAM 103752 103752 0 0.0
bl702 lighting-app bl702 FLASH 1091924 1091924 0 0.0
RAM 15265 15265 0 0.0
bl702+mfd FLASH 1102618 1102618 0 0.0
RAM 15417 15417 0 0.0
bl702+rpc FLASH 1181734 1181734 0 0.0
RAM 24285 24285 0 0.0
bl706-eth FLASH 875196 875196 0 0.0
RAM 27376 27376 0 0.0
bl706-wifi FLASH 1127270 1127270 0 0.0
RAM 14709 14709 0 0.0
bl702l lighting-app bl702l FLASH 1078806 1078806 0 0.0
RAM 21836 21836 0 0.0
bl702l+mfd FLASH 1090068 1090068 0 0.0
RAM 21996 21996 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 797972 797972 0 0.0
RAM 109180 109180 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 816000 816000 0 0.0
RAM 116956 116956 0 0.0
lock-mtd LP_EM_CC1354P10_6 FLASH 807452 807452 0 0.0
RAM 111236 111236 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 760308 760308 0 0.0
RAM 105336 105336 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 746036 746036 0 0.0
RAM 105576 105576 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 605706 605706 0 0.0
RAM 204508 204508 0 0.0
lock CC3235SF_LAUNCHXL FLASH 650734 650734 0 0.0
RAM 204780 204780 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 667113 667113 0 0.0
RAM 77644 77644 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 686957 686957 0 0.0
RAM 80276 80276 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 686957 686957 0 0.0
RAM 80276 80276 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 643901 643901 0 0.0
RAM 72712 72712 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 608745 608745 0 0.0
RAM 70804 70804 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 628389 628389 0 0.0
RAM 73348 73348 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 628389 628389 0 0.0
RAM 73348 73348 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 624273 624273 0 0.0
RAM 73820 73820 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 643989 643989 0 0.0
RAM 76364 76364 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 643989 643989 0 0.0
RAM 76364 76364 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 592845 592845 0 0.0
RAM 67788 67788 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 612689 612689 0 0.0
RAM 70428 70428 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 612689 612689 0 0.0
RAM 70428 70428 0 0.0
efr32 lighting-app BRD4187C FLASH 924208 924208 0 0.0
RAM 137516 137516 0 0.0
lock-app BRD4338a FLASH 733068 733068 0 0.0
RAM 207996 207996 0 0.0
window-app BRD4187C FLASH 1012016 1012016 0 0.0
RAM 129620 129620 0 0.0
esp32 all-clusters-app c3devkit DRAM 90860 90860 0 0.0
FLASH 1468736 1468736 0 0.0
IRAM 75570 75570 0 0.0
m5stack DRAM 117412 117412 0 0.0
FLASH 1537631 1537619 -12 -0.0
IRAM 125403 125403 0 0.0
linux air-purifier-app debug unknown 4592 4592 0 0.0
FLASH 2529008 2529008 0 0.0
RAM 125072 125072 0 0.0
all-clusters-app debug unknown 5368 5368 0 0.0
FLASH 5588686 5588718 32 0.0
RAM 490864 494064 3200 0.7
all-clusters-minimal-app debug unknown 5288 5288 0 0.0
FLASH 5060696 5060696 0 0.0
RAM 235488 235488 0 0.0
bridge-app debug unknown 5256 5256 0 0.0
FLASH 4477208 4477208 0 0.0
RAM 212744 212744 0 0.0
chip-tool debug unknown 5728 5728 0 0.0
FLASH 11720407 11733063 12656 0.1
RAM 543610 547226 3616 0.7
chip-tool-ipv6only arm64 unknown 20008 20032 24 0.1
FLASH 10835356 10848236 12880 0.1
RAM 592416 596032 3616 0.6
fabric-admin debug unknown 5616 5616 0 0.0
FLASH 10804871 10817543 12672 0.1
RAM 540450 544066 3616 0.7
fabric-bridge-app debug unknown 4528 4528 0 0.0
FLASH 4242760 4242760 0 0.0
RAM 198808 198808 0 0.0
lighting-app debug+rpc+ui unknown 5936 5936 0 0.0
FLASH 5381570 5381570 0 0.0
RAM 224096 224096 0 0.0
lock-app debug unknown 5192 5192 0 0.0
FLASH 4540776 4540776 0 0.0
RAM 200240 200240 0 0.0
ota-provider-app debug unknown 4576 4576 0 0.0
FLASH 4196616 4196616 0 0.0
RAM 194520 194520 0 0.0
ota-requestor-app debug unknown 4512 4512 0 0.0
FLASH 4322152 4322152 0 0.0
RAM 199176 199176 0 0.0
shell debug unknown 4112 4112 0 0.0
FLASH 2803773 2803773 0 0.0
RAM 153000 153000 0 0.0
thermostat-no-ble arm64 unknown 9144 9144 0 0.0
FLASH 4167132 4167132 0 0.0
RAM 235640 235640 0 0.0
tv-app debug unknown 5472 5472 0 0.0
FLASH 5604696 5604696 0 0.0
RAM 341760 341760 0 0.0
tv-casting-app debug unknown 5096 5096 0 0.0
FLASH 9889950 9902974 13024 0.1
RAM 400816 401360 544 0.1
mbed lock-app-release cy8cproto_062_4343w FLASH 1502292 1502292 0 0.0
RAM 226640 226640 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 882144 882144 0 0.0
RAM 142109 142109 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 952748 952748 0 0.0
RAM 140537 140537 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 827748 827748 0 0.0
RAM 141023 141023 0 0.0
nxp contact k32w0+release FLASH 575916 575916 0 0.0
RAM 70004 70004 0 0.0
k32w1+release FLASH 591144 591144 0 0.0
RAM 74056 74056 0 0.0
light k32w0+release FLASH 610016 610016 0 0.0
RAM 69480 69480 0 0.0
k32w1+release FLASH 674728 674728 0 0.0
RAM 82816 82816 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1614804 1614804 0 0.0
RAM 209692 209692 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1535700 1535700 0 0.0
RAM 206580 206580 0 0.0
light cy8ckit_062s2_43012 FLASH 1462348 1462348 0 0.0
RAM 199852 199852 0 0.0
lock cy8ckit_062s2_43012 FLASH 1462828 1462828 0 0.0
RAM 224380 224380 0 0.0
qpg lighting-app qpg6105+debug FLASH 651052 651052 0 0.0
RAM 104560 104560 0 0.0
lock-app qpg6105+debug FLASH 611168 611168 0 0.0
RAM 99228 99228 0 0.0
stm32 light STM32WB5MM-DK FLASH 473376 473376 0 0.0
RAM 144204 144204 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 632484 632484 0 0.0
RAM 50424 50424 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 658250 658250 0 0.0
RAM 148296 148296 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 778648 778648 0 0.0
RAM 113116 113116 0 0.0
bridge-app tlsr9258a FLASH 675470 675470 0 0.0
RAM 95200 95200 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 634068 634068 0 0.0
RAM 50468 50468 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 719858 719858 0 0.0
RAM 77044 77044 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 613438 613438 0 0.0
RAM 144532 144532 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 801224 801224 0 0.0
RAM 102936 102936 0 0.0
lock-app-dfu tlsr9528a FLASH 665632 665632 0 0.0
RAM 69756 69756 0 0.0
ota-requestor-app tlsr9258a FLASH 694800 694800 0 0.0
RAM 94924 94924 0 0.0
pump-app tlsr9518adk80d FLASH 616332 616332 0 0.0
RAM 56848 56848 0 0.0
pump-controller-app tlsr9518adk80d FLASH 606716 606716 0 0.0
RAM 56648 56648 0 0.0
shell tlsr9518adk80d FLASH 466150 466150 0 0.0
RAM 72460 72460 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 640682 640682 0 0.0
RAM 52096 52096 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 650542 650542 0 0.0
RAM 60284 60284 0 0.0
thermostat tlsr9518adk80d FLASH 625606 625606 0 0.0
RAM 56980 56980 0 0.0
window-covering tlsr9118bdk40d FLASH 518832 518832 0 0.0
RAM 97696 97696 0 0.0
tizen all-clusters-app arm unknown 1584 1584 0 0.0
FLASH 1637576 1637576 0 0.0
RAM 48540 48540 0 0.0
chip-tool-ubsan arm unknown 2384 2384 0 0.0
FLASH 16168382 16178070 9688 0.1
RAM 7103620 7112476 8856 0.1

@hicklin hicklin marked this pull request as ready for review July 9, 2024 11:32
@hicklin hicklin mentioned this pull request Jul 10, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller darwin examples review - pending
Projects
[Platform] Darwin
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hicklin