Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing openSSL based ECDH implementation #420 #494

Merged
merged 10 commits into from Apr 28, 2020
Merged

Missing openSSL based ECDH implementation #420 #494

merged 10 commits into from Apr 28, 2020

Conversation

bhaskar-apple
Copy link
Contributor

Problem

Implement ECDH

fixes #420

@bhaskar-apple bhaskar-apple marked this pull request as ready for review April 24, 2020 00:55
@bhaskar-apple
Copy link
Contributor Author

@balducci-apple , @emargolis , @dougsteed

@gerickson
Copy link
Contributor

@emargolis, @dougsteed, @roydsouza

@restyled-io restyled-io bot mentioned this pull request Apr 24, 2020
Closed
emargolis
emargolis reviewed Apr 24, 2020
View reviewed changes
src/crypto/CHIPCryptoPALOpenSSL.cpp Outdated Show resolved Hide resolved
src/crypto/tests/CHIPCryptoPALTest.cpp Outdated Show resolved Hide resolved
src/crypto/CHIPCryptoPALOpenSSL.cpp Show resolved Hide resolved
src/crypto/CHIPCryptoPAL.h Show resolved Hide resolved
emargolis
emargolis reviewed Apr 27, 2020
View reviewed changes
src/crypto/tests/CHIPCryptoPALTest.cpp Outdated Show resolved Hide resolved
src/crypto/CHIPCryptoPAL.h Outdated Show resolved Hide resolved
src/crypto/CHIPCryptoPALOpenSSL.cpp Show resolved Hide resolved
@restyled-io restyled-io bot mentioned this pull request Apr 27, 2020
Closed
@restyled-io restyled-io bot mentioned this pull request Apr 28, 2020
Closed
@woody-apple woody-apple merged commit 434681e into project-chip:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougsteed dougsteed dougsteed left review comments

@gerickson gerickson gerickson approved these changes

@emargolis emargolis emargolis approved these changes

@woody-apple woody-apple woody-apple approved these changes

@jelderton jelderton jelderton approved these changes

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@tpmanley tpmanley Awaiting requested review from tpmanley

@saurabhst saurabhst Awaiting requested review from saurabhst

@roydsouza roydsouza Awaiting requested review from roydsouza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing openSSL based ECDH implementation
8 participants
@bhaskar-apple @gerickson @emargolis @woody-apple @dougsteed @jelderton @Bhaskar-Sarma @restyled-commits