Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32: Fixes for README.md #7391

Merged
merged 1 commit into from
Jun 4, 2021
Merged

ESP32: Fixes for README.md #7391

merged 1 commit into from
Jun 4, 2021

Conversation

sweetymhaiske
Copy link
Contributor

Problem

  • Fixes for README.md for esp32.

Change overview

Fixes.

Testing

  • Checked the modified commands.

bzbarsky-apple
bzbarsky-apple approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dhrishi
Copy link
Contributor

dhrishi commented Jun 4, 2021

@sweetymhaiske In the same PR, can you please add any missing clusters those were present in all-clusters-app component.mk and not reflected in CMakeLists.txt. Let us make sure that nothing is missed

@sweetymhaiske
Copy link
Contributor Author

@sweetymhaiske In the same PR, can you please add any missing clusters those were present in all-clusters-app component.mk and not reflected in CMakeLists.txt. Let us make sure that nothing is missed

@dhrishi Done. Thanks.

@dhrishi
Copy link
Contributor

dhrishi commented Jun 4, 2021

Thanks. And one more thing, we had added such text in ESP32 example component.mk:
# The list of extra component dirs must be in sync with that in all-clusters-app/esp32/Makefile

You can safely remove that now from all the examples.

@dhrishi dhrishi self-requested a review June 4, 2021 13:49
@sweetymhaiske
Copy link
Contributor Author

Thanks. And one more thing, we had added such text in ESP32 example component.mk:
# The list of extra component dirs must be in sync with that in all-clusters-app/esp32/Makefile

You can safely remove that now from all the examples.

Done

@woody-apple woody-apple merged commit 6539cae into project-chip:master Jun 4, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
@sweetymhaiske
ESP32: Fixes for README.md (project-chip#7391)
d000ff5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhrishi dhrishi dhrishi approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@jelderton jelderton Awaiting requested review from jelderton

@LuDuda LuDuda Awaiting requested review from LuDuda

@mspang mspang Awaiting requested review from mspang

@saurabhst saurabhst Awaiting requested review from saurabhst

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sweetymhaiske @dhrishi @bzbarsky-apple @Damian-Nordic @jmartinez-silabs @woody-apple