Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESP32]fix get wrong MAC on SoftAP mode #7777

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

wqx6
Copy link
Contributor

@wqx6 wqx6 commented Jun 21, 2021

Problem

The hostname is wrong when the Rendezvous Mode is SoftAP because GetPrimaryWiFiMACAddress gets wrong MAC.

Change overview

Fix above problem

Testing

Tested manually with avahi-browse after connecting the SoftAP.

@chshu
Copy link
Contributor

chshu commented Jun 21, 2021

Required to pass TE3 3.4.1 step5.

@wqx6 wqx6 force-pushed the random_hostname_SoftAP_mode branch from 502cbd7 to 3c0ae9d Compare June 22, 2021 05:13
@wqx6 wqx6 force-pushed the random_hostname_SoftAP_mode branch 2 times, most recently from f677caf to eba85a8 Compare June 22, 2021 08:19
@wqx6 wqx6 force-pushed the random_hostname_SoftAP_mode branch from eba85a8 to 0ac2248 Compare June 23, 2021 02:26
@github-actions
Copy link

Size increase report for "esp32-example-build" from 90592a7

File Section File VM
chip-all-clusters-app.elf .flash.text 84 84
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,564
.debug_line,0,140
.flash.text,84,84
.debug_str,0,80
.strtab,0,66
.debug_abbrev,0,60
.debug_loc,0,52
.debug_ranges,0,32
.debug_frame,0,24
.symtab,0,16
.debug_aranges,0,8
.shstrtab,0,2

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize


@woody-apple woody-apple merged commit 7eca8fc into project-chip:master Jun 23, 2021
@wqx6 wqx6 deleted the random_hostname_SoftAP_mode branch June 30, 2021 11:10
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants