-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do a better job of not suppressing rejected promises in ZAP helpers. #8839
Merged
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:propagate-zap-errors-better
Aug 11, 2021
Merged
Do a better job of not suppressing rejected promises in ZAP helpers. #8839
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:propagate-zap-errors-better
Aug 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinh0
approved these changes
Aug 6, 2021
bzbarsky-apple
force-pushed
the
propagate-zap-errors-better
branch
from
August 6, 2021 21:52
ad710aa
to
8d6125b
Compare
There are two fundamental changes here: 1) Make Clusters.init actually reject this.ready on errors. 2) Make the various catch() bits we have re-throw the error after logging. The only reason we need these at all is that there are outstanding ZAP bugs that end up suppressing these errors somewhere, so if we don't log them we don't notice them happening at all.
bzbarsky-apple
force-pushed
the
propagate-zap-errors-better
branch
from
August 6, 2021 22:39
8d6125b
to
a7f66fc
Compare
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
kedars,
msandstedt and
woody-apple
August 6, 2021 22:40
Size increase report for "esp32-example-build" from 075a974
Full report output
|
msandstedt
approved these changes
Aug 9, 2021
woody-apple
approved these changes
Aug 11, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…roject-chip#8839) There are two fundamental changes here: 1) Make Clusters.init actually reject this.ready on errors. 2) Make the various catch() bits we have re-throw the error after logging. The only reason we need these at all is that there are outstanding ZAP bugs that end up suppressing these errors somewhere, so if we don't log them we don't notice them happening at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two fundamental changes here:
Make Clusters.init actually reject this.ready on errors.
Make the various catch() bits we have re-throw the error after
logging. The only reason we need these at all is that there are
outstanding ZAP bugs that end up suppressing these errors
somewhere, so if we don't log them we don't notice them happening
at all.
Problem
We are suppressing some errors when we should not.
Change overview
Make sure to propagate them.
Testing
Tried adding various exceptions to the code and ensured that they got logged better, and in some cases failed codegen when we used to not fail it.