Crypto key refactor #255
Merged
Crypto key refactor #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace key handling with a JS implementation that converts keys to standard JWK Key format. Streamlines the Crypto.ts API and removes the various formats and hacks we previously used to pass keys to Node's OpenSSL wrapper. fixes project-chip#212 could be considered phase 1 of project-chip#122
lauckhart
force-pushed
the
jwk
branch
4 times, most recently
from
b54783f
to
6c4e685
Compare
Apollon77
approved these changes
Aug 7, 2023
packages/matter-node.js/test/cluster/ClusterServerTestingUtil.ts
Outdated
Show resolved
Hide resolved
Apollon77
reviewed
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace key handling with a JS implementation that converts keys to standard JWK Key format. Streamlines the Crypto.ts API and removes the various formats and hacks we previously used to pass keys to Node's OpenSSL wrapper.
fixes #212
could be considered phase 1 of #122