Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to stable Rust, remove the nightly feature #119

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

ivmarkov
Copy link
Contributor

@ivmarkov ivmarkov commented Jan 5, 2024

On Dec 28, Rust 1.75 was released which finally allows using async traits with the stable compiler.

Therefore, this PR removes the nightly feature flag which used to protect all async traits defined in the rs-matter crate.

We no longer need a nightly compiler, yay!

There is an upcoming bigger, subsequent PR which - besides updating a few dependencies - will also introduce the embedded-nal-async crate into the codebase, which would - in turn - allow us to get rid of the hard-coded UDP stack implementations based on async-io and embassy-net, and therefore remove the async-io and embassy-net as dependencies.

  • embassy-net does implement the embedded-nal-async traits directly
  • The Rust STD socket layer is adapted to the embedded-nal-async traits by the std-embedded-nal-async crate, but we do not have to depend on it directly, of course. Users can pick and choose.

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2024

CLA assistant check
All committers have signed the CLA.

@kedars kedars merged commit 370035e into project-chip:main Jan 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants