Support for BLE and BTP #155
Conversation
ivmarkov
force-pushed
the
ble
branch
9 times, most recently
from
988b3f5
to
db90bea
Compare
ivmarkov
force-pushed
the
ble
branch
4 times, most recently
from
85fa2a0
to
a2e0afb
Compare
ivmarkov
force-pushed
the
ble
branch
5 times, most recently
from
4f1adde
to
27a35b7
Compare
ivmarkov
force-pushed
the
ble
branch
9 times, most recently
from
70eea79
to
82b220a
Compare
|
Forgot to say: this code is all new in that it does not touch/change pre-existing metaphors. Everything necessary to implement pluggable protocols (today - BTP, tomorrow - TCP) had been merged already. |
ivmarkov
force-pushed
the
ble
branch
7 times, most recently
from
0fb0300
to
7f4e437
Compare
|
@andreilitvin Many thanks for the code review so far!
|
|
Oh - I also pushed-back on our favorite "Copyright headers" topic from before (and did mark it as "Resolved"), but really - let's first agree on what to do, and then do a one-pass regexp on all of it. Until then, I keep all headers the same, so the regexp has an easier time operating. |
ivmarkov
force-pushed
the
ble
branch
3 times, most recently
from
4e5dc6a
to
343c035
Compare
Fix CI to install libdbus Fix a few typos in doc comments MAX_BTP_SESSIONS needs to be public Clone for the callback Compute MTU more precisely, also based on the reported GATT MTU mut and ref standard impls for GattPeripheral WIP: unit tests More unit tests Move unit tests to separate file More unit tests work More unit tests work More unit tests work
Co-authored-by: Andrei Litvin <andy314@gmail.com>
Co-authored-by: Andrei Litvin <andy314@gmail.com>
|
@andy31415 What do you think we might still need to do for this PR to land? There are a few open items (primarily w.r.t. naming) that I feel we should not really address, but please push back if you feel otherwise. Anything else outstanding? |
|
CSA member meeting caused a bit of a delay. I expect to get some time for one more pass tomorrow, expect it to check mark it then. Sorry for the delay. |
Currently runs on Linux/BlueZ only, but adding support for another BLE stack should be easy (user needs to implement the
GattPeripheraltrait - and - we might add out of the box BLE/GATT box implementations tors-matterover time, as we did for mDNS).Keeping as Draft for now, as the code needs to be tested on MCUs (doing this just now with ESP-IDF + Bluedroid) and needs unit tests.