Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for a breaking change in the Rust compiler. #98

Closed
wants to merge 1 commit into from

Conversation

oli-obk
Copy link

@oli-obk oli-obk commented Sep 21, 2023

The soundness fix in rust-lang/rust#115008 will cause rs-matter to break, even though it is not unsound. The missing bound is very hard to abuse, but still a soundness hole in our type system.

It will likely take 12 weeks before a stable compiler with the soundness fix is shipped.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

The soundness fix in rust-lang/rust#115008 will cause rs-matter to break, even though it is not unsound. The missing bound is very hard to abuse, but still a soundness hole in our type system.

It will likely take 12 weeks before a stable compiler with the soundness fix is shipped.
@oli-obk
Copy link
Author

oli-obk commented Sep 21, 2023

The change is trivial enough (and proposed by the Rust compiler, not actually written by me). It is not complex enough to need a license, so if you want you can just copy this code yourself without a license.

ivmarkov added a commit to ivmarkov/rs-matter that referenced this pull request Sep 25, 2023
kedars added a commit that referenced this pull request Sep 25, 2023
@ivmarkov
Copy link
Contributor

@kedars We can close this one now that #99 is merged.

@kedars kedars closed this Sep 25, 2023
@oli-obk oli-obk deleted the breakage_fix branch September 25, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants