Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ranges not being generated by zap #209

Closed
chrisbeach59 opened this issue Aug 24, 2021 · 4 comments
Closed

Ranges not being generated by zap #209

chrisbeach59 opened this issue Aug 24, 2021 · 4 comments

Comments

@chrisbeach59
Copy link

Problem
Thermostat.xml file contains the min and max values for
Temperature setpoints and limits but they do not appear in the generated .zap file
These were identified in #8878

Also the zap tool displays warnings about signed ints but does generate the correct code.

Matter spec seems to have removed the ranges

Proposed Solution
Follow up on these

@jmeg-sfy
Copy link

I think this is almost everywhere the same issue

@bzbarsky-apple
Copy link
Contributor

@chrisbeach59 I believe #330 fixed this.

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Nov 30, 2021

Er, didn't mean to close. @chrisbeach59 please close if this now works as you expect?

@chrisbeach59
Copy link
Author

@bzbarsky-apple OK To Close. I don't have rights to do so.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants