Fix generation of min/max constraints. #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should generate these for all writable attributes that have a min or max specified in the XML. The test change makes sure we are able to actually query size information for our types properly in the test. This also allows removing some workarounds for missing atomic type info.
bzbarsky-apple
force-pushed
the
generate-min-max
branch
from
e88efcd
to
870ef45
Compare
tecimovic
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should generate these for all writable attributes that have a min
or max specified in the XML.
The test change makes sure we are able to actually query size
information for our types properly in the test. This also allows
removing some workarounds for missing atomic type info.