Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More work on the proper zap single instance mode #1205

Merged
merged 8 commits into from
Nov 16, 2023

Conversation

tecimovic
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (f78db78) 65.48% compared to head (95fe9d1) 64.95%.

Files Patch % Lines
src-electron/ide-integration/studio-rest-api.js 32.35% 23 Missing ⚠️
src-electron/main-process/session-timers.js 27.27% 8 Missing ⚠️
src-electron/ui/preload.js 0.00% 3 Missing ⚠️
src-electron/util/util.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1205      +/-   ##
==========================================
- Coverage   65.48%   64.95%   -0.53%     
==========================================
  Files         185      187       +2     
  Lines       19124    19329     +205     
  Branches     4093     4127      +34     
==========================================
+ Hits        12523    12555      +32     
- Misses       6601     6774     +173     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tecimovic tecimovic marked this pull request as ready for review November 15, 2023 16:37
@tecimovic tecimovic merged commit 5c472c0 into project-chip:master Nov 16, 2023
12 of 13 checks passed
@tecimovic tecimovic deleted the server-mode branch November 16, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants