Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start consuming matter xml. #1211

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

tecimovic
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (3461293) 64.95% compared to head (f46d229) 64.81%.

Files Patch % Lines
src-electron/zcl/zcl-loader-new-data-model.js 16.41% 56 Missing ⚠️
src-electron/zcl/zcl-loader-silabs.js 88.46% 3 Missing ⚠️
src-electron/zcl/zcl-loader-dotdot.js 50.00% 2 Missing ⚠️
src-electron/zcl/zcl-loader.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1211      +/-   ##
==========================================
- Coverage   64.95%   64.81%   -0.15%     
==========================================
  Files         187      188       +1     
  Lines       19329    19418      +89     
  Branches     4127     4141      +14     
==========================================
+ Hits        12555    12585      +30     
- Misses       6774     6833      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ively load them in.

At this point, the new data is not yet used, this simply adds the first part of the loading mechanism to deal with it.
@tecimovic tecimovic merged commit 415859f into project-chip:master Nov 30, 2023
15 checks passed
@tecimovic tecimovic deleted the matter-xml branch November 30, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants