Fix zapTypeToClusterObjectType to have correct output for acronyms. #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesharrow
approved these changes
Nov 27, 2023
brdandu
approved these changes
Nov 28, 2023
|
There is a matter code gen failure |
|
@brdandu That codegen failure is because ZAP changed the codegen and no one bothered to update the version in Matter. It has nothing to do with this PR. |
zapTypeToClusterObjectType needs to be consistent with the actual types we generate for cluster objects, and it was producing different output for a struct (or event) which had an all-caps name.
brdandu
force-pushed
the
fix-zapTypeToClusterObjectType
branch
from
eb308f6
to
67a5910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zapTypeToClusterObjectType needs to be consistent with the actual types we generate for cluster objects, and it was producing different output for a struct (or event) which had an all-caps name.