Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the ZAP UI to load when a custom xml file is not found instead of throwing an error #1225

Conversation

brdandu
Copy link
Collaborator

@brdandu brdandu commented Dec 4, 2023

  • The changes to import-json.js allows the ZAP UI to load instead of throwing an error and locking ZAP.
  • Now the error message appears in the ZAP notification's pane so that the user can see a detailed error and act upon it
  • Minor cleanup
  • JIRA: ZAPP-1148

…of throwing an error

- The changes to import-json.js allows the ZAP UI to load instead of throwing an error and locking ZAP.
- Now the error message appears in the ZAP notification's pane so that the user can see a detailed error and act upon it
- Minor cleanup
- JIRA: ZAPP-1148
Copy link
Collaborator

@tecimovic tecimovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@brdandu brdandu merged commit ae7f7cf into project-chip:master Dec 4, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants