Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the IDE integration code. #1229

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

tecimovic
Copy link
Collaborator

No description provided.

@tecimovic tecimovic marked this pull request as ready for review December 5, 2023 16:47
@codecov-commenter
Copy link

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (6e8156d) 64.84% compared to head (ed9481e) 64.85%.

Files Patch % Lines
src-electron/ide-integration/zcl-components.js 31.25% 11 Missing ⚠️
src-electron/ide-integration/studio-rest-api.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1229      +/-   ##
==========================================
+ Coverage   64.84%   64.85%   +0.01%     
==========================================
  Files         188      188              
  Lines       19433    19434       +1     
  Branches     4145     4146       +1     
==========================================
+ Hits        12601    12604       +3     
+ Misses       6832     6830       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulr34 paulr34 self-assigned this Dec 5, 2023
@paulr34 paulr34 merged commit 5f1f3a6 into project-chip:master Dec 5, 2023
13 checks passed
@tecimovic tecimovic deleted the ide-integration-errors branch December 5, 2023 17:47
})
.catch((err) => {
console.log(
env.logWarning(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we push this to the session notification table? Easy reference for the user?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants