Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to create Kueue resources #24

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Jan 4, 2024

Issue link

What changes have been made

Add function to create a Kueue LocalQueue.

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Collaborator

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems useful. but need to fix the GVK if we still want it.

support/kueue.go Outdated Show resolved Hide resolved
support/kueue.go Outdated Show resolved Hide resolved
@tedhtchang
Copy link
Member

tedhtchang commented Apr 9, 2024

@sutaakar It would be handy if I can call local_q, err = test.Client().Kueue().KueueV1beta1().LocalQueue().create(...) in a training operator e2e test.

@sutaakar
Copy link
Contributor Author

@tedhtchang I suppose it is done in #40, right?

@sutaakar sutaakar force-pushed the kueue branch 2 times, most recently from 4667f44 to 083e6da Compare April 11, 2024 09:22
@sutaakar sutaakar changed the title Add function to create a Kueue LocalQueue Add functions to create Kueue resources Apr 11, 2024
@sutaakar
Copy link
Contributor Author

sutaakar commented Apr 11, 2024

@dgrove-oss Fixed and rebased (and enhanced with other resource creations).

@sutaakar
Copy link
Contributor Author

Please take a look

Copy link

openshift-ci bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiripetrlik, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 385b8ef into project-codeflare:main Apr 11, 2024
3 checks passed
@sutaakar sutaakar deleted the kueue branch April 11, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants