Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from AppWrapper v1beta1 to v1beta2 #37

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Conversation

dgrove-oss
Copy link
Collaborator

@dgrove-oss dgrove-oss commented Mar 15, 2024

Issue link

What changes have been made

Context: This PR supports the migration of the codeflare operator from MCADv1 to Kueue+AppWrapper. We should probably wait on merging this PR until the corresponding PRs on the consuming codeflare repos are ready, as the removal of MCADv1 CRDs is a breaking change.

Change summary

  1. Replace MCAD dependency with AppWrapper
  2. Upgrade AppWrapper from v1beta1 to v1beta2
  3. Upgrade to go 1.21
  4. Upgrade go dependencies to match Kueue/AppWrapper requirements
  5. Fix bug in fakeclient initialization (dynamic interface not initialized)

Verification steps

I manually ran go test ./support/. -v

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • [ x ] Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@astefanutti
Copy link
Collaborator

/lgtm

Copy link

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dgrove-oss
Copy link
Collaborator Author

This PR is now ready for review.

Copy link

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One comment

support/appwrapper.go Outdated Show resolved Hide resolved
@astefanutti
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 28, 2024
1. Replace MCAD dependency with AppWrapper
2. Upgrade AppWrapper from v1beta1 to v1beta2
3. Upgrade to go 1.21
4. Upgrade go dependencies to match Kueue/AppWrapper requirements
5. Fix bug in fakeclient initialization (dynamic interface not initialized)
@KPostOffice
Copy link

/approve

Copy link

openshift-ci bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrove-oss, KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 1, 2024
@astefanutti
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 10cc498 into main Apr 4, 2024
4 checks passed
@astefanutti astefanutti deleted the mcadv1b2 branch April 4, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants