Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom-metrics-api implementation [operator] #269

Closed
ChristianZaccaria opened this issue Sep 4, 2023 · 0 comments · Fixed by #270
Closed

Remove custom-metrics-api implementation [operator] #269

ChristianZaccaria opened this issue Sep 4, 2023 · 0 comments · Fixed by #270
Assignees
@ChristianZaccaria

Comments

@ChristianZaccaria
Copy link
Contributor

WHY

All details are found here: project-codeflare/multi-cluster-app-dispatcher#608

tldr, custom-metrics-apiserver provides a template to implement both the custom and external metrics APIs. However, the implementation of the custom metrics API is not used at all.

The removal of this is also important to reduce RBAC surface.

DONE

Bullet point items for what should be completed:

  • Remove everything on custom-metrics-api
  • Remove associated resources
@ChristianZaccaria ChristianZaccaria self-assigned this Sep 4, 2023
@ChristianZaccaria ChristianZaccaria changed the title Remove custom-metrics-api implementation Remove custom-metrics-api implementation [operator] Sep 4, 2023
@ChristianZaccaria ChristianZaccaria mentioned this issue Sep 4, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristianZaccaria ChristianZaccaria

Labels
None yet
Projects
Project CodeFlare Sprint Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove custom-metrics-api templates and resources ChristianZaccaria/codeflare-operator
1 participant
@ChristianZaccaria