Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom-metrics-api templates and resources #270

Conversation

ChristianZaccaria
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria commented Sep 4, 2023

Issue link

Closes #269

What changes have been made

Removed custom-metrics-api templates and associated resources.

The removal of the custom-metrics-api implementation is already done and merged on MCAD: project-codeflare/multi-cluster-app-dispatcher#619

Checks

  • e2e tests should continue to pass.

@ChristianZaccaria ChristianZaccaria requested review from astefanutti and removed request for anishasthana and dimakis September 4, 2023 12:24
@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/retest

@openshift-ci openshift-ci bot removed the lgtm label Sep 4, 2023
@astefanutti
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 5, 2023
@astefanutti
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit bf0fd98 into project-codeflare:main Sep 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove custom-metrics-api implementation [operator]
3 participants