Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for operator #18

Merged
merged 6 commits into from
Feb 24, 2023
Merged

Add unit tests for operator #18

merged 6 commits into from
Feb 24, 2023

Conversation

anishasthana
Copy link
Member

Signed-off-by: Anish Asthana anishasthana1@gmail.com

@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2023 •
edited
Loading

@anishasthana: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 93748ad link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@anishasthana
Copy link
Member Author

Closes #1 and #3

@anishasthana
Add working unit tests
485d0a5 
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
@anishasthana
Update Ginkgo version to v2
5d50901 
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
@anishasthana
Add Pre-commit config
394e4d3 
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
@anishasthana
Fix pre-commit failures
d280fdf 
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
@anishasthana
Update yamllint configuration
d611381 
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
@anishasthana
Yaml fixes for yaml linting
e4fd7e8 
Signed-off-by: Anish Asthana <anishasthana1@gmail.com>
KPostOffice
KPostOffice approved these changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@KPostOffice KPostOffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 24, 2023
@KPostOffice
Copy link
Collaborator

/approve

@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b94ee4d into project-codeflare:main Feb 24, 2023
@anishasthana anishasthana deleted the create_unit_tests branch February 24, 2023 21:24
@anishasthana anishasthana mentioned this pull request Mar 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KPostOffice KPostOffice KPostOffice approved these changes

@Maxusmusti Maxusmusti Awaiting requested review from Maxusmusti

Assignees

@KPostOffice KPostOffice

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anishasthana @KPostOffice @openshift-merge-robot