Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add step to sync ODH notebooks with Codeflare-SDK release #460

Merged

Conversation

abhijeet-dhumal
Copy link
Contributor

@abhijeet-dhumal abhijeet-dhumal commented Feb 5, 2024

Issue link

https://issues.redhat.com/browse/RHOAIENG-2341

What changes have been made

Add step to sync ODH notebooks with Codeflare-SDK release by creating automated PR for Project-Codeflare-notebooks repository with latest Cddeflare-SDK release version

Verification steps

A test run in fork results in the following automated PR changes :
Successful test build
Generated automated test PR
Incase codeflare-sdk version doesn't exist

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@abhijeet-dhumal abhijeet-dhumal force-pushed the add-odh-sync branch 6 times, most recently from 4d005cb to adf906f Compare February 8, 2024 11:30
@abhijeet-dhumal abhijeet-dhumal force-pushed the add-odh-sync branch 2 times, most recently from 24021ca to 04d4d67 Compare February 9, 2024 07:56
@sutaakar
Copy link
Contributor

sutaakar commented Feb 9, 2024

When I use non existing SDK version then workflow passes and create malformed PR, I would expect it to fail.

@abhijeet-dhumal
Copy link
Contributor Author

abhijeet-dhumal commented Feb 9, 2024

When I use non existing SDK version then workflow passes and create malformed PR, I would expect it to fail.

@sutaakar let me add a validation, if package with mentioned version doesn't exists then exit with status code 1? : please review this build : https://github.com/abhijeet-dhumal/codeflare-operator/actions/runs/7843668930/job/21404494590#step:6:77
Error: Package 'codeflare-sdk' version '0.14.0' not found.

@sutaakar
Copy link
Contributor

sutaakar commented Feb 9, 2024

@abhijeet-dhumal Can you adjust the script that if pipenv fails for any reason then workflow fails?

@abhijeet-dhumal
Copy link
Contributor Author

abhijeet-dhumal commented Feb 9, 2024

@abhijeet-dhumal Can you adjust the script that if pipenv fails for any reason then workflow fails?

@sutaakar I think this will take care of it, by any means if pipenv doesn't work then workflow will fail with exit status 1 : https://github.com/project-codeflare/codeflare-operator/pull/460/files#diff-22734aa74fc5a41e0fa73ccdcaf804ad0bd18e14e9c31cf6e181ec1e6c0916b5R61-R63
if ! versions=$(pipenv run pip-versions list $package_name);then
echo "Failed to retrieve versions for $package_name"
exit 1
fi
latest build with non-existing version 0.14.0 : https://github.com/abhijeet-dhumal/codeflare-operator/actions/runs/7844005930/job/21405489057#step:6:80

Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@Srihari1192 Srihari1192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

openshift-ci bot commented Feb 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Srihari1192, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit aa9c7ff into project-codeflare:main Feb 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants