Fix and enable local_interactive feature by default

[ChristianZaccaria]

Rayclient Route to resolve its own ingress domain, and enable local_interactive by default

Issue link

Jira: https://issues.redhat.com/browse/RHOAIENG-5330

What changes have been made

• Set local_interactive feature to be always enabled by default.
• RayClient Route now resolves its own ingress domain based on the route's name and namespace.
• Removed unused annotationBoolVal()
• Add ingressDomain field to CFO configmap: This field has is empty by default and is used for the generation of the full rayclient client and dashboard ingress hosts. I.e., ray-dashboard-<clusterName>-<namespace>.fake.domain or rayclient-<clusterName>-<namespace>.fake.domain.

Verification steps

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[sutaakar]

Is there a specific reason to set kind domain here?
I suppose it is already passed in config/e2e/config.yaml for tests

[ChristianZaccaria]

You have an eagle eye, thanks for pointing that out. That was done for my own testing, changed back to fake.domain (or whichever other default domain name we prefer). Thanks!

[sutaakar]

Thinking why we should actually provide any default value?
Would it have more sense to keep it empty (not defined), failing operator with meaningful error message if customer won't provide it?

[ChristianZaccaria]

/hold

[sutaakar]

/lgtm

[sutaakar]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sutaakar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment