Add RayCluster mutating webhook #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
astefanutti
requested review from
KPostOffice,
VanillaSpoon and
sutaakar
and removed request for
MichaelClifford and
tedhtchang
sutaakar
reviewed
Apr 17, 2024
| kind: Service | ||
| metadata: | ||
| name: webhook-service | ||
| namespace: openshift-operators |
There was a problem hiding this comment.
Suggested change
| namespace: openshift-operators | |
| namespace: system |
sutaakar
reviewed
Apr 17, 2024
|
|
||
| rayclusterlog.V(2).Info("Adding OAuth sidecar container") | ||
| // definition of the new container | ||
| newOAuthSidecar := corev1.Container{ |
There was a problem hiding this comment.
Would it have sense to limit Resources for oauth container?
There was a problem hiding this comment.
Right, for the sake of keeping that PR from growing too big, I'd suggest to add that in a separate PR.
sutaakar
reviewed
Apr 17, 2024
|
/lgtm |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #522