-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enableIngress and set to false by default #506
Add enableIngress and set to false by default #506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have run this alongside opendatahub-io/kueue#26 and it works as expected. Just one question.
69ae442
to
b9a339c
Compare
/lgtm |
@dimakis RE: can the user modify the No, webhook PR in Kueue also forbids the modification of the |
6750750
to
474427a
Compare
474427a
to
a347159
Compare
Rebased - e2e tests passing in this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fiona-Waters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a53fc1e
into
project-codeflare:main
Issue link
Jira: https://issues.redhat.com/browse/RHOAIENG-5116
What changes have been made
enableIngress
field toheadGroupSpec
and set to false by default.enableIngress
field is not false.Verification steps
Should be tested with this Kueue PR - Can be followed here
Checks