Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enableIngress and set to false by default #506

Conversation

ChristianZaccaria
Copy link
Contributor

Issue link

Jira: https://issues.redhat.com/browse/RHOAIENG-5116

What changes have been made

  • Added enableIngress field to headGroupSpec and set to false by default.
  • Added Forbidden message on attempt to create a RayCluster where the enableIngress field is not false.
  • The loop iterates over the resources in loaded in yaml file and looks for the RayCluster resource and the enableIngress field. If the enableIngress field is not False, forbidden message is displayed to the user, and if it is False, then we create the resources.

Verification steps

Should be tested with this Kueue PR - Can be followed here

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Contributor

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have run this alongside opendatahub-io/kueue#26 and it works as expected. Just one question.

src/codeflare_sdk/cluster/cluster.py Outdated Show resolved Hide resolved
@sutaakar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@ChristianZaccaria
Copy link
Contributor Author

@dimakis RE: can the user modify the enableIngress field from an already existing RayCluster resource?

No, webhook PR in Kueue also forbids the modification of the enableIngress field to anything that is not false, including if the user attempts to remove the field entirely would be forbidden.

image

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2024
@ChristianZaccaria
Copy link
Contributor Author

Rebased - e2e tests passing in this PR

Copy link
Contributor

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2024
Copy link
Contributor

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fiona-Waters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a53fc1e into project-codeflare:main Apr 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants