Add warning if Kueue CRDs not installed on cluster #534
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
| @@ -321,6 +321,10 @@ def write_components( | |||
| os.makedirs(directory_path) | |||
|
|
|||
| components = user_yaml.get("spec", "resources")["resources"].get("GenericItems") | |||
| if local_queue is None: | |||
There was a problem hiding this comment.
This will only check if the local_queue variable has been set by the user in the cluster config. If we want to check for the existence of the queue CRDs we could do it like it is done here with the RayCluster CRD.
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Issue link
RHOAIENG-6294
What changes have been made
A warning has been added to the ClusterConfiguration cell to inform users if Kueue CRDs are not installed on the cluster and local_queue is not provided. In this scenario, users will receive informative logs indicating that the absence of CRDs may result in missing functionality.
Verification steps
Uninstall Kueue and delete any CustomResourceDefinitions (CRDs) that exist (filter for
CustomResourceDefinitionin resources and selectLocalQueuein the name). Clone this branch into Jupyter Notebook, attempt to create a Ray cluster. In the ClusterConfiguration cell, comment out thelocal_queue="local-queue-name"line. When you run it, you should receive a message indicating thatKueue is not installed or won't be used. The absence of CRDs may result in missing functionality.Checks