Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose structured configuration #136

Merged
merged 2 commits into from Sep 13, 2023
Merged

Expose structured configuration #136

merged 2 commits into from Sep 13, 2023

Conversation

astefanutti
Copy link
Contributor

Issue link

Closes #132

What changes have been made

  • Expose a structured configuration API
  • Adapt main.go to use the structured configuration

Verification steps

Start InstaScale, make sure it works as expected.

@astefanutti
Copy link
Contributor Author

/assign @anishasthana @asm582

@anishasthana
Copy link
Member

/hold (I want to make sure we get the codeflare-sdk hotfix release out before this is merged in)

main.go Show resolved Hide resolved
@anishasthana
Copy link
Member

/unhold

@VanillaSpoon
Copy link
Member

Hey, the pkg/config directory is not being copied into the Docker image during the build process causing the build command to fail.

Just a quick change to the Dockerfile:

# Copy the go source
COPY main.go main.go
COPY controllers/ controllers/
+ COPY pkg/ pkg/

@astefanutti
Copy link
Contributor Author

@VanillaSpoon great catch, thanks! Fixed in 0c0fa54.

@asm582
Copy link
Member

asm582 commented Sep 12, 2023

/LGTM

@openshift-ci openshift-ci bot added the lgtm label Sep 12, 2023
@VanillaSpoon
Copy link
Member

/lgtm also :)

@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3db3f4b into project-codeflare:main Sep 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose structured configuration for InstaScale controller
5 participants