Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rem stale code #506

Merged
merged 5 commits into from
Jul 27, 2023
Merged

rem stale code #506

merged 5 commits into from
Jul 27, 2023

Conversation

asm582
Copy link
Member

@asm582 asm582 commented Jul 25, 2023

No description provided.

Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, there's a question around the "Focused" run of one test.

test/e2e/queue.go Outdated Show resolved Hide resolved
@z103cb
Copy link
Contributor

z103cb commented Jul 25, 2023

Also it seems that an unit test is now failing:

=== RUN   TestNodeInfo_AddPod
    node_info_test.go:81: node info 0: 
         expected Node (n1): idle <cpu 5000.00, memory 7000000000.00, GPU 0>, used <cpu 3000.00, memory 3000000000.00, GPU 0>, releasing <cpu 0.00, memory 0.00, GPU 0>, 
         got Node (n1): idle <cpu 8000.00, memory 10000000000.00, GPU 0>, used <cpu 0.00, memory 0.00, GPU 0>, releasing <cpu 0.00, memory 0.00, GPU 0> 
--- FAIL: TestNodeInfo_AddPod (0.00s)
=== RUN   TestNodeInfo_RemovePod
    node_info_test.go:122: node info 0: 
         expected Node (n1): idle <cpu 4000.00, memory 6000000000.00, GPU 0>, used <cpu 4000.00, memory 4000000000.00, GPU 0>, releasing <cpu 0.00, memory 0.00, GPU 0>, 
         got Node (n1): idle <cpu 8000.00, memory 10000000000.00, GPU 0>, used <cpu 0.00, memory 0.00, GPU 0>, releasing <cpu 0.00, memory 0.00, GPU 0> 
--- FAIL: TestNodeInfo_RemovePod (0.00s)

@asm582 asm582 marked this pull request as ready for review July 26, 2023 20:43
test/e2e/queue.go Show resolved Hide resolved
test/e2e/util.go Show resolved Hide resolved
Copy link
Collaborator

@metalcycling metalcycling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Jul 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalcycling

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@asm582 asm582 merged commit 02ccc97 into main Jul 27, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants