Remove unused informers #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asm582
requested review from
astefanutti,
anishasthana,
metalcycling and
z103cb
and removed request for
z103cb
metalcycling
approved these changes
Jul 28, 2023
| @@ -139,10 +98,7 @@ func newClusterStateCache(config *rest.Config) *ClusterStateCache { | |||
|
|
|||
| func (sc *ClusterStateCache) Run(stopCh <-chan struct{}) { | |||
| klog.V(8).Infof("Cluster State Cache started.") | |||
|
|
|||
| go sc.podInformer.Informer().Run(stopCh) | |||
There was a problem hiding this comment.
I'm sure you checked this, but we have an informer for pods somewhere else, right? Like to keep track of how many are alive before recycling the job.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalcycling The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
#522
What changes have been made
I have removed unused informers from the cache infrastructure of MCAD
Verification steps
I have run e2e ends on the local machine and they all pass
Checks