Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use receive-only channels for stopping controllers #551

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

astefanutti
Copy link
Contributor

This follows the idiomatic syntax, and eases the re-use the MCAD controllers.

Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@asm582
Copy link
Member

asm582 commented Aug 7, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asm582

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit 55fb5ee into project-codeflare:main Aug 7, 2023
2 checks passed
@astefanutti astefanutti deleted the pr-07 branch August 10, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants